1065 Commits

Author SHA1 Message Date
tjhunt
4092803615 Clean up some more todos. 2009-07-17 08:26:13 +00:00
tjhunt
1428f47181 block/search: Eliminate todo that was already done, and clean up whitespace. 2009-07-17 08:07:50 +00:00
tjhunt
f7acfadd0a admin block: MDL-16693 fix todo. 2009-07-17 07:46:04 +00:00
tjhunt
9ce7265cd0 admin bookmarks: remove useless todo. 2009-07-17 07:42:21 +00:00
tjhunt
73e2e5c03d blocks editing ui: MDL-19398 Can now edit the position of any block.
I think this is probaby insecure at the moment. I am still working on it.
2009-07-16 11:05:26 +00:00
tjhunt
1d13c75c15 blocks editing ui: MDL-19398 Can how precisely control block positioning using the edit icon
This mostly works now, but ...
* The UI needs further work. In particular we need a non-advanced mode.
* This only works for blocks that use a new edit_form.php to replace config_instance.html.
* .. and so far I have only implemented edit_form.php for the HTML block so far.
* Needs to be enabled (with no block-specific config) for blocks without instance config, so you can control their positioning.
2009-07-16 10:50:19 +00:00
tjhunt
ec972adefe Fix boilerplate. 2009-07-15 08:59:51 +00:00
tjhunt
15a00b4be0 blocks editing ui: MDL-19398 Remove stupid pass by reference.
Was causing errors when this method was called via block_method_result
2009-07-15 08:55:52 +00:00
tjhunt
7cf51142ab blocks editing ui: MDL-19398 Make block config_global.html files more strongly deprecated. 2009-07-15 08:52:33 +00:00
tjhunt
bc422e6955 blocks editing ui: MDL-19398 Make invisible blocks at least partly invisible. 2009-07-15 07:45:48 +00:00
tjhunt
ae42ff6fee blocks editing ui: MDL-19398 showing and hiding blocks now works. 2009-07-15 07:41:25 +00:00
tjhunt
1936f20b8b blocks editing ui: MDL-19398 move generating the block edit icons to blocklib.php
Since that is where the resulting actions are processed.
2009-07-14 10:57:06 +00:00
tjhunt
b97fb57fe3 fix typo 2009-07-14 09:35:33 +00:00
tjhunt
a2789e3426 blocks editing ui: MDL-19398 add block now secure. Delete block works insecurely.
Will add security checks in a moment.
2009-07-14 08:37:28 +00:00
tjhunt
f674ec8640 blocks: MDL-19010 show empty blocks if they have controls. 2009-07-14 07:06:06 +00:00
tjhunt
e92c286c20 block contexts: MDL-19098 every block should have a context
even non-course and sticky blocks.

The parent context is block_instances.parentcontextid.

The block context should be used for checking permissions directly
related to the block, like moodle/block:view or moodle/site:manageblocks.

However, if the block is displaying information about the current page,
for example the participants block showing who 'here', then it may be
better to use the context of the page where the bloack is appearing -
in other words $this->page->context - to check permissions about the
user's ability to see participants here.

Or, if the block is displaying something stronly related to courses,
for example, a course meny block, the block should probably use the
context for $this->page->course to check permissions.
2009-07-13 08:37:34 +00:00
skodak
462caf41b2 MDL-16630 do not show admin tree until the site is fully configured 2009-07-09 20:17:41 +00:00
tjhunt
d4a03c00ea themes & blocks - MDL-19077 & MDL-19010 blocks are now printed by the theme
The code to print blocks in now in theme layout.php files. (Or in
moodle_core_renderer::handle_legacy_theme)

Code for printing blocks everywhere else has been stripped out.
(Total diffstat 1225 insertions, 2019 deletions)

The way the HTML for a block instance is generated has been cleaned
up a lot. Now, the block_instance generates a block_contents
object which gives a structured representation of the block,
and then $OUTPUT->block builds all the HTML from that.

How theme config.php files specify the layout template and block
regions by page general type has been changed to be even more flexible.

Further refinement for how the theme and block code gets initialised.

Ability for scrits to add 'pretend blocks' to the page. That is,
things that look like blocks, but are not normal block_instances.
(Like the add a new block UI.)

Things that are still broken:
 * some pages in lesson, quiz and resource. I'm working on it.
 * lots of developer debug notices pointing out things that
   need to be updated.
2009-07-09 07:35:03 +00:00
tjhunt
666e84584c MDL-19690 - more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-03 04:23:05 +00:00
tjhunt
e63f88c9a6 MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url
and $CFG->modpixpath to $OUTPUT->mod_icon_url
2009-07-02 12:07:58 +00:00
tjhunt
6b608f8f50 MDL-19690 - lots more $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-02 10:53:31 +00:00
tjhunt
4096752d1d MDL-19690 - first 53 $CFG->pixpath to $OUTPUT->old_icon_url 2009-07-02 10:06:39 +00:00
nicolasconnault
98f7f6919e MDL-19677 Reverting prematurely committed blog patch 2009-07-02 06:43:43 +00:00
nicolasconnault
856b6fe6d2 MDL-19676 Removed course and group visibility settings for blog 2009-07-01 08:49:47 +00:00
tjhunt
c207b6bece Remove a few unnecessary references to global $THEME. 2009-06-25 03:26:58 +00:00
skodak
17da2e6f28 MDL-16438 centralise information about plugins to avoid duplication, includes local customisation conversion to standard plugin structure + fixes for some recent regressions; see tracker for more details and links to docs and forums discussions 2009-06-19 14:25:56 +00:00
skodak
9d7493399d MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:35:10 +00:00
skodak
bb4b6010f3 MDL-18293 removed obsoleted checking of return values from insert and update_record + unused strings cleanup 2009-06-13 17:17:10 +00:00
tjhunt
cf6155226c ajaxlib/require_js: MDL-16693 $PAGE->requires->... deprecates require_js etc.
There is a new implementation of require_js in lib/deprecatedlib.php,
based on $PAGE->requires.

There were a few other recently introduced functions in lib/weblib.php,
namely print_js_call, print_delayed_js_call, print_js_config and
standard_js_config. These have been removed, since they were never in
a stable branch, and all the places that used them have been changed
to use the newer $PAGE->requires->... methods.

get_require_js_code is also gone, and the evil places that were calling
it, even though it is an internal function, have been fixed.

Also, I made some minor improvements to the code I committed yesterday
for MDL-16695.

All that remains is to update all the places in core code that are
still using require_js.

(This commit also fixes the problem where the admin tree would not
start with the right categories expanded.)
2009-06-12 12:13:07 +00:00
tjhunt
f4d76b9cdf blocklib: MDL-19010 fix some minor problems with existing blocks. 2009-06-05 08:28:45 +00:00
stronk7
942cd61b2e MDL-19350 upgrade review - adding missing savepoints to blocks 2009-06-03 14:49:57 +00:00
tjhunt
e03c0c1d49 blocklib: MDL-19010 fix editing block config and block roles. 2009-05-08 07:47:50 +00:00
tjhunt
f4d38d20fb blocklib: MDL-19010 and now you can delete blocks too! 2009-05-08 06:34:40 +00:00
tjhunt
f474a4e583 blocks: MDL-19010 Fix further blocks-related breakage, including removing all references to blocks_insance_old outside blocklib.php 2009-05-07 08:55:10 +00:00
tjhunt
cb6402296c blocklib: MDL-19010 remove no-longer-necessary global variable use from blocks 2009-05-06 09:28:26 +00:00
tjhunt
3179b0006a blocklib: MDL-19010 Fix blocks that were relying on ->instance in an unfortunate way 2009-05-06 09:15:33 +00:00
tjhunt
66b10689e2 blocklib: MDL-19010 upgrade database tables ready for now blocks system 2009-05-06 09:12:03 +00:00
tjhunt
f8b80dbd95 moodle_page: MDL-12212 completely remove the old tag and admin page classes 2009-05-06 09:11:07 +00:00
tjhunt
cfcfb9f3d0 moodle_page: MDL-12212 kill legacy page_allows_editing implementations 2009-05-06 09:02:48 +00:00
tjhunt
830dd6e9cd moodle_page: MDL-12212 reimplement user_is_editing, deprecate isediting 2009-05-06 08:59:29 +00:00
tjhunt
ad52c04f4c moodle_page: MDL-12212 Kill legacy url_... and blocks_... methods
Start calling $PAGE->set_url in all the places it will be necessary
Start of a stub implementation of $PAGE->blocks to stop other things breaking
Remove some of the special case methods in admin_page
2009-05-06 08:55:53 +00:00
tjhunt
c4740390b5 moodle_page: MDL-12212 remove useless code as a preparitory step 2009-05-06 08:26:19 +00:00
stronk7
74c288a100 MDL-18577 drop enums support - step2: enums out from install.xml files 2009-05-01 14:07:43 +00:00
poltawski
becf869c6b blocks/tags Move youtube/flickr blocks away from magpie
Instead use our general curl cache MDL-18973
2009-04-26 15:19:45 +00:00
skodak
cbc2b5df03 MDL-18901 reimplemented trusstext support in glossary + standardising format column for text fields 2009-04-20 10:05:50 +00:00
tjhunt
ccc161f8f0 filters: MDL-7336 change weblib to use the new code
* Rename filter base class from filter_base to moodle_text_filter
* Remove unnecessary explicit constructors in moodle_text_filter
subclasses
* New filter_manager class, rather than static methods in filter_base
* Move some logic out of weblib, and into filter_manager
* Count filtering ops when $CFG->perfdebug on, via
performance_measuring_filter_manager
* Kill unused filter_string function. Petr said it should have been
private to weblib
2009-04-13 06:56:32 +00:00
poltawski
8a083dc75b Messages block: Incorrect link to user profile
The block incorrectly links to site profile in the current pageid.
This doens't make sense in a number of different scenarios, but
most notably if the user who messaged isn't enrolled in the current
course. Instead link to the profile at site context like the messaging
popup does.

Fixes: MDL-18279 MDL-6890 MDL-5887
merged from MOODLE_19_STABLE
2009-03-22 22:40:07 +00:00
mjollnir_
2a42e8954f MDL-18351: activity block: detect when there's no course (eg admin page) and return (merged from MOODLE_19_STABLE) 2009-02-23 14:49:05 +00:00
Francois Marier
6280ef3e58 Fix CVS-git drift (remove some files deleted in CVS) 2009-02-01 23:43:28 +00:00
skodak
795a08adb7 MDL-17458 upgrade logging implemented + a lot more refactoring + exceptions implemented in install/upgrade code + lang pack cleanup + some more improvements 2009-01-31 20:07:32 +00:00