9411 Commits

Author SHA1 Message Date
Marina Glancy
b1c97381b4 MDL-76356 various: avoid implicit conversion to int
PHP before version 8.1 automatically converted to int if the function
parameter (or array key) is expected to be int. PHP 8.1 shows notice in
this case
2023-01-10 15:27:11 +01:00
Marina Glancy
594a8c5ab7 MDL-76356 various: avoid implicit conversion to arrays
PHP before version 8.1 automatically converted stdClass or 'false' to arrays if
function parameter expects array (for example, "reset").
PHP 8.1 shows notices in these situations
2023-01-10 12:16:52 +01:00
Jun Pataleta
401fc00245 Merge branch 'MDL-74822-master' of https://github.com/HuongNV13/moodle 2023-01-04 17:29:26 +08:00
Paul Holden
63a43391ad Merge branch 'MDL-58615-master' of https://github.com/andrewnicols/moodle 2023-01-03 09:20:22 +00:00
Andrew Nicols
1ac2eb53fb MDL-58615 core: Remove the useexternalyui setting
I have opted not to go through any deprecation process for this as there
is not really much we can do about it anyway. There is no loss of
functionality - just a change of where things are served from.

The Yahoo! CDN was only used for http connections as it did not
officially support SSL, and it is not guaranteed to continue existing in
the future since YUI has been deprecated for a number of years now.
2023-01-03 11:43:01 +08:00
Huong Nguyen
ef8420e5a3 MDL-74822 usertours: Fix accessibility issues with user tours
Including in this commit:
 - Prevent the tour to be displayed if the CSS is disabled by the browser
 - Removed redundant tabindex=0 attribute on the target
 - Created extra code to re-calculate the suitable position of the tour
 - Fixed tour issue in 200% and 400% zoom
 - Fixed tour highlight is not correct in 200% and 400%
2023-01-03 10:34:48 +07:00
Sara Arjona
6821897849 Merge branch 'MDL-76760' of https://github.com/paulholden/moodle 2023-01-02 12:27:34 +01:00
Ilya Tregubov
e3d5313d55 MDL-76399 behat: switch to appropriate Behat step for selects. 2022-12-29 14:57:31 +07:00
Paul Holden
3982341f7a MDL-76760 tool_behat: defer library loading until service execution.
Ensures that API documentation can be generated without requiring
the presence of the `vendor/` directory.
2022-12-28 10:08:10 +00:00
Sara Arjona
407f0604ba Merge branch 'MDL-76679' of https://github.com/paulholden/moodle 2022-12-27 16:55:17 +01:00
Sara Arjona
0b733266b0 Merge branch 'MDL-72775-master' of https://github.com/QihuiChan/moodle 2022-12-27 16:12:50 +01:00
Qihui Chan
791e56d3bc MDL-72775 tool_task: check long running tasks 2022-12-23 09:41:05 +10:00
Andrew Nicols
a13484242b MDL-75105 tool_behat: Coding style fixes 2022-12-22 12:24:57 +07:00
Andrew Nicols
98cc2716f0 Merge branch 'MDL-75105_master' of https://github.com/marxjohnson/moodle 2022-12-22 12:24:57 +07:00
Mark Johnson
b05efb43a4 MDL-75105 tool_behat: List available data generators
This will find all data generators that can be used in behat via the
'the following "something" exist:' step, and display them in a select
list on the step definitions page.

When a generator is selected, it will fetch the required fields for that
generator and display them on the page.
2022-12-21 08:38:09 +00:00
Farhan Karmali
bb82d29dd9 MDL-75667 admin: Fix cross db query issue for blocks 2022-12-20 17:29:13 +05:30
Farhan Karmali
b4e5e47a0f MDL-75667 admin: Avoid DB calls within loops on admin/blocks.php 2022-12-16 18:53:58 +05:30
Andrew Nicols
ee48f4ab99 Merge branch 'MDL-74923' of https://github.com/timhunt/moodle 2022-12-15 07:35:46 +08:00
Paul Holden
698afd1708 MDL-76679 admin: correct password config field template.
The template changes were missed as part of 0795b579, update them
to match so that they continue to work with the unmask JS module.
2022-12-14 19:07:10 +00:00
Sara Arjona
e0f6940bb2 Merge branch 'MDL-75805' of https://github.com/paulholden/moodle 2022-12-14 18:12:50 +01:00
Paul Holden
5158be1b64 Merge branch 'MDL-76666' of https://github.com/stronk7/moodle 2022-12-14 13:22:01 +00:00
Eloy Lafuente (stronk7)
9a6701c572 MDL-76666 local_langimport: Better handling of long locales
Under some linux versions, and depending of the configured
locale categories, it's possible to get a current locally
which length > 255 when calling to setlocale(LC_ALL, 0).

Later, if that long locale is tried to be restored, there
is a "setlocale(): Specified locale name is too long" warning
error.

When that happens we need to split the long locale into
individual chunks and set all the (six) locale categories
supported one by one.

Covered with tests, note that, in practice, this only
happens with linux because it supports 12 locale categories
@ OS level. Both BSD (6) and Windows (5) hardly can reach the limit.

No matter of that, the tests have been designed to ensure that
they pass on all OSs, just the new code only will be executed
on linux.
2022-12-14 12:24:15 +01:00
Tim Hunt
9efec07f77 MDL-74923 quiz: move admin setting classes to mod_quiz\admin namespace 2022-12-13 16:24:58 +00:00
Jackson D'souza
4c5b4003c3 MDL-75571 tool_componentlibrary: Custom activity icon 2022-12-09 15:53:23 +00:00
Paul Holden
253c041297 MDL-75805 admin: allow multiselect when editing site administrators. 2022-12-09 11:22:07 +00:00
Jun Pataleta
ae2a313c95 Merge branch 'MDL-76556-master' of https://github.com/andrewnicols/moodle 2022-12-08 10:07:52 +08:00
Andrew Nicols
6982caf746 Merge branch 'MDL-76491' of https://github.com/paulholden/moodle 2022-12-08 08:08:19 +08:00
Andrew Nicols
bf5efe9d0b Merge branch 'MDL-76116-master' of https://github.com/meirzamoodle/moodle 2022-12-08 06:14:24 +08:00
Jun Pataleta
51d1448b06 Merge branch 'MDL-73017_add-environment-check-for-versions-not-supporting-php-8-1' of https://github.com/ziegenberg/moodle 2022-12-07 13:47:04 +08:00
Meirza
883c1becc5 MDL-76116 mnet: styling the delete key confirmation window properly 2022-12-07 11:14:05 +07:00
Daniel Ziegenberg
afe68a65cb
MDL-73017 env: Moodle 3.9.x, 3.11.x and 4.0.x do not support PHP 8.1
This commit adds an additional environment check for the unsupported
PHP 8.1 version to Moodle 3.9.x, 3.11.x and 4.0.x.

It also updates the lang string for unsupported PHP version.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
2022-12-05 11:39:14 +01:00
Andrew Nicols
a8f63b26be MDL-76556 tool_log: Set the store property correctly 2022-12-03 11:47:53 +08:00
Paul Holden
077a30b7ff MDL-76491 javascript: add missing core/notification imports. 2022-12-02 10:05:28 +00:00
Dani Palou
6ab826fb23 MDL-75788 behat: Use profile field generators in existing tests 2022-12-02 14:54:47 +08:00
Ilya Tregubov
05535e38df Merge branch 'MDL-76497-master' of https://github.com/junpataleta/moodle 2022-12-01 08:56:09 +03:00
Sara Arjona
919302aa1a Merge branch 'MDL-76226' of https://github.com/paulholden/moodle 2022-12-01 08:55:34 +03:00
Ilya Tregubov
9ba9589f09 Merge branch 'MDL-74853-master' of https://github.com/marinaglancy/moodle 2022-12-01 08:55:34 +03:00
Jun Pataleta
bc0c11a191 Merge branch 'MDL-68981-master' of https://github.com/HuongNV13/moodle 2022-12-01 08:55:34 +03:00
Andrew Nicols
a4ad23b855 Merge branch 'MDL-76127-master' of https://github.com/meirzamoodle/moodle 2022-12-01 08:55:33 +03:00
Ilya Tregubov
72145fc34d Merge branch 'MDL-72019-master' of https://github.com/meirzamoodle/moodle 2022-12-01 08:55:33 +03:00
Huong Nguyen
45e3d815b0 MDL-68981 tool_recyclebin: Force necessary settings when restoring
Created code to force the necessary settings for restore_item in:
  + course_bin class
  + category_bin class
2022-11-30 10:16:53 +07:00
Paul Holden
23df60893a MDL-76226 admin: account for preset config checkboxes other than bool.
The assumption that the settings checkbox always stores boolean values
(e.g. 0/1) isn't correct. The `perfdebug` configuration instead uses
the values 7/15.
2022-11-28 16:04:08 +00:00
Marina Glancy
a800e7e62f MDL-74853 various: add second parameter to htmlentities functions
Default value of the $flag argument changed in PHP 8.1 from ENT_COMPAT to ENT_QUOTES | ENT_SUBSTITUTE
To ensure consistent behavior across different PHP version the second parameter is now required for the functions:
htmlspecialchars(), htmlentities(), htmlspecialchars_decode(), html_entity_decode() and get_html_translation_table()
2022-11-28 16:12:20 +01:00
Jun Pataleta
c6ab792ddf MDL-76497 upgrade: add the 4.1.0 separation line to all upgrade scripts 2022-11-28 14:43:04 +08:00
Huong Nguyen
e4fde5a93e MDL-68981 tool_recyclebin: Extra PHPUnit with General restore config 2022-11-28 09:33:36 +07:00
Huong Nguyen
d1fab0c619 MDL-68981 tool_recyclebin: Extra Behat test with General restore config
Including in this commit:
 - Convert existing Behat scenario to use Data generators
 - Convert existing Behat scenario to use Provider
 - Add new scenario for Include users setting in General restore page
2022-11-28 09:33:36 +07:00
Andrew Nicols
08a19dbed8 Merge branch 'MDL-76403-master' of https://github.com/junpataleta/moodle 2022-11-24 10:18:22 +08:00
Andrew Nicols
688873c84b Merge branch 'MDL-76395-master-enfix' of https://github.com/vmdef/moodle 2022-11-24 10:16:39 +08:00
Helen Foster
74828e8149 MDL-76395 lang: Import fixed English strings (en_fix) 2022-11-23 17:03:58 +00:00
Stevani Andolo
e4da62b5f1 MDL-73964 core: Update support site/email usage to use supportemail
This ensures the correct link is provided (and not email address
itself), and honours the supportavailability setting.
2022-11-23 11:44:19 +08:00