Juan Leyva
df3d877656
MDL-63832 assign: Check current user can view submission
2018-11-14 16:53:34 +01:00
Jun Pataleta
1d2adca39b
Merge branch 'MDL-63924-master' of git://github.com/andrewnicols/moodle
2018-11-09 11:57:38 +08:00
Andrew Nicols
c96cd71102
MDL-63924 privacy: Add shared user providers to subsytsems
2018-11-08 21:26:18 +08:00
Dan Marsden
e6a93dc215
MDL-63800 mod_assign: don't show grade if not set.
2018-11-06 10:04:15 +13:00
Andrew Nicols
f8e364e31a
Merge branch 'MDL-63422' of git://github.com/stronk7/moodle
2018-11-02 08:22:33 +08:00
Andrew Nicols
bdccab4769
Merge branch 'MDL-63816-master' of git://github.com/mickhawkins/moodle
2018-11-02 08:00:32 +08:00
Eloy Lafuente (stronk7)
9c0e123af0
MDL-63826 tests: Don't rely on random array keys for testing
2018-11-01 00:28:35 +01:00
Jun Pataleta
52d575b396
Merge branch 'MDL-63820' of git://github.com/albertgasset/moodle
2018-10-31 16:01:40 +08:00
Michael Hawkins
b16a3388bb
MDL-63816 privacy: Corrected provider get_users_in_context descriptions
2018-10-31 12:13:30 +08:00
Eloy Lafuente (stronk7)
bd5fdcfccd
MDL-63422 general: review core loop / switch / case / continue
...
This commit reviews all continue uses in core happening within a
loop / switch / case hierarchy. This does not cover:
- Changes to libraries. Will be handled in another issue / commit.
- Uses out from loops, will be reviewed by other commit.
The policy followed has been:
- When possible, take rid of the continue.
- When clearly the intention was to jump to next element in loop
change to continue 2
- When it was not clear, keep old behavior switching to break, no
matter how weird the behavior may be.
2018-10-31 00:17:59 +01:00
Albert Gasset
577fdc3438
MDL-63820 assignfeedback_comments: Implement get_file_areas
2018-10-30 15:25:58 +01:00
Jun Pataleta
ae29ec8d13
Merge branch 'MDL-63531-master' of git://github.com/andrewnicols/moodle
2018-10-30 10:50:52 +08:00
Adrian Greeve
d2148f32ca
MDL-63531 privacy: Update to comments provider to simplfy sql.
...
This updates the get_users_in_context_from_sql query to include
the context id to simplify the calls made from other components.
2018-10-30 09:47:14 +08:00
Adrian Greeve
6592598f71
MDL-63531 assignfeedback: Update to use the new privacy interface.
...
This now uses the new interface to allow the deletion of users based
on a context.
2018-10-30 09:47:14 +08:00
Adrian Greeve
d8cd86e1b1
MDL-63531 assignsubmission: Update to use the new interface.
...
This updates the plugins to use the new inteface for deleting
data for users in a context.
2018-10-30 09:47:14 +08:00
Adrian Greeve
b96e7fa6b2
MDL-63531 mod_assign: Update mod assign to use new interface.
...
This introduces a new interface for assign sub-plugins and
updates the mod_assign provider to implement the new general
interface for deleting data for users in a context.
2018-10-30 09:06:12 +08:00
Eloy Lafuente (stronk7)
f3d80b483b
Merge branch 'MDL-63730-master-enfix' of git://github.com/mudrd8mz/moodle
2018-10-29 13:23:53 +01:00
Helen Foster
0c19b2c8fa
MDL-63730 lang: Merge English strings from the en_fix language pack
...
Significant string changes:
* withselectedusers_help, core - removing mention of 'Add a common note'
as the option no longer exists
* considereddigitalminor and digitalminor_desc, core - more
child-friendly wording
* configmessagingallusers, core_admin - clearer explanation
* auth_dbtype, auth_db - fixed broken link
2018-10-26 12:48:40 +02:00
Damyon Wiese
cfd390ee94
MDL-63765 behat: Fix behat tests opening a menu
...
If javascript is disabled, we don't need to open the menus at all. If it is enabled
we should use the custom step where possible.
In some tests (user profile) we have to use link_or_button because
the element that opens the menu will be a link or a button in different themes.
2018-10-26 16:14:41 +08:00
Damyon Wiese
efacf3a099
MDL-61052 assign: Do not queue conversions
...
Identical submissions do not require individual conversions from the document converter. Text passing through
format_text cannot be trusted and is likely to be unique each time, even for the same text.
2018-10-22 11:56:57 +08:00
Zig Tan
888d7b585f
MDL-61052 assign: Improve strip_images() to avoid HTML5 tags errors
2018-10-22 11:56:33 +08:00
Mark Nelson
66b5036805
MDL-27520 assignfeedback_comments: fix Behat failures
2018-10-18 18:32:59 +08:00
David Monllao
a9bbbd7a50
Merge branch 'MDL-27520_master' of git://github.com/markn86/moodle
2018-10-17 15:42:55 +02:00
Mark Nelson
464a9dc556
MDL-27520 assignfeedback_comments: is_feedback_modified considers files
2018-10-17 15:57:27 +08:00
Mark Nelson
b7a9b6f872
MDL-27520 assignfeedback_comments: updated privacy provider
2018-10-17 15:57:27 +08:00
Mark Nelson
0e732f5d33
MDL-27520 assignfeedback_comments: added backup/restore of files
2018-10-17 13:15:49 +08:00
Mark Nelson
3672775931
MDL-27520 assignfeedback_comments: copy files to feedback
...
This respects the setting 'Comment inline' where the content
of a submission is copied into the feedback form.
2018-10-17 13:15:49 +08:00
Mark Nelson
ea241998e6
MDL-27520 assignfeedback_comments: allow files in the comments feedback
...
Also use new API to add files to gradebook.
2018-10-16 13:06:58 +08:00
Mark Nelson
faa438bad6
MDL-27520 mod_assign: added API for feedback plugins
2018-10-16 13:06:58 +08:00
Eloy Lafuente (stronk7)
bbfda3b9db
Merge branch 'MDL-62319-master' of git://github.com/damyon/moodle
2018-10-15 23:54:51 +02:00
Damyon Wiese
a0b009115e
MDL-62319 assignfeedback_editpdf: Disable touch scrolling
...
Assignment editpdf canvas provides it's own scroll tool and the native browser one breaks
the rest of the tools for the canvas. Turn it off.
2018-10-11 13:28:01 +08:00
Nathan Nguyen
923641f71c
MDL-62319 Assign: Grading interface is broken when using iOS 11.3 devices
2018-10-11 13:27:56 +08:00
Eloy Lafuente (stronk7)
89957b6c34
Merge branch 'MDL-63439-master' of git://github.com/damyon/moodle
2018-10-10 00:47:40 +02:00
Damyon Wiese
490e48a4df
MDL-63439 assign: Unicode charsets for pdf
...
Prefer to use freesans font for generated pdfs as it has the biggest charset support.
2018-10-09 09:28:06 +08:00
Adrian Greeve
812c409203
MDL-62491 mod_assign: Fill in the rewrite plugin urls properly.
2018-10-08 09:00:08 +08:00
Eloy Lafuente (stronk7)
682357004f
Merge branch 'MDL-60685-master' of git://github.com/damyon/moodle
2018-10-03 00:23:10 +02:00
Eloy Lafuente (stronk7)
51181541ab
Merge branch 'MDL-62279-master' of git://github.com/damyon/moodle
2018-09-25 23:25:10 +02:00
Eloy Lafuente (stronk7)
fc008d6769
MDL-57610 assignfeedback_editpdf: add missing UK to install.xml
2018-09-25 15:21:42 +02:00
Adam Olley
1afbb97b6b
MDL-57610 assignfeedback_editpdf: integration cleanup
...
* Add a note to upgrade.php to notify devs/admins of the new setting.
* Replace update_record with set_field.
* Add missing phpdoc.
2018-09-25 09:54:39 +09:30
Adam Olley
bc32547da9
MDL-57610 assignfeedback_editpdf: Add test coverage for conversion task
...
Without this, we have no coverage of the convert_submissions task. This test
validates it both works normally, and that it also skips queued items that have
exceeded the conversion attempt limit introduced in this improvement.
2018-09-18 14:14:24 +09:30
Adam Olley
b722a457ad
MDL-57610 assignfeedback_editpdf: remove queued jobs that keep failing
...
Without this, its possible to get a document in the editpdf conversion queue
that keeps failing - and in some cases completely crashing the PHP script
despite exception handling - which ends up blocking the processing of the queue
entirely.
This change allows for a configurable number of attempts the conversion
task will perform before removing the item from the queue.
2018-09-17 09:30:43 +09:30
David Monllao
ffc4cc9a25
Merge branch 'MDL-62944' of https://github.com/NeillM/moodle
2018-09-04 12:15:36 +02:00
David Monllao
adb8eb9c9c
Merge branch 'MDL-55993-master' of https://github.com/albertolarah/moodle
2018-09-04 10:51:28 +02:00
David Monllao
dfc6f782e1
Merge branch 'MDL-38301-master' of git://github.com/junpataleta/moodle
2018-09-03 12:44:50 +02:00
Alberto Lara Hernández
96a037f755
MDL-55993 mod_assign: web services don´t set a URL.
2018-09-03 12:18:41 +02:00
Neill Magill
bbf1fde412
MDL-62944 activities: Activities should not require capability
...
Activities should not require the user manipulating them to have
calendar capabilities for their events to be added to the Moodle
calendar
2018-08-31 10:15:37 +01:00
Neill Magill
196aa50489
MDL-62944 activities: Test adding activities with no calendar capability
2018-08-31 10:15:36 +01:00
Eloy Lafuente (stronk7)
cf76059eda
Merge branch 'MDL-62535-master' of git://github.com/abgreeve/moodle
2018-08-30 01:19:57 +02:00
Andrew Nicols
75ad50cba0
Merge branch 'MDL-62782-master' of git://github.com/damyon/moodle
2018-08-28 07:06:22 +08:00
Andrew Nicols
fdab90a7d4
Merge branch 'MDL-53024-master' of git://github.com/damyon/moodle
2018-08-27 15:45:57 +08:00