364 Commits

Author SHA1 Message Date
jamiesensei
bfcaf5e684 MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
2008-09-24 09:10:43 +00:00
jamiesensei
14133ad913 MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" 2008-09-23 10:39:12 +00:00
jamiesensei
e84cb61554 MDL-16532 "Can width of column for Essay questions be varied?" Concatenate the answers displayed in all responses in responses report for answers above a certain character count (now set to 150). Also added a link to all responses to display a review of the question response. Both the concatenation and links are only showed in the report on the Moodle site and effects are not exported. 2008-09-23 10:21:32 +00:00
jamiesensei
8b92c1e3f6 MDL-16529 "Only include closed attempts in manual grade counts" 2008-09-23 09:52:55 +00:00
tjhunt
739b07112e MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
2008-09-23 07:18:15 +00:00
jamiesensei
e1d2278b51 MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles" should not style response or add feedback image if the response is not yet graded. 2008-09-22 09:20:13 +00:00
jamiesensei
452351550b MDL-16567 "Quiz statistics report does not work when the quiz contains descriptions" slightly more elegant and efficient solution to issue. 2008-09-19 10:12:54 +00:00
tjhunt
a1f6db1775 Nasty hack fix for MDL-16567 - I am hoping Jamie will come up with a proper fix soon, but I am about to demo this. 2008-09-18 12:47:12 +00:00
tjhunt
766df8f72b MDL-16334 Convert mod/quiz/comment.php to use attemptlib.php - final part of the work on the quiz navigtion, I hope.
MDL-16559 Remove question/comment.html template, and instead just have a function in questionlib.php
MDL-16562 Regression from MDL-16263, notices when regrading.
Sorry, the three got tangled together (coupled through questionlib) while I was fixing bugs in preparation for a demo.
2008-09-18 07:39:10 +00:00
tjhunt
8033d8423f Minor bug fixes. 2008-09-18 04:33:38 +00:00
jamiesensei
74b40fadd5 MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles" better not make styles dependent on question type. Just use overall styles. 2008-09-16 10:30:06 +00:00
jamiesensei
2ea2c1f57a MDL-16528 "responses report : improve efficiency of sql" moved the querying for state data all into one big query rather than an individual query for each question in each attempt. 2008-09-16 09:50:24 +00:00
jamiesensei
199b946f04 MDL-16527 "responses report : use question_get_feedback_class and question_get_feedback_image from questionlib.php instead of custom styles" 2008-09-16 09:46:57 +00:00
jamiesensei
3d6de8770d MDL-16362 "Quiz - bar graph on results screen" removing var_dump that I forgot to clean up. 2008-09-15 14:08:11 +00:00
jamiesensei
2a1995a476 MDL-16362 "Quiz - bar graph on results screen" there was a bug in my code that would put the graph generation code into an infinite loop if the overall grade for the quiz is 0. Since the change in the type of the field for quiz->grade the old test for quiz->grade being zero doesn't work. Using $quiz->grade as a bool does not work ($quiz->grade is now a string 0.0000), since Moodle 2.0 need to use $quiz->grade == 0. 2008-09-15 13:38:31 +00:00
jamiesensei
3b51802063 MDL-16125 "Improvement to Detailled Responses Report : Format of csv export" Fixed missing format string problem when downloading. 2008-09-15 11:39:15 +00:00
jamiesensei
d3e99e85d4 MDL-16502 "highlight questions that appear not to be working very well according to statistics"
There is a function is_dubious_question on the statistics table passed all the stats for that question and other question data and that returns a bool.
2008-09-15 11:13:31 +00:00
jamiesensei
3db543284b MDL-16501 "moving key to colours on graph to the bottom of the graph gives more horizontal screen space for the graph itself" 2008-09-15 09:16:57 +00:00
jamiesensei
9176976151 MDL-16463 "Long group names can make drop down box too wide" added an if condition to test the length of the group name. If it is more than 20 characters then we use the string 'this group' instead of the group name. 2008-09-12 08:33:40 +00:00
jamiesensei
c308138f89 MDL-14202 "Replace Item Analysis Report with new improved 'Statistics' report." Removing Quiz Item Analysis report 2008-09-11 12:59:33 +00:00
jamiesensei
869309b8d8 MDL-14202 "Replace Item Analysis Report with new improved 'Statistics' report." finished statistics report. This patch includes some changes to lib/tablelib.php so that it is possible to export the content of a table as part of a multi table export - with mutliple tables / multiple worksheets. 2008-09-11 12:48:08 +00:00
jamiesensei
ca2f6fc795 MDL-16110 "Improvement to Overview Report - Columns in csv file do not line up" 2008-09-01 08:30:14 +00:00
jamiesensei
02cd0be02e MDL-16125 "Improvement to Detailed Responses Report - Format of csv export" removing commas from table content which throw the csv export. 2008-09-01 08:24:25 +00:00
tjhunt
337fa7a0ef MDL-16263 - followup - fix notices. 2008-08-29 11:30:16 +00:00
jamiesensei
a3668b25c0 MDL-16121 "Manual Grading Doesn't Work" grades where not getting saved. Fixed that now. 2008-08-25 07:44:20 +00:00
skodak
775f811a66 MDL-16002 rewritten upgrade locking and better upgrade progress tracking; MDL-16070 Do not use $a[0] syntax in lang packs + various other upgrade improvements and fixes 2008-08-16 12:16:01 +00:00
tjhunt
f9a2cf86a9 MDL-7308 - Check all the DB columns used to store grades, and make sure they all use a consistent type. 2008-08-15 11:15:08 +00:00
tjhunt
530d9866c4 Unbreak quiz report graphs. lib.php, which is now required, was not being included. 2008-08-15 10:48:29 +00:00
jamiesensei
570e5e029a MDL-16041 "Grade of new tests are zero!" no longer displaying graphs of grades for ungraded quizzes. 2008-08-15 10:24:04 +00:00
jamiesensei
f29e6691a7 MDL-15972 "Make ability to list regrades dependent on permission" fixed a problem showing some of the regrade interface to users who do not have permission to regrade.
MDL-15960 "Overview report does not work correctly with groups" Fixed a problem that group mode was not working as the logic selecting the attempts mode was erroneously showing the all attempts mode.
MDL-15958 "Error on selecting to hide marks for each question" problem with trying to sort on question grades when grades not displayed fixed.
MDL-15953 "Summary chart to show in 5% ranges please" allowed the graph to show up to or equal to 20 bands, instead of just up to 20.
MDL-14201 "Summary graph" showing two graphs now as it was felt that when there were few students in a group compared with all the students who took a quiz then it would be difficult to see the data for the group.
2008-08-15 09:59:55 +00:00
tjhunt
f88fb62c40 MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors. 2008-08-15 06:42:38 +00:00
jamiesensei
5153422cdd MDL-15268 "Content for Quiz Statistics report table" adding img link to display graph on main page of report. 2008-07-30 10:28:39 +00:00
jamiesensei
aa3133bcb9 MDL-15268 "Content for Quiz Statistics report table" display blank cell if statistic is not calculatable 2008-07-30 09:49:09 +00:00
jamiesensei
43ec99aa74 MDL-15268 "Content for Quiz Statistics report table" further work on quiz statistics report. 2008-07-30 09:02:44 +00:00
tjhunt
06d1324803 Fix calculation of median with an odd number of attempts. 2008-07-29 13:56:37 +00:00
tjhunt
c89f2f13d8 Fix comment. 2008-07-29 13:32:28 +00:00
tjhunt
fb7396a1ff Manual grading report - change query to work on Postgres. 2008-07-29 13:10:02 +00:00
tjhunt
bd03752be8 Fix notices. 2008-07-25 14:18:19 +00:00
tjhunt
92718f4c44 No manually graded questions found is not an error contidion, so return true, not false. 2008-07-25 14:11:22 +00:00
tjhunt
3f8e526ec1 Fix notices in 'Students' without attempts mode. 2008-07-25 14:05:40 +00:00
jamiesensei
162f96353b MDL-14208 Cache results of calculations, "recompute now" functionality -- forgot one field for questions stats. 2008-07-25 12:15:07 +00:00
jamiesensei
9859e26cc0 MDL-14208 "add cron routine to clean up cache records" 2008-07-24 17:45:01 +00:00
jamiesensei
d1789d5d64 MDL-14208 Cache results of calculations, "recompute now" functionality -- added message about when the stats were last calculated and how many attempts there have been since then and a recompute now button. 2008-07-24 17:42:06 +00:00
jamiesensei
daae98e118 MDL-14216 "change query to work on Postgres." - some adjustments to make it work on mysql again too. 2008-07-24 16:10:26 +00:00
tjhunt
1e98b864e5 MDL-14216 - change query to work on Postgres. 2008-07-24 15:34:15 +00:00
jamiesensei
71a2b878fa MDL-14208 'Improvement of Item Analysis Report : Cache results of calculations, "recompute now" functionality' - using new tables to cache stats results. 2008-07-24 13:25:07 +00:00
tjhunt
23277af8f1 MDL-14216 - change query to work on Postgres. 2008-07-24 12:58:05 +00:00
jamiesensei
a1db71cb25 MDL-15198 "non-standard sql in reportlib.php" similar sql used here, fixing. 2008-07-22 13:06:54 +00:00
jamiesensei
182dbc6f4d MDL-15751 "Quiz statistics report : only list random questions once when there are several consecutive random questions picking from the same category with the same options to recurse into sub directories" sorting of questions by id, so they appear in some kind of order. 2008-07-22 12:33:05 +00:00
jamiesensei
d49e5bd87c MDL-15751 "Quiz statistics report : only list random questions once when there are several consecutive random questions picking from the same category with the same options to recurse into sub directories" oops. Regression meant a row was added for every attempt at a random question 2008-07-22 12:27:11 +00:00