76 Commits

Author SHA1 Message Date
Steve Bader
9569b01cc9 MDL-49852 mod_assign: Fix group assignment completion tracking
Fixes completion tracking for group assignments where either only
one student is required to click Submit when submitting the
assignment for grading, all students are required to submit,
or no students are required to click submit (meaning that simply
uploading submits for grading).
2016-05-26 16:03:03 +08:00
Damyon Wiese
bb690849c9 MDL-52954 assign: Rebuild the assignment single grade page. 2016-03-30 13:47:21 +08:00
Damyon Wiese
d629c601c5 MDL-48634 grades: Add an option to rescale when changing the maxgrade 2016-02-05 18:20:17 +08:00
Jun Pataleta
418a0d0465 MDL-43594 mod_assign: Fix calendar update on course reset
This patch fixes the updating of calendar events when the course
is reset and its start date is changed.
2015-09-29 13:46:27 +08:00
Tim Lock
d89dc6daa5 MDL-42670 mod_assign: Fix recent activity block when blind marking is on 2015-09-07 22:41:41 +02:00
Damyon Wiese
5ce0f749a6 MDL-46078 Assign: Completion is not using assignment API.
Should not be directly querying the DB to get the submission, use the API!
2015-07-28 10:19:59 +08:00
David Monllao
608132d7e4 MDL-47172 print_overview: Fixing indentation 2015-02-16 09:38:05 +08:00
Ankit Agarwal
a7366bc858 MDL-47172 print_overview: Show assignments only when needed
The intended behaviour is not to display this notification when:-
1) The assignment is closed.
2) User is a student and has a valid submission in place.
3) User is a teacher and there is nothing to grade.

Beisdes the above changes the patch also includes minor other fixes such as:-
1) Fixed phpdocs
2) Fixed inconsistent return value.
3) Fixed unit tests that had arguments in wrong order.
2015-02-13 11:12:12 +05:30
Mark Nelson
bd3ee80716 MDL-46498 mod_assign: display correct grading status 2014-12-23 23:46:22 -08:00
Zachary Durber
8c1050f87d MDL-47694 mod_assign: Grades require a grade to show as graded
Special thanks to Howard Miller.
2014-12-09 15:55:29 +08:00
Damyon Wiese
9e035dae1b MDL-47655 assign: Treat 'new' status as never submitted.
This fixes the recent activity callbacks to ignore submissions with a 'new' status.

The unit tests for recent activity were modified, because they were relying on the old behaviour of 'submitted' being the default status.

AMOS BEGIN
     CPY [submissionstatus_,mod_assign],[submissionstatus_new,mod_assign]
AMOS END
2014-10-16 13:56:07 +08:00
Damyon Wiese
9e3eee671f MDL-46171 Assign: Always require a submission record if there is a grade
Also - update unit tests to match the new expectations.
2014-09-24 15:07:36 +08:00
Damyon Wiese
ad030ab4a5 MDL-46171 assign: And here is the benefit of the new column - simplify the SQL 2014-09-24 15:07:36 +08:00
Eloy Lafuente (stronk7)
9bdb64681f Merge branch 'MDL-39929' of https://github.com/bostelm/moodle 2014-09-03 00:13:53 +02:00
sam marshall
9c85baa8c5 MDL-44725 Availability: Replace groupmembersonly - FEATURE_xx (6)
Remove old FEATURE_GROUPMEMBERSONLY as no longer required.
2014-09-02 13:03:17 +01:00
Henning Bostelmann
7faf78cbae MDL-39929 Assignment: provide file upload area for assignment description 2014-09-02 11:02:16 +01:00
Jon Marthaler
abd0f0aec6 MDL-46539 assign calendar: Fix lastcron value for assign cron 2014-08-27 11:17:28 -05:00
Damyon Wiese
92d78aace8 MDL-46044 Assign: Add conditions to the inner query for performance 2014-06-27 14:58:58 +08:00
Damyon Wiese
6447021bc0 MDL-46044 Assign: Modify myhome query to only use the maxattempt from the submission
Using mismatches from the submissions/grades tables does not make much sense, we
should always only consider only the maxattempt from the submissions table.
2014-06-27 14:22:48 +08:00
Damyon Wiese
fc1dac2e1e MDL-46044 Assign: Fix print_overview function when there are multiple attempts 2014-06-27 14:15:31 +08:00
Damyon Wiese
a084ac0db4 MDL-46045 Fix php tags (lowercase) everywhere 2014-06-19 11:05:16 +08:00
Frederic Massart
2507b7e060 MDL-45537 mod_assign: Requiring locallib for class assign 2014-05-19 12:40:17 +08:00
Rajesh Taneja
b2b4ec308e MDL-41283 report_participation: Added phpdoc about function not used
In new logging api, xxx_get_view_actions() and xxx_get_post_actions()
will not be used to identify the paticipation of user. Event's crud
and edulevel status will define user's participation.
2014-04-15 13:31:03 +08:00
Marina Glancy
e19c086c36 MDL-40843 recent_activity: corrections to grouping and user fields 2014-04-04 16:52:01 +08:00
Marina Glancy
d6f418cb77 MDL-40872 Restore functionality of showrecentsubmissions setting 2014-04-04 15:11:13 +08:00
Dan Poltawski
93759b73a5 Merge branch 'MDL-42585-master' of git://github.com/damyon/moodle
Conflicts:
	mod/assign/version.php
2014-01-07 10:55:20 +08:00
Rajesh Taneja
456d7bc7f3 MDL-18770 mod_assign: Set gradetype to GRADE_TYPE_NONE if feedback not enabled 2014-01-03 16:30:37 +08:00
Damyon Wiese
4a47008ca6 MDL-42585 Assign: Add capability to only view grades
AMOS BEGIN
    CPY [viewgrades,grades],[assign:viewgrades,mod_assign]
AMOS END
2013-12-20 11:01:44 +08:00
Ankit Agarwal
5c7ec9f6f8 MDL-40962 assign: Fix alternate name field warnings in assign 2013-10-01 15:32:52 +08:00
Damyon Wiese
1561a37cab MDL-37148 assign: Fix all phpdocs warnings from moodlecheck (except tests) 2013-09-13 13:30:02 +08:00
Damyon Wiese
539af60201 MDL-37148 assign: codechecker cleanups 2013-09-13 13:30:02 +08:00
Damyon Wiese
74df2951d1 Revert "MDL-39876 Change get_record('course') calls to get_course"
This reverts commit ab7632b74c331540c90229bf03d13aa2e6bdd9be.
2013-08-21 13:42:30 +08:00
sam marshall
ab7632b74c MDL-39876 Change get_record('course') calls to get_course 2013-08-15 11:31:20 +01:00
Petr Škoda
bd3b3bba9f MDL-40220 use new core_component::get_plugin_list() 2013-07-16 22:36:11 +02:00
Sam Hemelryk
b618f2d9f7 Revert "MDL-37490 mod_assign: Add setting to show the due date on the course page."
This reverts commit ef8a6dfb33c572beb0982818e9380476d6e636e2.
2013-06-11 17:10:36 +12:00
Gareth J Barnard
ef8a6dfb33 MDL-37490 mod_assign: Add setting to show the due date on the course page. 2013-06-08 10:44:28 +01:00
Damyon Wiese
f6aa750eee MDL-36223 Assign: User outline report grade display
Use str_long_grade for user outline report because it handles scales and
no grade.

Thanks to Jean-Daniel Descoteaux for suggesting this fix.
2013-05-02 15:42:58 +08:00
Damyon Wiese
df211804f1 MDL-36804 mod_assign - allow students to resubmit work and display a submission + grading history
This is based on work by Davo Smith with input from Fernando Oliveira (Thanks guys!).
2013-04-02 13:37:51 +08:00
Jerome Mouneyrac
dd5d933f30 MDL-37079 create/update_module() 2013-03-18 14:41:35 +08:00
Damyon Wiese
b8d3aa8fc8 MDL-35127 Assignment - declare the variables in the outer scope (for readability) 2013-02-27 09:27:55 +08:00
Eric Merrill
d77731d612 MDL-35127 mod_assign More efficient use of expensive database queries
Moving two relatively expensive DB queries so they are only executed when needed
instead of on every function call. They will still only execute once, and not
repeatedly during execution of the loop.
2013-02-27 09:01:25 +08:00
Damyon Wiese
d43b31094e MDL-37533 Assign: Use the constant for the submitted status in the query (and parameterize the query) 2013-01-24 10:52:20 +08:00
Stephen Bourget
b7f461419b MDL-37533 Assign: assign_print_overview does not correctly display assignments that need grading 2013-01-24 10:39:09 +08:00
Damyon Wiese
c1432fad2c MDL-37619 Assign: Fix failed unit tests for mod/assign/lib.php
The failure was caused by a regression in MDL-37527.
2013-01-22 13:34:01 +08:00
Dan Poltawski
66bfd52a62 Merge branch 'MDL-37527-master' of github.com:damyon/moodle 2013-01-21 10:03:34 +08:00
Damyon Wiese
f93fdcef86 MDL-37546 Assignment fix assign_get_recent_mod_activity code cleanup regression. 2013-01-16 13:48:15 +08:00
Damyon Wiese
425a634b58 MDL-37527 Assignment - Change query for print_overview so it uses an index (postgres)
Reported by Mark Neilsen.
2013-01-16 13:20:27 +08:00
Damyon Wiese
e5403f8c44 MDL-36904 Assignment: Fix all errors and warnings from codechecker 2013-01-04 15:46:15 +08:00
Raymond Wijaya
d38dc52f39 MDL-34794: Add reset course feature in mod_assign (new assignment (2.3+)) 2012-09-28 14:33:33 +08:00
Raymond Wijaya
79e7dfcc76 MDL-35389: Fix an error when changing locked state of a assignment is changed 2012-09-21 11:10:34 +08:00