2296 Commits

Author SHA1 Message Date
Rajesh Taneja
e01012e96d MDL-46891 behat: Driver specific fixes.
1. Browserkit doesn't handle [] in name
2. Grades are not visible in viewport and might fail
   with few drivers, increasing size of window to ensure
   grades are visible and can be modified.
3. Click edit first to see grade link
4. Expand fields before setting value
5. Updated xpath, as crawler update it.
6. Hover fails to show icon
2016-03-11 10:51:16 +08:00
Rajesh Taneja
b73e5047af MDL-46891 core_grade: Steps are not valid as element is disabled 2016-03-11 10:51:16 +08:00
Rajesh Taneja
42ad096fdb MDL-46891 Behat: Added support for behat 3 2016-03-11 10:51:15 +08:00
Andrew Nicols
f4b6081ebf Merge branch 'MDL-52522-master' of git://github.com/cameron1729/moodle 2016-03-09 08:35:14 +08:00
Cameron Ball
fa8e27b32b MDL-52522 grades: Add rescale grades option for grade categories.
When a grade category is overridden, it starts to behave like a regular grade item.
Therefore we need similar behaviour to what was implemented in MDL-48634.
2016-03-08 16:26:44 +08:00
David Monllao
d94df7afa8 MDL-41648 gradingforms: Remove unnecessary attr 2016-03-08 15:32:19 +08:00
David Monllao
f084c4b231 Merge branch 'wip-MDL-41648' of https://github.com/dg711/moodle 2016-03-08 15:32:17 +08:00
David Monllao
ae66ed23b6 MDL-52378 singleview: Using is_disabled instead of is_locked 2016-03-07 23:04:52 +01:00
Travis Noll
43cd0e3c9b MDL-52378 Singleview: Exclude Grade Attribute Permissions
Singleview users must have Manage Grade permission to modify the
Exclude grade attribute.
2016-03-07 23:04:42 +01:00
dg711
df8674d26e MDL-41648 grade: Remove 'error' parameter in grading notification divs 2016-03-06 09:16:57 +05:30
Cameron Ball
9566b021db MDL-53214 grades: Fix labels on feedback fields 2016-03-02 14:21:39 +08:00
Dan Poltawski
bc48a198ab Merge branch 'MDL-52513' of https://github.com/rushi963/moodle 2016-03-02 13:23:56 +08:00
Andrew Nicols
2b38214a16 Merge branch 'MDL-53214-master' of git://github.com/cameron1729/moodle 2016-03-01 09:40:44 +08:00
KeenRivals
83ea83ec19 MDL-50175 graphics: Optimized SVGs with SVGO. 2016-02-25 11:56:42 +00:00
KeenRivals
26c19b02d5 MDL-50175 graphics: Optimized PNG images with optipng
Used options: -o7 -strip all and advdef -z4 -i50.

(With ./lib excluded)
2016-02-25 11:56:37 +00:00
Rajesh Taneja
2b9361cdda MDL-49324 behat: Use singleselect step to select user 2016-02-25 09:49:24 +08:00
Eloy Lafuente (stronk7)
6ab07f97bf Merge branch 'MDL-49324-master' of git://github.com/andrewnicols/moodle 2016-02-24 07:55:51 +01:00
Andrew Nicols
0c31d92452 MDL-49324 grade: Ensure report appears in breadcrumbs 2016-02-24 14:39:11 +08:00
Andrew Nicols
beb964520a MDL-49324 gradereport_singleview: Fix unit tests 2016-02-24 14:39:10 +08:00
Andrew Nicols
bb4d057662 MDL-49324 grades: Remove old variable usage 2016-02-24 14:39:10 +08:00
Andrew Nicols
47f084c6a1 MDL-49324 grades: Remove unnecessary @javascript tag from tests 2016-02-24 14:39:09 +08:00
Andrew Nicols
87d71ecf69 MDL-49324 grade: Ensure weights adjusted message is displayed
The grade settings page displays a message to inform users that weights
have been adjusted if they did not previously add up to the required 100%.

With the change to sometimes displaying a progress bar, whether the message
is displayed must be calculated immediately after the regrade took place,
and before the page redirects.

I have added a callback with arguments to the regrade_if_required function
which is called immediately after regrade has taken place (regardless of
whether the progress bar is required).

This callback modifies the PAGE URL such that the redirect message will be
displayed after the redirect. This does not use the session as the message
should only be displayed immediately after a change. If the user does not
click on the continue button after the progress bar has been displayed, and
comes back to the page later, this may be confusing.
2016-02-24 14:39:09 +08:00
Andrew Nicols
417c7f3b86 MDL-49324 grades: Remove category aggregation change backend
The UI for this was removed several releases ago and this code is no longer
called.
2016-02-24 14:39:09 +08:00
Andrew Nicols
a2f6399806 MDL-49324 gradereport_singleview: Correct url params supplied to PAGE 2016-02-24 14:39:08 +08:00
Andrew Nicols
0a802c9c4e MDL-49324 grades: Create helper function for regrading on report view 2016-02-24 14:39:08 +08:00
Cameron Ball
ccdda8550b MDL-53214 grades: Ensure grader report correctly labels fields.
The editable fields for the grader report should have unique labels.
Previously category grade items were not being labelled with the
category name.
2016-02-24 10:30:43 +08:00
Rushikesh
e01f3f636c MDL-52513 Grading : Change in display message after publishing 2016-02-23 22:02:56 +05:30
Dan Poltawski
5500e15d67 Merge branch 'MDL-33663' of https://github.com/rushi963/moodle 2016-02-23 11:44:24 +00:00
Dan Poltawski
2c720c9772 Merge branch 'MDL-50312_master' of https://github.com/jinhofer/moodle 2016-02-23 08:07:13 +00:00
Damyon Wiese
30be6c846a MDL-49324 Grades: Use a progress bar when recalculating gradebook grades 2016-02-23 08:35:10 +08:00
Rajesh Taneja
7b287e09e2 MDL-50484 core_grade: courseheader id should be unique
grader report show category with courseheader id
which gets replicated for all categories on page.
This will now be courseheader_categoryname.
2016-02-19 14:00:04 +08:00
Rajesh Taneja
1ebda3eb8c MDL-50484 lib_formslib: Persistant input should have different id
Persistant input is appended for frozen elements
and should have different id then the actual element
2016-02-19 14:00:04 +08:00
David Monllao
a6f4866e52 Merge branch 'MDL-48015-master' of git://github.com/junpataleta/moodle 2016-02-17 09:49:04 +08:00
David Monllao
44ad0f2c8d Merge branch 'MDL-51580' of git://github.com/stronk7/moodle 2016-02-16 05:03:28 +08:00
Eloy Lafuente (stronk7)
e8c82aac82 MDL-51580 upgrade: clean < 2.7.0 upgrade steps
This just deletes all the upgrade steps previous to 2.7.0. Some
small adjustments, like adding missing MOODLE_INTERNAL or tweaking
globals can also be applied when needed.

Next commit will get rid of/deprecate all the upgradelib functions
not used anymore in codebase.
2016-02-15 18:38:09 +01:00
Rushikesh
ef8dc8570b MDL-33663 Grading methods: Appropriate error message for negative grades 2016-02-12 16:58:27 +05:30
Mark Nelson
a3dd8be7dc MDL-48634 core: changes to automated tests to pass with changes 2016-02-09 17:46:43 +08:00
Mark Nelson
5af1321b41 MDL-48634 core_grades: added behat test for grade items form validation 2016-02-09 17:46:42 +08:00
Mark Nelson
664d8be7ea MDL-48634 core: prevent change of grade values when necessary
Three additional checks have been added.

Once grades have been recorded for the activity/grade item -

1) Do not allow the grade type to be changed.
2) Do not allow the scale to be changed.
3) If we are using ratings do not allow the 'Maximum points'
value to be changed.

Also reordered form elements, removed form elements that
were not necessary, added and changed existing language
strings to improve the overall UI.
2016-02-09 17:46:42 +08:00
Jun Pataleta
825a3fa9d1 MDL-48015 grade: Fix the display of grade categories 2016-02-09 13:32:28 +08:00
Damyon Wiese
e7c71c189b MDL-48634 grades: Make the rescaling option required if maxgrade changes 2016-02-05 18:20:17 +08:00
Damyon Wiese
d629c601c5 MDL-48634 grades: Add an option to rescale when changing the maxgrade 2016-02-05 18:20:17 +08:00
jinhofer
8cc02383bf MDL-50312 grade/report/grader: Fixed remaining issue
MDL-49764 fixed the appearance of user cells. However, the window
resize event was still incorrect. This is a fix for the window
resize event for ALL IE versions.
2016-01-29 12:16:06 -06:00
Dan Poltawski
574b76ace1 Merge branch 'MDL-52218_master_alt' of git://github.com/markn86/moodle 2016-01-18 14:03:54 +00:00
Dan Poltawski
26e45019c8 Merge branch 'MDL-36404-master' of git://github.com/junpataleta/moodle 2016-01-18 10:24:04 +00:00
Andrew Nicols
2e6462f327 Merge branch 'MDL-52573-master' of git://github.com/danpoltawski/moodle 2016-01-18 14:32:41 +08:00
Andrew Nicols
324a43c51e MDL-52309 gradereport_history: Adjust comment 2016-01-18 09:37:29 +08:00
Andrew Nicols
8d9b6ec254 Merge branch 'MDL-52309' of https://github.com/smbader/moodle 2016-01-18 09:33:36 +08:00
Jun Pataleta
e9088e28ac MDL-36404 gradingform_rubric: Accessibility fixes rubric grading 2016-01-18 09:31:00 +08:00
Dan Poltawski
2811831ae6 MDL-52573 report_grader: only check cap of installed plugins
Previously we were linking to gradebook plugins regardless of whether
they were installed. This should be fixed properly in MDL-52678.
2016-01-14 10:20:43 +00:00