Commit Graph

125 Commits

Author SHA1 Message Date
skodak
cb5105a872 MDL-9960 more support for NULLs in db values + unittests 2007-07-29 15:20:51 +00:00
skodak
23207a1a6a MDL-10563 item excluding implemented;
improved/fixed grade edit page;
some other improvements and cleanup
2007-07-21 14:24:39 +00:00
skodak
9acbd7269c MDL-10364 improved internal formula format 2007-07-21 08:43:51 +00:00
skodak
2a8c101f69 MDL-10065 move lib/simpletest/grade/simpletest elsewhere
+ fixed categroy locking unittest and minor problem with return value
2007-07-17 14:25:20 +00:00
skodak
c86caae78a MDL-9137 new grade_grades field overridden; item edit form fixes; other minor fixes and improvements 2007-07-10 18:08:24 +00:00
skodak
98353ff194 MDL-9137 new grade_grades field overridden 2007-07-10 08:55:06 +00:00
skodak
6b6f345266 MDL-6855 fixing id in new grade tables to be unsigned in unut tests 2007-07-10 07:57:58 +00:00
skodak
004081182d MDL-10226 fixed item unit tests 2007-07-08 15:14:26 +00:00
skodak
5656785b6f MDL-10226 fixed categroy unit tests 2007-07-08 15:07:16 +00:00
skodak
aaff71daf4 MDL-10365 Improved handling of history when inserting/updating/deleting in new grade reports;first part 2007-07-06 12:49:28 +00:00
skodak
c3146da7ac complete unit tests for grade_item + minor cleanup in insert and update 2007-07-04 17:52:43 +00:00
skodak
6639ead31e complete unit tests for grade_category, minor API cleanup, fixed forced regrading in grade_category 2007-07-03 10:06:08 +00:00
skodak
f13002d53e MDL-9629 fixed regressions in grade reports caused by my previous commits, added unfinished forms for category and item edit 2007-06-30 21:12:47 +00:00
jamiesensei
7856a8c384 removing file that mistakenly was committed to HEAD 2007-06-30 04:22:51 +00:00
jamiesensei
c28245d7e5 test for questionlib on MOODLE_19_QUESTIONS branch 2007-06-30 03:50:52 +00:00
skodak
b3ac6c3ef0 MDL-10224 total course grade implemented + lots of other changes and improvements; there are still some regressions and bugs - going to fix them ASAP; some unit tests still missing too 2007-06-28 13:20:30 +00:00
skodak
22e23c78a0 MDL-10251 finished hiding implementation for grades, items and categories + unit tests 2007-06-25 15:29:31 +00:00
skodak
93def7683e removing itemnumber generation for now 2007-06-25 08:01:04 +00:00
skodak
f92dcad81a MDL-10233 improved static factory methods of grade obejcts fetch() and fetch_all(); implemented default values of grade objects, fixed null values for some properties that are not required - unit tests included, tested with PHP4 and PHP5 2007-06-24 22:26:33 +00:00
skodak
772ddfbfce trailing whitespace cleanup in new grade libraries 2007-06-23 16:51:09 +00:00
skodak
61c33818d5 MDL-10231 merge grade_calculations and grade_items table + calculation improvements
MDL-10233 fixed grade_*::fetch() - does not modify $this anymore, we can now use it from normal methods to fetch other objects of the same class.
2007-06-23 16:33:17 +00:00
skodak
2e53372c37 MDL-10226 regrading of final grades improved, calculation cleanup before MDL-10231 2007-06-22 18:33:32 +00:00
skodak
2cc4b0f90d MDL-10223 Implement locking of grades and grade items - cron support still not implemented;
this patch also contains improvements in handling of needsupdate, though it is not yet fully working for calculated grades
2007-06-22 08:57:39 +00:00
skodak
ac9b080524 MDL-10202 merge raw and final grade tables 2007-06-20 23:06:29 +00:00
skodak
df3cb76fc4 MDL-9137 calculated grades should work now, some other minor cleanup 2007-06-18 22:52:55 +00:00
skodak
b8ff92b66b MDL-9137 various grading improvements
1/ initial support for migration of old grade_items and categories (not tested)
2/ rewritten grade update and calculation logic
3/ initial support for calculation formulas
4/ minor API refactoring and cleanup
5/ various small bugfixes
6/ fixed use of grademax with scales
7/ fixed some unit tests

TODO:
* implement proper locking of grades - needs discussion
* force recalculation of all formulas after adding/removing/changing of grade items
* better delete flag support
* support for NULLs n backup - Eloy already proposed a solution
* support for NULLs in set_field()
* speedup
* more unit tests nd functional tests
2007-06-18 13:43:40 +00:00
skodak
f70152b7bb MDL-10104 grade_create_item() in gradelib.php was obsoleted by grade_update() function which does the creation and update of grade_items 2007-06-12 20:19:38 +00:00
skodak
9f9afbdbab MDL-10078 unit tests for grade category failing on set_as_parent() 2007-06-10 21:17:42 +00:00
skodak
34e67f76a8 MDL-10076 finalize grade_is_locked() and implement grade item locking in assignment 2007-06-10 20:34:07 +00:00
skodak
4c24cae1a1 MDL-10069 unit test for grade_item itemnumber generation broken 2007-06-09 17:24:44 +00:00
skodak
2904365752 MDL-10067 skip testing of bad inserts for mysql family - these are known to not work anyway 2007-06-09 17:10:32 +00:00
skodak
19be539627 MDL-10066 move testmodforumlib.php into mod/forum/simpletest/ 2007-06-09 16:55:31 +00:00
skodak
cdbbd26f80 MDL-10064 global $CFG in unit test files is non standard, it is recommended to use MOODLE_INTERNAL test in all library files 2007-06-09 16:32:36 +00:00
skodak
52f81103d3 MDL-10063 simpletestlib.php included from majority of unit tests - let's include it once from the test runner itself 2007-06-09 16:17:33 +00:00
skodak
02e6a9731f MDL-9866 reverting previous incorrect fix for include() in simpletest library; patching grade unit tests instead 2007-06-09 15:03:05 +00:00
skodak
2bb0dbf71d MDL-10062 - unit test of raw grade load_text() improved 2007-06-09 14:29:07 +00:00
skodak
4cf1b9be9d MDL-10062 - changes in raw grade handling of feedback and information
improved grade_update() function
2007-06-09 14:16:20 +00:00
nicolasconnault
1c307f2186 grade_item idnumber now self generated if needed.
deleted flag implemented in grade_item::update method
added GRADE_TYPE_NONE to gradelib and updated grade_item object
Implemented multiple items (generation of itemnumber when not explicitly given)
2007-06-07 12:45:24 +00:00
skodak
13127313d3 fixed unit grade tests - missing grade types 2007-06-06 22:15:40 +00:00
nicolasconnault
210611f6ee MDL-9629 Changed grade_item.gradetype default to 1, added GRADE_TYPE_NONE constant = 0, incrementing existing constants by 1. Set up auto-generation of idnumber for grade_item if itemmodule and iteminstance are set, only a temporary stub if they are not set (must be replaced by correct generation code). New category form now has server-side validation (not using formslib) 2007-06-05 08:50:24 +00:00
nicolasconnault
bbac4ae7c5 MDL-9972 Removed the __destruct() method, which was not needed. Also fixed a few bugs that caused notices in PHP5. 2007-06-05 01:19:09 +00:00
nicolasconnault
c3096060de MDL-9506 Added ksort() of each level of categories and items for the gradebook. Unsorted arrays caused erratic behaviour when moving elements of the tree around. 2007-05-30 05:47:26 +00:00
nicolasconnault
a3d5594248 MDL-9506 Refactored grade_tree::get_tree by doing the following:
- Extracted the $fillers array into a class variable
- Extracted the addition of elements to grade_tree::fillers into a new add_fillers($array) method
- Extracted the inclusion of fillers into the tree_array to a new include_fillers($tree, $object=NULL) method
- Removed the building of the tree_filled, which was already performed by build_tree_filled()
- Removed the generation of next_sortorder and previous_sortorder attributes, which was already performed by renumber()
Result is a much leaner and scalable set of methods, and a tighter definition of responsibilities for the varying classes. I think I have also noticed a significant inprovement in speed.
2007-05-30 03:09:38 +00:00
nicolasconnault
646323549e MDL-9506 Resolved recursion issues in grade_tree:renumber and grade_tree::get_neighbour_element. Unit tests all pass now. 2007-05-29 04:07:04 +00:00
nicolasconnault
de420c11c5 MDL-9317 Applying Petr's second patch 2007-05-29 00:56:44 +00:00
nicolasconnault
c91ed4be0d MDL-9506 Category and Item now set their own courseid if not set explicitly, and if they have enough information from
other sources. category::set_as_parent has a new constraint: cannot set over children from different courses.
Applied recursion to grade_tree::renumber(), but still some fine-tuning to do, since only grade_items are getting updated in DB.
2007-05-28 08:00:19 +00:00
nicolasconnault
d990776605 MDL-9137 Applied parts of Petr's patch on the gradebook objects. Unit tests unaffected. 2007-05-28 02:05:21 +00:00
nicolasconnault
526e1a8a25 MDL-9506 Corrected a number of small errors in unit tests and classes. 2007-05-28 01:26:58 +00:00
skodak
7458bee224 MDL-9643 some more polishing 2007-05-26 12:59:13 +00:00
skodak
a9cca58ea2 MDL-9643 minor maths unit test cleanup 2007-05-25 07:07:05 +00:00