Commit Graph

133 Commits

Author SHA1 Message Date
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
4c99e342d2 Merging fixes for MDL-12383 and MDL-12605 from MOODLE_19_STABLE 2007-12-29 22:48:48 +00:00
124b1091fa Moved some printing out of the center column (keeps blocks and center column content aligned) and cleaned some white space 2007-07-24 07:13:14 +00:00
acf85537ee Implemented MDL-10558 - Also took this as an opportunity to create two new methods to reduce code redundancy in the lesson save routines. 2007-07-24 06:33:53 +00:00
92bcca38cd MDL-9550 Implement calls of grade_update() function in Lesson 2007-06-11 11:25:24 +00:00
362f2ce973 Merging in fixes for MDL-8414 and MDL-9250 from MOODLE_18_STABLE 2007-04-08 21:02:16 +00:00
888f0c5460 Adding blocks to lesson
* added pagelib.php with lesson_page class definition
 * Lesson view now uses standard page layout classes
Other fixes:
 * minor fix to mod settings form
 * fixed function names (some were missing lesson_ prefix)
2007-03-24 23:07:59 +00:00
76d4ec0095 replacing fieldsets in small forms to divs 2007-03-01 05:29:50 +00:00
e15cc97f0f Merged in several display and bug fixes from MOODLE_18_STABLE 2007-02-23 20:20:50 +00:00
107470cb3a Merged in fixes for MDL-8375 from MOODLE_17_STABLE 2007-02-02 02:27:03 +00:00
ddaaceb4bb "Merged" in the fixed for MDL-8137 2007-01-29 06:43:22 +00:00
4085962ae9 xhtml fixes for MDL-7861. 2007-01-11 08:51:46 +00:00
d2ce367fb9 MDL-8062 Remove name attribute from <form> and related javascript code cleanup (tested with FF, IE, Konq and Opera) 2007-01-06 19:22:58 +00:00
b7dc225654 MDL-8062 1.3 Remove name attribute from <form> and fix focus everywhere - more changes ahead 2007-01-04 21:32:36 +00:00
e8e76f5a16 MDL-7861, fixing various xhtml strict issues and formatting 2007-01-03 07:29:51 +00:00
f521f98a22 modified some strings to add more meaning to buttons and links
left menu, clock and media file all display like blocks
some general code cleanup eg: went through several of the todo's in the code
2006-12-30 17:29:44 +00:00
78d112679d MLD-7861, making moodle xhtml strict. There are still errors in lesson mod 2006-12-18 06:13:04 +00:00
f2a3512bbd Merged in changes for MDL-7477 fix 2006-12-11 18:44:00 +00:00
15d2933a00 Merged in changes from MOODLE_17_STABLE for bug MDL-2006 2006-12-06 02:04:37 +00:00
b3b4bc44ce BugFix for MDL-6730: now blank lessons redirect to edit.php where the user is prompted by a menu of options. 2006-09-30 19:00:07 +00:00
6707a280a9 Moved endofbranch redirect up to avoid double printing of messages. 2006-09-23 19:32:25 +00:00
563106f0a8 Fixed branch table buttons to work with JavaScript turned off. This fix lead to some minor changes to the button output, but hopefully simplified things.
Also, removed .hidden-label class because it was no longer in use due to label fixes earlier.
2006-09-23 18:45:59 +00:00
94bcea7983 Removed mod/lesson:view 2006-09-22 02:58:39 +00:00
7adb975062 removed some unecessary comments 2006-09-19 02:48:29 +00:00
2817bc1aed Fixed a bug when detecting a user as eligible for posting their name for high scores 2006-09-19 02:41:10 +00:00
8271e5cec8 Fixed alignment problem with the buttons for password protected lessons 2006-09-19 02:29:42 +00:00
07642aef3e Minor changes 2006-09-10 19:09:25 +00:00
c94d37997d Removed action set to navigation because view.php no longer uses action 2006-09-10 18:41:38 +00:00
5631925a26 Started to separate out logic and presentation in view.php. Decided to wrap the question printing with HTML templates (viewstart.html and viewend.html)
Still needs a lot of work
2006-09-10 18:19:29 +00:00
fb992d716a Started to reorganize view.php 2006-09-10 02:38:09 +00:00
15f3d44ae7 Moved teacherview (lesson editing) out of view.php into edit.php
No code improvements in edit.php as of now.  Just works ;)
2006-09-10 02:09:14 +00:00
d1b025d013 Moved high scores logic out of view.php into highscores.php
Changed: now need to enter password on password protected lessons before being able to view high scores
Added logs to high scores and reworked logic
2006-09-10 01:20:00 +00:00
2163c22634 Forgot the lesson_ prefix 2006-09-09 22:23:50 +00:00
2cb24b647c Improved clock output and works when javascript is disabled 2006-09-09 22:20:51 +00:00
259990d2c6 Lesson buttons should now work with javascript disabled
Also improved the layout of action/continue.html
2006-09-09 21:39:11 +00:00
f15eb92c2c Removed essay grading code from view.php into essay.php. 2006-09-09 01:58:48 +00:00
6e1ff5c8fb MDL-6477: Added roles support.
Also added lesson_set_message() and lesson_print_message() to locallib.php
Also fixed problem in continue.html with not printing nextpageid
2006-09-08 23:17:18 +00:00
f9d5371b28 new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283 2006-08-08 22:09:55 +00:00
a8ff58dd2c merging changes from MOODLE_16_STABLE 2006-07-31 18:10:02 +00:00
5109569b69 Bug #5988 - Branch Tables in 1.6+ (Lesson Module); merged from MOODLE_16_STABLE 2006-07-10 22:39:58 +00:00
88427c077b [Merged][BugFix] Bug #5405 - made a new function that grades a lesson for a specific user's attempt. This is then used for grading lessons at the end of a lesson, for ongoing score feature and for updating the grade for essay question grading.
This new grading algorithm now enforces the lesson setting Max attempts when custom scoring is turned Off

Changed the reporting of minquestions setting to match the help file.  Now it is question based instead of attempt based.

Changed the reporting of ongoing score to use the new grade function.
2006-05-19 01:05:13 +00:00
a1d0b3eb81 [BugFix] Bug 5505 - function lesson_print_tree now checks for teacher editing priv before printing editing icons. Had to change arguments for this function as well which is the edit in view.php.
lesson.php how checks for teacher editing priv for all actions except for continue.  This is just in case the user hacks the URL.
2006-05-15 19:14:22 +00:00
432c2219f5 [BugFix] Bug #5396 - Found that the css float was causing the odd problem. Removed extra styles for the button layout and changed the divs around the buttons to spans
Also improved some logic in the button processing for branch tables
2006-05-02 17:05:29 +00:00
31eb5b5335 [Removed] the Delete user attempts option in the Lesson settings (changes to mod and lib)
[Added] new functionality to report.php to delete individual student attempts
[Fixed] High scores text in view.php when no high scores were recorded needed to be centered
2006-04-29 01:37:50 +00:00
31f6b26d4f [BugFix] Action was using global variables - now is fetched with optional_param 2006-04-06 23:03:08 +00:00
a7ae1ad3fd [BugFix] Multiple essays were not showing for grading: http://moodle.org/mod/forum/discuss.php?d=41999#195580 2006-03-28 00:30:24 +00:00
97d2756c65 [New Feature] Tabbed navigation added to lesson (similar to quiz)
[Added] Graceful fails added to view.php, essay grading, and reports
[Changed] got rid of a lot of references to $_POST/GET/REQUEST
[Fixed] In reports, it required teacheredit, should only be teacher
[Changed] High scores - teachers can actually see them!  Also, improved output by using print_table and print_heading
[Changed] Grade essays now uses fullname() to print user names
2006-03-25 21:38:57 +00:00
aeade7e227 cleaned up the left menu feature output by removing an unused form and several unnecessary string concatenations 2006-03-19 02:08:37 +00:00
289218844a [Changed] The print_simple_box_start/stop changes conflicted greatly with the display of branch table buttons (the box printed above the buttons some how :( ) To fix this, the tables were taken out and divs were used instead to display and arrange the buttons. This turns out to be a good thing because now the user has more control over the buttons via style sheet. Also did some extra clean up in the section of code printing the branch table.
[Added] new styles to styles.php to help display the buttons correctly.
2006-03-19 01:53:50 +00:00
0646963948 [Changed] function execute_teacherwarning to function lesson_display_teacher_warning because it was violating the function naming policy 2006-03-17 03:37:31 +00:00