The hideIfOutside function was being too restrictive with the
selector for checking if the event occurred within a menu child
(anchor tag) rather than the menu itself.
This patch changes the behavior of open action menus when using a mouse.
Before this patch when clicking on the page with an open action menu the focus would be
returned to the action menu's call button. This could cause the page to jump when a
mouse user did not close an action menu, scrolled and then tried to perform another
action on the page.
After this patch when clicking the focus will not be returned to the action menu's call button.
The behavior of the script will not be changed when using the keyboard.
In certain situations, the click event is propagated through to the
hideIfOutside and immediately closes the menu.
This happens when blocks are dock for example.
When the actionmenu is open, we should focus on it's first element, and
then naturally tab through it. Tabbing from the end should take us to the
first element after the menu button. This may not be the same as the first
element after the menu itself because of the nature of primary and
secondary action links. We also need to shift-tab back in the same manner.
The following changes have been made:
* course_section_cm_edit_actions now allows the caller more options for the
display of the action menu.
* The site menu block now disables the JS enhancement of the actionmenu so
that it displays as it did before. After more testing this seemed like the
only option that worked in the limited space of the block when it had
several modules.
* draganddrop of resources now triggers the action menu enhancement as well.
* Fixed display of title when the menu is not being enhanced by JS.
* Fixed the alignment of the completion icon in the bootstrapbase theme.
* Tweaked the CSS for the standard theme.
* Fixed IE8 display of icons.
* Fixed blocks using course renderer.
* Fixed behat tests.
* codecheckers fixes
* Removed alt from icons with descriptive text
* Tweaked actionmenu initialisation for performance