Commit Graph

18 Commits

Author SHA1 Message Date
090fbe8653 Merge branch 'MDL-63959-master' of git://github.com/tobiasreischmann/moodle 2019-05-10 11:41:11 +08:00
5b8d533067 MDL-63959 mod_feedback: Fixed nested dependency handling
For example the dependecy chain is the following: A->B->C. When a
question (A) depends on another dependent item (B) and B hasn't
displayed (because of C's response), the $value for the B's response
will be null. In this case the can_see_item() method returned
null. Because the can_see_item() returned null (not false), the
get_pages() method displayed the question A, because it checks for
explicit false: $this->can_see_item($item) !== false.
Now, false is also returned, if the dependent question is not visible.
2019-04-29 18:27:51 +02:00
094ce30779 MDL-63137 mod_feedback: mod_feedback_core_calendar_provide_event_action
Update mod_feedback_core_calendar_provide_event_action function to add a new userid parameter
Add userid to check capabilities, etc. to feedback completion and structure.
2019-04-26 17:18:12 +02:00
c3c97e2ee2 MDL-58523 mod_feedback: deleting response should reset completion 2017-06-13 14:35:08 +08:00
c201e4df40 Merge branch 'MDL-58772' of git://github.com/aolley/moodle 2017-05-03 16:50:29 +01:00
0fb1335924 MDL-58772 mod_feedback: Dont overwrite anonymous entries
The feedback module lets you alternate between responses being anonymised and
not anonymised. When the module is in anonymous mode, its possible for a single
user to make multiple responses.

However when the activity is switched to non-anon mode, if a user leaves a
follow up feedback, one of their previously anonymous responses is used, so
their new response stays anonymous and their old anon response is lost.

This change lets them leave a new non-anonymised feedback entry and retains all
previous anonymous responses instead of incorrectly reusing one of their anon
ones at random.
2017-05-02 12:49:33 +09:30
aa708b550e MDL-58665 mod_feedback: avoid extra db queries on dashboard 2017-05-01 12:57:19 +08:00
9c1889810a Merge branch 'wip-MDL-58502-master' of git://github.com/marinaglancy/moodle 2017-04-18 19:48:35 +01:00
fff1b3c464 Merge branch 'wip-MDL-55950-master' of git://github.com/marinaglancy/moodle 2017-04-10 16:05:07 +02:00
d6f77a435f MDL-56370 mod_feedback: allow to restore values from last attempt 2017-04-07 16:04:06 +08:00
d0b4c8a787 MDL-55950 mod_feedback: correct link to response in the email 2017-04-07 16:03:42 +08:00
f4dba1755c MDL-58502 mod_feedback: courseid is not course where feedback is 2017-04-07 16:02:39 +08:00
52f57996f4 MDL-58230 mod_feedback: New WS mod_feedback_get_finished_responses 2017-03-28 22:50:36 +02:00
ac9f0a6800 MDL-58229 mod_feedback: New WS get_unfinished_responses 2017-03-21 13:21:32 +01:00
96ae31bddc MDL-57818 mod_feedback: Refactor form processing 2017-03-21 12:24:41 +01:00
1a305933c7 MDL-57814 mod_feedback: Create exporter and required API changes 2017-03-15 15:28:03 +01:00
0f3c09979f MDL-57811 mod_feedback: New Web Service mod_feedback_view_feedback 2017-03-15 15:25:00 +01:00
97d71cbc3a MDL-53638 mod_feedback: convert to moodleforms 2016-04-27 13:28:43 +08:00