* Remove the subscribe link that's powered by YUI and
subscribe_ajax.php. This will be replaced by the subscribe action
menu item which utilises the subscription toggle template
and calls the proper WS function for toggling discussion subscription.
* Nuke YUI module for toggling subscription and subscribe_ajax.php
(about time!)
* Remove striped table row style
* Move subscribe icon to the action menu
* Update the action menu icon
* Remove the Last post column
* Removed the "Created" column and moved the date under "Started by"
* Added "Locked" and "Subscribed" indicators under discussion names.
* Added group name with the group picture. For groups without pictures,
a default placeholder picture is now shown.
* Removes unnecessary comment in search_users() WS.
* Replaces DB call by get_course() in search_users() WS.
* Fix discussionids handling on export.php.
* Coding style fix in test_search_users unit test.
* Add missing version bump.
* phpDOc fixes in post vault.
* Fix in the dataformat callback to handle different data types.
Under certain conditions, users marked as not confirmed yet may be
returned as forum notification recipients. Such users are considered as
inactive though and the delivery adhoc task cannot be run as these
users, throwing an exception.
The solution is to make sure that fetch_subscribed_users() does not
include unconfirmed users, similarly to what was done for suspended
users and nologin users.
The added unit test also checks for deleted users. But these should
never be returned as subscribed because we consider enrolled users only
and deleted users are filtered out implicitly.
We cannot deliver notifications to users who had subscribed to a forum
or discussion and were later inactivated either by suspending or setting
the auth method to nologin. The deliver adhoc task cannot be run as
these users, throwing the "Suspended account" exception.
The solution is to make sure that fetch_subscribed_users() does not
include those inactive users.
In a Single Simple Discussion forum, the first post can only be edited
by a user with the manageactivities capability, but all other posts
behave as normal.
Update the discussion_list vault to use the first post record from
the posts table join to get the author of the first post rather
than relying on it's own "userid" column which can be incorrect in
the case of split discussions.