706 Commits

Author SHA1 Message Date
skodak
465b310d2b prevent error when somebody changes scale or grading type - old value does not fit the new scale 2007-09-23 12:09:16 +00:00
skodak
3f2b0c8aba MDL-11363 merged tables grade_grades with grade_grades_text - it is now possible to define fields as required and optional
finally fixed formula validation in calculation edit form
2007-09-22 11:39:59 +00:00
nicolasconnault
41f22daa71 MDL-11353 Completed the implementation. This included a new method in grade_item: get_displaytype(), since that value could be set to default, and we must then look up to course, then site values. And the get_letter() method in grade_grade has been modified to first check the grade_letters table. All works like a dream! 2007-09-19 15:37:46 +00:00
nicolasconnault
ac5b0a4919 MDL-11339 Moved the gradedisplaytype element from user prefs to the display element of the grade_item settings 2007-09-19 14:28:26 +00:00
nicolasconnault
109bf12cda MDL-11340 Finished! 2007-09-19 14:12:34 +00:00
nicolasconnault
bc6969ddeb MDL-11340 Almost complete: Just need the "Add grade letter" button 2007-09-19 13:49:26 +00:00
nicolasconnault
dbdffd2c96 MDL-11340 Almost complete: Just need the "Add grade letter" button 2007-09-19 12:45:44 +00:00
skodak
85c9ebb926 MDL-1883 improved perf when editing scales - new function xxx_scale_used_anywhere() 2007-09-18 18:37:58 +00:00
moodler
567883c836 Cleaned up the display of the export pages 2007-09-18 03:36:47 +00:00
nicolasconnault
a5b8be622c MDL-11275 added (submissions). Also fixed :
Issue:
    Teachers can edit grader report preferences (including switches for quickgrading and
    quickfeedback), but do not have access to the "Turn editing on/off" button, so they
    can't do quickgrading.
Solutions:
    1.Decouple the quickgrading and quickfeedback modes from the editing mode,
        and turn them on/off through the preferences page. New capability: moodle/grade:edit
        * preferences: don't show quickgrading if no capability grade:edit
        * If quickgrading is switched off as a preference and user doesn't have manage cap, show edit icons around grades when in editing mode
2007-09-17 17:31:48 +00:00
toyomoyo
5bb8a8154e MDL-11084, "s in grade comments causes problems 2007-09-17 06:53:24 +00:00
toyomoyo
4581501ede MDL-11276, average calculations are inaccurate in percentage form due to double rounding 2007-09-17 04:25:51 +00:00
toyomoyo
cb68af8b89 removing extra number_format(), format_float() already calls number_format() 2007-09-17 02:15:51 +00:00
skodak
8e1ec6be58 MDL-11298 use textlib_get_instance() instead of new textlib() 2007-09-16 18:49:41 +00:00
skodak
8fafbc0ea3 MDL-11296 fixed incorrect detection of duplicate scales in course 2007-09-15 21:17:11 +00:00
skodak
31314c1270 fixed wrong $options - this->keepdrop_options used instead 2007-09-15 13:23:28 +00:00
nicolasconnault
e171963b3e MDL-11278 Implementation is complete, but grade_categories records in DB are not affected by global settings. This way, when global settings are switched back to "Do not Force", the original category settings will be in place. 2007-09-14 17:21:30 +00:00
toyomoyo
00374cc5f0 MDL-11274, hide grades in the grader report if the current grades has no viewhidden capability 2007-09-14 08:43:10 +00:00
nicolasconnault
098042baea Issue:
The number of submissions in the Group average and Course average calculations
    should be shown in brackets. (submissions) should be added after the Group average
    and Course average labels.
Solution:
    new grader report preference (Display number of grades in average cells).
2007-09-14 06:57:30 +00:00
moodler
2c7a9bd2af Fix the location of the link to the site-wide grading preferences 2007-09-14 06:51:57 +00:00
moodler
6308b91c13 Changing string for Overall average (was logged under MDL-11233 even though that's not strictly the correct bug) 2007-09-14 05:45:38 +00:00
nicolasconnault
aae94377b7 Issue:
Only students should appear in the tutor report, however
    sorting by Surname results in the tutor being included, which we don't want.
Solution:
    Confirmed as a bug and filed in tracker: http://tracker.moodle.org/browse/MDL-11233

Issue:
    Clicking on Hide Groups reveals the results for all students
    and all tutors and course staff appear. A tutor should only be able to see
    the results for their tutor group
Solution:
    Prevent tutors from ever seeing student grades from other groups: use existing capabilities
        moodle/site:accessallgroups = off AND moodle/grade:viewall = on

Issue:
    Preferences tab should not be available to users without gradereport/grader:manage capability
Solution:
    Hide the tab completely

Issue:
    Apply different style to average cells
Solution:
    Add css classes to the different average cells, and write a default style in css file.

Issue:
    The Average under group average might be better labelled Course average.
Solution:
    Rename to "Complete average"
2007-09-13 15:11:16 +00:00
nicolasconnault
c421ad4b2e MDL-11233 Corrected typo in grader report lib, and added a second sort parameter for lastname and firstname sorts, to add consistency to result sets. Non-students no longer appear in the list 2007-09-13 13:44:35 +00:00
nicolasconnault
83d387c290 MDL-11238 Removed reference to $grade_grade->feedback and replaced with grade_grade_text->feedback. Also instantiated the $grade_grade object properly instead of just get_record(), so that its set_hidden() method could be accessible. 2007-09-13 04:02:55 +00:00
nicolasconnault
b1b6ebf437 Replacing the capability gradereport/grader:manage with moodle/grade:manage 2007-09-12 15:02:06 +00:00
skodak
b2bc96d10b MDL-7380 added new groups API functions for use in course related pages (very similar to functions for activities) + fixed grade code to use these new functions 2007-09-06 10:19:24 +00:00
skodak
c2efb50142 MDL-11130 added aggregation inside all subcategories + added graded/all aggregation option 2007-09-05 19:15:21 +00:00
toyomoyo
6ef84f6f48 some fixes for user report 2007-09-05 04:39:07 +00:00
skodak
eb8599199e MDL-11069 reimplemented grade export flag handling 2007-09-04 21:56:30 +00:00
moodler
d3d0e9a43e Fix a string 2007-09-03 02:56:07 +00:00
skodak
9c8d38fa97 MDL-11092 events are not used for changed raw grades anymore + minor cleanup in handling of raw grades (now used only for modules or other external plugins that produce grades) 2007-08-31 22:42:05 +00:00
skodak
caffc55a84 MDL-11082 big refactoring in grade export - export tracking and grade formatting still not finished 2007-08-31 18:42:50 +00:00
nicolasconnault
76ca1ff134 MDL-11075 Now saving to temp file, then outputting using filelib's readfile_chunked() method. Also cleaned up whitespace in filelib.php (blame vim!). 2007-08-31 13:54:13 +00:00
skodak
1e12457560 adding current groupid to grade_export class - soon to be used in plugins 2007-08-31 12:22:58 +00:00
toyomoyo
fc69d5577a MDL-10933, only 1 manual grade item can be added 2007-08-31 08:41:04 +00:00
skodak
0f5660f721 MDL-11069 new graded_users_iterator - should later improve memory use + performance 2007-08-31 07:33:45 +00:00
nicolasconnault
0e2d708efc MDL-11034 Implemented the global enablepublishing and refactored the handling of userkey for each export plugin. Also added a dump.php file in each plugin directory, although this could easily be refactored into 1 file in the parent folder, pointing to each plugin's export.php file for output differences. 2007-08-31 05:55:30 +00:00
skodak
11745964a5 MDL-11069 grade export refactoring + removing internally calculated totals (we have already various totals in categories and calculations can be used too for that) 2007-08-30 15:03:51 +00:00
skodak
0bfbab47e6 minor refactoring in grade export lib - part 2 2007-08-30 08:26:04 +00:00
skodak
350770f466 minor refactoring in grade export lib 2007-08-30 08:24:07 +00:00
skodak
c901b7a652 fixing regressions in grade export 2007-08-30 08:19:44 +00:00
nicolasconnault
74af2ea5ef MDL-10984 Adding publishing switch to txt and ods export formats 2007-08-30 07:44:42 +00:00
moodler
91e7ad594b Tidy up the link display page a bit 2007-08-30 07:12:03 +00:00
skodak
ca82569b5b grade export form refactoring 2007-08-29 16:47:16 +00:00
skodak
d93d67b7ac MDL-11051 grade export - do not use quickforms elements directly 2007-08-29 13:00:10 +00:00
skodak
a5bc4e6ef5 MDL-11050 grade export must use formslib properly - no data_submitted()! 2007-08-29 12:38:23 +00:00
nicolasconnault
0f78c4de3d MDL-11028 GUI complete, language strings complete, user key creation done. Validation is not yet coded. 2007-08-29 11:43:48 +00:00
toyomoyo
f8ae1f86c5 MDL-10963, group average code broken, count_ungraded is ignoring groups altogether. 2007-08-29 04:05:56 +00:00
skodak
d575afb836 MDL-11027 user key manager for grade exports - adding forgotten ownership test 2007-08-28 21:57:34 +00:00
skodak
eed8e3054b MDL-11027 user key manager for grade exports 2007-08-28 21:54:18 +00:00