Commit Graph

83 Commits

Author SHA1 Message Date
dd97c32868 MDL-12945 a slightly bigger patch for performance in recent activity and various group related issues + some other fixes - see list of subtasks in tracker; merged from MOODLE_19_STABLE 2008-01-24 20:33:50 +00:00
85c9ebb926 MDL-1883 improved perf when editing scales - new function xxx_scale_used_anywhere() 2007-09-18 18:37:58 +00:00
1d68419596 MDL-10383 - deprecated groups_members_from_sql and friends - we do not need them anymore because we reverted to 1.7 style groups in 1.9 2007-08-15 19:28:11 +00:00
859d05a03e mod/journal: HTML fixes
Fixed HTML errors causing parser errors in Firefox when in developer debug
mode.


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-16 23:12:26 +00:00
f3f7610c90 cvsimport fixups -- cvshead had strayed from upstream 2007-01-04 13:15:04 +13:00
714986dc40 Journal Module fixes fro 1.7 MDL-7159; merged from MOODLE_17_STABLE 2006-10-30 11:16:27 +00:00
583b57b42d Changed <module>_print_recent_activity() functions so that they don't use $isteacher. However, I've left the $isteacher parameter in the functions, for backward compatibility so as not to break thrid party modules. Should we remove the parameter now? 2006-09-24 14:01:50 +00:00
0bc94c9990 Last reserved word is out now!
journal_entries->comment to entrycomment

Only 2 tables have reserved names but they aren't
a problem if we force $CFG->prefix always
2006-09-21 09:54:00 +00:00
f3221af9e5 Initial checkin of stats (from processing the log table).
I will write up some information about it for the developers wiki.
2005-09-01 04:14:31 +00:00
be27364137 Very quick fix to remove notices (but loses some colors) 2005-05-17 19:55:37 +00:00
894ff63f8f Tabs are out 2005-05-16 22:22:31 +00:00
a8093758b1 Whoops - new strings now taken from correct lang file. 2005-04-12 15:26:57 +00:00
14333242e3 Made mail subject line text in language pack, not hardcoded. 2005-04-12 14:10:41 +00:00
8a2381f6b9 Now Journal mails support filterall. 2005-04-10 22:38:22 +00:00
c2dd62a773 Now journal->name supports filterall. 2005-03-30 19:26:23 +00:00
61f0aace2a Some more CSS changes (SE) 2005-03-24 13:59:59 +00:00
6aed9d10c2 Changes for XHTML, accessibility compatibility.
Removed THEME variable, inserted CSS classes where appropriate. (SE)
2005-03-24 12:43:22 +00:00
8f7dc7f1c7 Variety of small fixes, but mostly related to how the recent activity
block is constructed.  A new function exists to pump these notes out
in a standard way :  print_recent_activity_note.

Module dependencies also updated because of this.
2005-03-10 13:30:57 +00:00
5ad4a39da5 Merged from MOODLE_14_STABLE: Add new line after url in journal mailout to prevent /mod/journal/view.php?id=1----- type requests 2005-03-08 20:56:30 +00:00
95e72c12d0 Now retrieving only needed fields! 2005-02-13 00:42:29 +00:00
d7d21c383c Minor changes for XHTML compatibility 2004-10-08 13:58:33 +00:00
1c5d9bbbec closed some br tags 2004-09-12 22:29:44 +00:00
41905731b7 fixed capitalization and quoting of attribute values 2004-09-12 16:24:41 +00:00
a9ef4a630a closed <input /> <br /> <hr /> 2004-09-12 14:41:49 +00:00
222ac91bc9 removed unnecessary calls to get_site() 2004-08-29 14:15:40 +00:00
f950af3c43 All modules are now suitable for the site page. They now all follow the same rules, namely that any students enrolled in at least one course is considered to be a student on the site.
All the page headers work correctly also on the site course.

On the site page the modules don't require login unless necessary or required by $CFG->forcelogin.
2004-08-22 14:38:47 +00:00
2127fedda8 Step 2 of Bug 1223 done.
(http://moodle.org/bugs/bug.php?op=show&bugid=1223)
2004-05-16 00:36:00 +00:00
0f1a97c2fb Step 1 of Bug 1223 done.
(http://moodle.org/bugs/bug.php?op=show&bugid=1223)
2004-05-15 23:18:24 +00:00
58259e3217 Can use $CFG->journal_showrecentactivity to hide recent activity for journals 2004-04-30 04:50:41 +00:00
d5a2ccadb9 New function journal_count_entries() and more accurate counting of
journal entries for different grouping scenarios
2004-03-13 16:15:02 +00:00
80e376a20d Use format_text instead of text_to_html (so filtering works) 2004-02-08 09:47:29 +00:00
7008b03ca3 Fixed typo bug when getting users 2004-01-30 04:01:19 +00:00
5c09be163c Don't always use arraymerge in journal_get_users_done() - was causing
bad data sometimes ...
2004-01-30 01:57:00 +00:00
d7143408df replaced incorrectly closed html tags, see bug 365 2004-01-25 20:34:54 +00:00
34a2293e08 Journal questions can now use HTML editor, plus new field 'introformat' 2004-01-14 02:24:42 +00:00
19090101a9 Bug #966 - journal_grades should return NULL if no grade 2004-01-12 02:36:45 +00:00
9450cb6561 Use fullname function for displaying names 2003-11-28 15:45:46 +00:00
d94ee341e5 Undoing Greg's UNION hack ... it was causing problems on Mysql 3 2003-10-31 03:25:37 +00:00
dcfa857df2 This is a massive speed increase in journal_get_users_done.
The fix requires UNION support in the database.  I've added a simple little
test to see if UNION queries work.

This change very much needs to be tested out by someone using MySQL 3.  If
it tests out there successfully, the supports_union code should be moved out
of this file and into datalib.  Ideally, someone will extend that test and
creatle get_records_union_sql, a function that would split up UNION queries
for databases that don't support them and do an array_merge (and proper
sorting, which is missing from my fix) on the result sets.
2003-10-22 20:06:44 +00:00
0585509135 Simply, move the XXXX_get_participants() function from
bottom to the common function area.
See bug 807
2003-09-29 15:27:30 +00:00
058a2215ef Included journal_get_participants() function. 2003-09-07 21:36:03 +00:00
949cf8670c More cleanups for teacher view in particular 2003-08-27 09:03:10 +00:00
2a0d8c5b05 Fairly radical improvement to the Journal index, putting all the
information on one page.
2003-08-27 08:13:16 +00:00
e3f4e47a19 More robust when a journal is unused 2003-08-20 15:01:06 +00:00
efabdeddef Journal grading is now also all converted over to use scales as
well as numerical grades
2003-08-18 05:47:04 +00:00
ae078a9809 Mail-outs for assignment and journal module are now translatable. 2003-05-13 16:02:08 +00:00
1b5910c4a5 Trying a different tack for recent_activity since the old way was
still producing too much data and overflowing PHP memory on busier
sites (eg moodle.org).

Now, there are more database queries, which is unfortunate, but the
data is much more specific, and no sorting needs to be done, so
this is a performance boost.

I don't know how these will cancel out ... my guess is that very
small sites may be very slightly slower on the course page, but
that large sites will be much faster.

Let's see.
2003-04-26 15:08:34 +00:00
ad08fdc277 Performance improvements
- better checking of data before processing
  - used logs are removed to avoid re-processing by other modules
2003-04-26 12:59:41 +00:00
3d89198946 Cleaned up definition of constant COURSE_* values in course/lib.php
Moved COURSE_TEACHER_COLOR out to style sheets where it belongs (.teacheronly)

Added some efficiency when printing recent activity

 - don't print more than one weeks worth of updates
  - don't keep re-parsing logs once they've been used
2003-04-26 12:17:30 +00:00
2953d5e865 Show activity log only from visible journals. Bug #367. 2003-04-26 10:14:54 +00:00