jamiesensei
aa17ea53c4
MDL-15150 "Quiz Report broken in course without students" also now displaying a message when there are no attempts.
2008-06-06 14:59:24 +00:00
jamiesensei
a4ee9a602d
MDL-15150 "Quiz Report broken in course without students" added warning message if there are no students in course yet.
2008-06-06 14:03:55 +00:00
jamiesensei
181608b708
MDL-15092 "Quiz overview report won't display if there are more than 29 questions" fixed this by going back to the old way of fetching data for display in the table. However still use table JOINs when user wants to sort by question grade. The user can sort by a maximum of two columns at once so the JOINs will not exceed the limit.
2008-06-06 13:21:50 +00:00
jamiesensei
c35f3afcf1
MDL-15170 "convert to use new tablelib api"
2008-06-06 12:09:14 +00:00
skodak
cd655b33f9
MDL-15095 towards restore lib dml conversion
2008-06-03 23:35:50 +00:00
skodak
9db7dab2ca
MDL-15095 towards restore lib dml conversion
2008-06-03 22:36:54 +00:00
skodak
c18269c7e5
MDL-14679 towards modform conversion
2008-06-01 21:36:11 +00:00
skodak
7cac0c4b2b
MDL-14679 fixed references to mod.html
2008-06-01 19:09:13 +00:00
skodak
3264868249
MDL-14679 removed magic quotes from forms validation() method, fixed some minor problems
2008-06-01 17:53:25 +00:00
skodak
c6307ef24d
MDL-14679 removed all instances of get_records_sql_menu()
2008-06-01 16:08:16 +00:00
skodak
44e1b7d7ff
MDL-14679 remoed all instances of get_records_list()
2008-06-01 15:42:48 +00:00
skodak
fd0e6640cc
MDL-14679 fixed some more $db's
2008-05-31 22:18:41 +00:00
skodak
219f652b91
MDL-14679 upgrade $DB conversion
2008-05-31 18:05:42 +00:00
skodak
ae040d4bcc
MDL-14679 finished moodlelib conversion
2008-05-30 19:59:50 +00:00
jamiesensei
f198d0bda7
MDL-15047 "Quiz overview report download is broken - patch" fixed.
...
Merged from 1.9 stable branch.
2008-05-30 12:23:10 +00:00
jamiesensei
f17a34b5ef
MDL-15011 "grading report : allow user to select to grade next 10 ungraded attempts" added a new link and options to the grading report page to display only the next 10 ungraded attempts to grade. Also some fixes for faulty sql for ungraded option which was not respecting the users groups selection.
2008-05-29 14:14:27 +00:00
jamiesensei
ee5163b051
MDL-15002 "grading report : notice from quiz_num_attempt_summary about how many total attempts there are on the quiz and how many in this group would make UI clearer" added call to function and fixed centering of notice on overview and grading report by adding a clear:left to stop the centering being affected by the groups menu.
...
merged from 1.9 branch
2008-05-26 14:26:24 +00:00
jamiesensei
a76a131ab5
MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT"
...
Fixing notices introduced by the changes for this bug in grading report when no question is selected.
2008-05-26 13:18:46 +00:00
jamiesensei
f522bf51be
MDL-14988 "tables have been hardcoded with a prefix of "mdl" - causing an error." Ooops!
2008-05-26 12:51:04 +00:00
jamiesensei
686e602047
MDL-12824 "Essay type of quiz questions needs to color mark which students have been graded and which have NOT"
...
As well as highlighting graded questions with a new CSS class highlightgraded which is a yellow bg in the standard theme, have also added the option to grade all ungraded attempts for a question.
2008-05-26 12:47:42 +00:00
jamiesensei
720be6f2c3
MDL-5241 "When manually grading, identity questions by their number within the quiz as well as by question name"
...
Also added a drop down box to select question to mark instead of the viewquestions table. The drop down box is available at the top of every page, but only if there is more than one manually gradeable question in the quiz. If there is only one question it is automatically selected for marking.
Also added a new constant QUESTION_EVENTS_GRADED during a general refactoring of UI code in grading report and some improvements to efficiency of SQL in report.
Merged from Moodle 1.9 branch
2008-05-26 11:39:51 +00:00
jamiesensei
a59eb2b6a8
MDL-12547 "allow manual quiz grading to sort by groups" added code to select which group to grade.
...
Merged from Moodle 1.9 branch
2008-05-23 13:14:00 +00:00
tjhunt
95de57b8ac
Inconsistency between quiz attempt->id and attempt.uniqueid
2008-05-21 11:10:06 +00:00
jamiesensei
b392a56cab
MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" Now using php ceil function to round up $bands as in some cases it could be a non integer.
2008-05-16 14:56:23 +00:00
skodak
f33e1ed4ae
MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs
2008-05-15 21:40:00 +00:00
tjhunt
994c8c3509
MDL-14835 - Grade not checked against valid range when manua grading
2008-05-15 16:02:12 +00:00
tjhunt
9c22b42ef7
MDL-14857 - Clean up summary table generation code at the top of the quiz review page - This is basically a merge of improvements we made at the OU.
2008-05-15 15:32:43 +00:00
jamiesensei
ca35974827
MDL-14852 "improve sql in overview report for fetching question grades" moved all querying for question grades into main attempts sql query. AND MDL-14200 "Add group and course averages" some fixes for functionality to display question grades averages. Grade averages are not displayed when grading method is set to Average - as this cannot be done in sql and would be expensive to do in memory.
...
merged from 1.9 branch
2008-05-15 13:59:52 +00:00
jamiesensei
e649d4b120
MDL-14200 "Add group and course averages" fix for bug introduced in this patch. We are now using a seperate sql command to get the feedback text as we need to get it for the average rows too. Since it is not part of the sql to fetch attempt data we can't sort on Feedback anymore so removed the option from the table. Sorting by feedbacktext is not really useful anyway, users are more likely to want to sort by grade.
...
Merged from 1.9 branch.
2008-05-15 12:54:01 +00:00
jamiesensei
aad5b0fca9
MDL-14200 "Add group and course averages" added extra rows to the end of the table in quiz overview report also MDL-14187 "Improve tablelib - improve api and add functionality to download table contents in a variety of formats - XLS, ODS and CSV" implemented the first of my proposals for improving tablelib. Added a extra method to use keyed arrays to add a row to a table. Seems obvious that this is an improvement to tablelib and it is an addition to the API so won't affect existing code.
...
Merged from 1.9 branch.
2008-05-15 12:27:27 +00:00
jamiesensei
a568653185
MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" added perfect grade to last 'band' on graph.
2008-05-15 11:01:23 +00:00
jamiesensei
c187720b74
MDL-14201 "Summary graph" - small improvement to robustness for sql.
...
Merged from 1.9 branch.
2008-05-14 11:18:04 +00:00
jamiesensei
7d4d5cb918
MDL-14822 "Quiz Report: the quiz report do not find the first attempt" needed to include quiz id in WHERE conditions.
...
merged from 1.9 branch.
2008-05-14 09:17:09 +00:00
jamiesensei
51ca9f3095
MDL-14201 Summary graph in Overview Report - needed a little more spacing between bars of graph in some cases.
...
Merged from 1.9 stable branch.
2008-05-13 15:05:35 +00:00
jamiesensei
c5fedf065c
MDL-14223 "Add a column for the user's idnumber, controllable by a site-wide setting" and MDL-14224 "Add a site-wide setting to hide the user profile image from quiz reports"
...
The quiz overview report now respect the settings for the gradebook - whether to display idnumbers and user pictures.
Also re-factored the code to build table / download content a little to reduce code duplication.
2008-05-09 13:59:36 +00:00
jamiesensei
44eb3b6e9e
For the overview report : MDL-14199 "Option to only show / export final grade" small improvement to UI. Include highlighted message in the form about what the current grading method is.
...
Merged from 1.9 branch.
2008-05-08 09:53:31 +00:00
jamiesensei
b621e1a006
MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" adding a message about the highlighting above the table.
...
Merged from 1.9 branch.
2008-05-08 09:35:08 +00:00
jamiesensei
2fecd85ba6
MDL-14734 "improve interface for deleting attempts"
...
* The control for deleting attempts is a drop down box with onchange javascript to submit the form, you cannot see the label to say what the drop down box does. Better to use a button. The button label is visible so you can see what it does.
* Checkboxes should be displayed when there is no attempt to delete.
* The whole column for checkboxes should be removed when no attempts are displayed ie. when showing students with no attempts.
2008-05-07 16:00:56 +00:00
jamiesensei
8b87ab0000
MDL-14201 "Summary graph" included a summary graph at the bottom of overview report page. Shows the distribution of grades achieved by students. If a group is selected the grades from the group are compared with the grades for all participants.
2008-05-07 14:38:18 +00:00
jamiesensei
9b617d9210
For the overview report : MDL-14199 "Option to only show / export final grade" fixing a notice warning from the form definition
2008-05-07 14:01:04 +00:00
scyrma
59fa45d0f1
MDL-11113: simplify the code - use only one function to check for html editor availability
2008-05-07 07:40:50 +00:00
jamiesensei
f4ed09faae
For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" fixed a small problem I noticed in this patch.
2008-05-06 18:04:03 +00:00
jamiesensei
4469159e2d
For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score"
2008-05-06 17:34:39 +00:00
jamiesensei
0217f93275
For overview report - MDL-14185 "Switch to using formslib and improve the interface" and MDL-14186 "Switch to using moodle_url and eliminate the use of $SESSION global"
2008-05-05 13:12:11 +00:00
jamiesensei
1a85336b79
non consequential, little typo.
2008-05-03 13:56:32 +00:00
jamiesensei
2badf2e6ec
MDL-14677 "should rescale the grades displayed for each question in the detailed marks view of the overview report so that all grades add up to the sum total grade" used quiz_rescale_grades function to rescale the grade properly before displaying it. Also this patch includes some general clean up and refactoring of overview report.
2008-05-03 13:06:49 +00:00
jamiesensei
e49906d3b1
MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row."
2008-05-02 15:26:47 +00:00
jamiesensei
92c5499a84
MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row." Made a new query outside the loop for adding rows.
2008-05-02 15:11:59 +00:00
jamiesensei
e0b01669ce
MDL-14664 "sorting by question mark when viewing detailled mark in overview quiz report not working" Found that the problem ocurred when attempt.id != attempt.uniqueid as the sql was using the wrong field to join the question records.
2008-05-02 14:21:33 +00:00
jamiesensei
85a8704fe2
MDL-14663 "link_to_popup_window displays 'Click here....' as the link text if you pass in 0 as the link text."
...
Solved this by formatting the grade using number_format to display the grade with a number of decimal places. So for 0 we display something like 0.00 and this displays OK in link_to_popup_window.
2008-05-02 13:27:49 +00:00
