2123 Commits

Author SHA1 Message Date
David Monllao
d2c80085fd Merge branch 'MDL-61741-master-paypal' of git://github.com/mudrd8mz/moodle 2018-04-16 10:57:19 +02:00
Eloy Lafuente (stronk7)
0f0d0004bd Merge branch 'MDL-61208-master-fix' of git://github.com/farhan6318/moodle 2018-04-11 20:13:56 +02:00
Eloy Lafuente (stronk7)
8c46d204a1 MDL-60548 tests: Get tests passing
This includes:

- changing all usernames in feature to lowercase, for cross-db passing. Fixes:
  - user/tests/behat/set_email_display.feature
- ensure that course_enrolment_manager::get_potential_users() and
  external always returns user->maildisplay attribute, so email
  visibility can be calculated by user_get_user_details(). Fixes:
  - enrol/tests/behat/enrol_user.feature
  - blocks/news_items/tests/behat/display_news.feature
  - course/tests/behat/course_creation.feature
2018-04-11 17:15:38 +02:00
Farhan Karmali
351cff7928 MDL-61208 enrol: Fix for issue found while testing 2018-04-11 18:24:14 +05:30
Andrew Nicols
2b118a941a Merge branch 'MDL-61208-master' of git://github.com/farhan6318/moodle 2018-04-11 10:52:29 +08:00
Eloy Lafuente (stronk7)
66434106ed MDL-60548 test: Change modified lang string to get tests back to pass
Also modified a template example use, so there aren't courrencies
of the old string in codebase.
2018-04-10 23:24:17 +02:00
Eloy Lafuente (stronk7)
2f27dca60d Merge branch 'MDL-60548-master-v4' of https://github.com/Dave-B/moodle 2018-04-10 17:14:46 +02:00
Farhan Karmali
fe5b5be1dd MDL-61208 enrol: Standard enrol plugins should use tasks instead of cron 2018-04-10 09:16:17 +05:30
Eloy Lafuente (stronk7)
1f4670653d Merge branch 'MDL-61860-master' of https://github.com/mackensen/moodle 2018-04-10 01:00:31 +02:00
Jake Dallimore
9c533e01dd MDL-59581 database: remove mssql_native_moodle_database test from enrol 2018-04-09 01:59:37 +02:00
Charles Fulton
baab37149d MDL-61860 auth: standardise config inclusion 2018-04-05 14:37:02 -04:00
Andrew Nicols
711c4775c5 MDL-60811 enrol_self: Remove unused globals 2018-04-04 08:55:54 +08:00
Farhan Karmali
ebaf979c94 MDL-60811 enrol_self: Add bulk action for self enrollment on users page 2018-04-03 19:29:44 +05:30
David Mudrák
47ea60fd3e MDL-61741 enrol_paypal: Prevent some edge-case false errors
While testing the plugin in various scenarios, I've noticed that there
are two situations which the current code does not handle quite well:

* Detecting for existing txn_id record was likely to throw "found more
  than one record" debugging message. Fixed by explicitly ignoring
  multiple records.
* The incoming IPN verification message does not always contain the
  recipient's email in the "business" field. When a payment has to be
  claimed manually at PayPal (e.g. as a result of currencies mismatch
  and other settings), the email is coming only in the "receiver_email"
  field. This led to PHP notice and caused the script to fail falsely.
2018-03-23 19:50:26 +01:00
David Mudrák
a38da470af MDL-61741 enrol_paypal: Fix the IPN verification endpoint URL
IPN protocol spec has different URL for sending the verification
request. Better to have it fixed even if the existing value still
seems to work - to avoid unexpected surprise in the future.

Source: https://developer.paypal.com/docs/classic/ipn/integration-guide/IPNImplementation/#specs
2018-03-23 19:16:30 +01:00
Sara Arjona
9390fc5829 MDL-61265 enrol: Add default numsections for external db 2018-03-16 11:32:09 +01:00
David Mudrák
d12cdcbd7d MDL-61392 enrol_paypal: Improve IPN input parameters checking 2018-03-14 08:53:44 +08:00
David Mudrák
39a5fbeb01 MDL-61392 enrol_paypal: Improve the IPN notifications handling
* Notify administrators once incoming IPN request is verified by PayPal.
* Fix the HTTP status as expected by the IPN protocol.
2018-03-14 08:53:44 +08:00
Andrew Nicols
fe294b00ac Merge branch 'MDL-59070-master' of https://github.com/lucaboesch/moodle 2018-03-13 13:21:09 +08:00
Jake Dallimore
20e6024581 Merge branch 'master_MDL-49417' of https://github.com/danmarsden/moodle 2018-03-12 11:34:13 +08:00
Luca Bösch
c936af395e MDL-59070 enrol_database: Take enablecompletion from template 2018-03-08 17:24:39 +01:00
Dan Marsden
1a11bf375c MDL-49417 enrol_cohort: use ajax searchable selector for cohorts. 2018-03-01 13:39:56 +13:00
Sara Arjona
e2cd8d3c6d MDL-61249 enrol_manual: Fix end date calculation
This patch has been given by Bruno Malaval.
2018-02-23 08:19:49 +01:00
Eloy Lafuente (stronk7)
fcafde7e48 Merge branch 'MDL-61324_lti_sync' of git://github.com/davosmith/moodle 2018-02-22 08:30:52 +08:00
Davo Smith
8037f32b8a MDL-61324 enrol_lti: fix detection of changed grades during sync 2018-02-12 08:25:44 +00:00
Farhan Karmali
4fd0bdb2b7 MDL-61236 enrol: Course welcome message to be sent from correct contact 2018-02-11 20:45:49 +05:30
Andrew Nicols
9e82cab6b6 Merge branch 'MDL-58410_master' of git://github.com/markn86/moodle 2018-01-29 08:15:39 +08:00
Igor Sazonov
358b10a337 MDL-58410 user: add support for alternative name search
The solution about searching all external names fields (middlename etc) from course enrolment page (enrolled and enrolling pages)
2018-01-24 11:15:45 +08:00
Eloy Lafuente (stronk7)
3c2501ac77 Merge branch 'MDL-60812-master' of https://github.com/mwehr/moodle 2018-01-22 16:33:07 +01:00
Eloy Lafuente (stronk7)
4fa58ece62 Merge branch 'MDL-61081-master' of git://github.com/sarjona/moodle 2018-01-16 00:27:38 +01:00
David Balch
d2bba97d77 MDL-60548 profile: Clarify some users can always see email addresses. 2018-01-15 12:21:09 +00:00
wehr
122c999536 MDL-60812 enrol_manual: Fixes not working default role 2018-01-12 16:13:27 +01:00
Farhan Karmali
19f0685069 MDL-61081 enrol: Start and end date for courses created by external db
Course created by external db enrolment plugin should have start date as current date
and end date is todays date + default course duration
2018-01-12 09:57:22 +01:00
wehr
e6a87bd192 MDL-61156 enrol_manual: Fixes not working manual quick enrolment in IE11 2018-01-12 09:14:28 +01:00
Helen Foster
700522badd MDL-61046 lang: Merge English strings from the en_fix language pack
Significant string changes:

* pluginname_desc, enrol_category - improved explanation
* pathtopythondesc, core_admin - mentioning Python version
* configdeleteunconfirmed, core_admin - setting applies to more than
  just email-based self-registration
2018-01-04 11:30:54 +01:00
Jun Pataleta
ccb8edbff5 MDL-50666 behat: Make feature names unique
* We need to have unique feature names for our Behat tests.
* I also removed the custom Behat tag @role_visibility as we only allow
Behat tags with the component name in Frankenstyle format.
2017-12-20 13:37:28 +13:00
Jun Pataleta
a8dffa2d03 Merge branch 'MDL-50666-master' of https://github.com/junpataleta/moodle 2017-12-20 12:49:28 +13:00
Andrew Hancox
64cd459648 MDL-50666 core: Rename allow_ACTION to core_role_set_ACTION_allowed 2017-12-19 13:53:23 +13:00
Andrew Hancox
a63cd3e2ca MDL-50666 core: Add function get_viewable_roles to set role visibility 2017-12-19 13:53:23 +13:00
Andrew Nicols
560ae357a0 Merge branch 'MDL-57564-master-courseorder' of git://github.com/mudrd8mz/moodle 2017-12-18 11:04:20 +08:00
Damyon Wiese
39377f8083 Merge branch 'MDL-44667-master' of https://github.com/snake/moodle 2017-12-12 10:26:08 +08:00
David Mudrák
c260117d15 MDL-57564 enrol: Add unit tests for the new sorting behaviour 2017-12-06 23:15:17 +01:00
David Mudrák
a3d003603a MDL-57564 enrol: Change the default sort in other two functions
Similarly to what the previous patch does, we now change the default
sorting in functions enrol_get_users_courses() and
enrol_get_all_users_courses() too.

The patch also adds missing phpDocs for the functions, improves the
readability of some existing bits and mentions the changes in the
enrol/upgrade.txt file.
2017-12-05 22:58:51 +01:00
Jake Dallimore
3112c22004 MDL-44667 database: fix incorrect usages of $DB->get_field
Some places were passing 5 params, meaning the strictness param was
lost. This fixes those usages.
2017-12-04 16:53:51 +08:00
Eloy Lafuente (stronk7)
e4eba4c346 MDL-59159 upgrade: clean < 3.1.0 upgrade steps
LTS (3.5) requires previous LTS (3.1)

This just deletes all the upgrade steps previous to 3.1.0. Some
small adjustments, like adding missing MOODLE_INTERNAL or tweaking
globals can also be applied when needed.

Also includes an upgrade step to prevent upgrading from any
version < 2016052300 (v3.1.0) as anti-cheating measure.

Next commit will get rid of/deprecate all the upgradelib functions
not used anymore in codebase.
2017-12-04 01:18:57 +01:00
Eloy Lafuente (stronk7)
25e9c56117 Merge branch 'MDL-60738-master' of git://github.com/jleyva/moodle 2017-11-28 20:59:22 +01:00
Sara Arjona
46ea440b87 MDL-60830 core_enrol: Added email when searching users in course enrol 2017-11-22 13:16:16 +01:00
Juan Leyva
6db2423551 MDL-60738 webservice: Clean theme and lang properly
Sometimes the "theme" and "lang" fields in the user and course tables
in the database are set to incorrect values (uninstalled or
non-existent themes and language packs).
This makes Web Services functions to fail because the WS server
validate the returned data using the validate_param function that clean
parameters.
2017-11-20 09:37:30 +01:00
Damyon Wiese
dbf0819d92 Merge branch 'MDL-59876-master' of git://github.com/jleyva/moodle 2017-11-13 10:47:49 +08:00
Eloy Lafuente (stronk7)
6499085f36 MDL-60784 upgrade: add 3.4.0 separation line to all upgrade scripts 2017-11-12 18:43:30 +01:00