Jamie Pratt
da8cd9f4b3
MDL-28268 Missing ORDER BY when using extra answer table.
...
From OU bug #921 "Order of answer fields in Variable numeric keeps changing" Cannot
reproduce this bug on my system but hopefully this will fix the problem. I added
an ORDER BY clause to the sql for fetching answers with extra answer fields.
2011-07-09 07:26:08 +01:00
Eloy Lafuente (stronk7)
26635fd7f9
Merge branch 'MDL-28169' of git://github.com/nebgor/moodle
2011-07-07 10:21:32 +02:00
Aparup Banerjee
c5a8abfedd
MDL-28169 Installation Added 2.1 upgrade (idiot proof) lines to upgrade scripts.
2011-07-07 11:40:38 +08:00
Tim Hunt
56920c36f9
MDL-28160 question preview window uses wrong pagelayout in activity contexts
2011-07-03 12:53:56 +01:00
Eloy Lafuente (stronk7)
f4f835b739
fix permissions
2011-07-01 23:39:00 +02:00
Tim Hunt
aa5257ce7e
MDL-28103 one more problem.
2011-07-01 21:17:06 +01:00
Tim Hunt
1645ad22d8
MDL-28103 code to deal with missing question_attempts was buggy.
2011-07-01 21:07:49 +01:00
Tim Hunt
dfcbecd487
MDL-28103 when handling questions that have been deleted from the question bank, find the right updater class.
2011-07-01 17:13:47 +01:00
Eloy Lafuente (stronk7)
3bd43d3d5c
Merge branch 'MDL-27418' of git://github.com/timhunt/moodle
2011-07-01 11:05:17 +02:00
Tim Hunt
e42646b167
MDL-27418 fix minor regression found by Rajesh.
2011-07-01 09:44:31 +01:00
Tim Hunt
01533e9cce
MDL-28138 fix calculated-specific format float function
...
Sadly this has to be done in question.php and in two places in the ugprade code :-(.
2011-07-01 09:14:56 +01:00
Eloy Lafuente (stronk7)
a80d6ab536
Merge branch 'MDL-28128' of git://github.com/timhunt/moodle
2011-07-01 01:49:59 +02:00
Eloy Lafuente (stronk7)
70debd7391
Merge branch 'MDL-28129' of git://github.com/timhunt/moodle
2011-07-01 01:41:38 +02:00
Tim Hunt
baf706b503
MDL-28132 truncate very long category names before using them in random question names.
2011-06-30 19:35:35 +01:00
Jamie Pratt
e5060e2209
MDL-28129 two issues with loading and saving questions
...
1. Missing order by could randomise the order of the hints.
2. the extraanswerfields big had some SQL errros.
2011-06-30 17:21:37 +01:00
Tim Hunt
ceb4d2ed0b
MDL-28128 finish the fix for MDL-28035.
...
There was one place where I had only fixed the backup code to work-around bad data from Moodle 2.0. I needed to make the equivalent change in the upgrade code.
The bad data is that the seq_number fields can be wrong (not unique). Se already have data ordered by (seq_number, id) and the array keys of the array we are building are not used for anything, so this fix deals with the problem.
2011-06-30 16:00:15 +01:00
Tim Hunt
69384c1939
MDL-28127 incorrect lang string placeholder in question engine upgrade.
2011-06-30 15:20:42 +01:00
Eloy Lafuente (stronk7)
f684dce013
Merge branch 'MDL-28108' of git://github.com/timhunt/moodle
2011-06-30 00:00:12 +02:00
Eloy Lafuente (stronk7)
6e344148c1
MDL-27418 qtype numerical - minor whitespace fix
2011-06-29 23:57:08 +02:00
Eloy Lafuente (stronk7)
88933f08cb
Merge branch 'MDL-27418' of git://github.com/timhunt/moodle
2011-06-29 23:51:33 +02:00
Eloy Lafuente (stronk7)
0f744d2ca4
Merge branch 'MDL-27430' of git://github.com/timhunt/moodle
2011-06-29 23:33:01 +02:00
Eloy Lafuente (stronk7)
be13d37a02
Merge branch 'MDL-28074' of git://github.com/timhunt/moodle
2011-06-29 23:09:13 +02:00
Tim Hunt
05a5c2f9a2
MDL-28108 oops! I got the cut-off percentage wrong.
2011-06-29 22:02:59 +01:00
Tim Hunt
56a4ae4673
MDL-28074 question preview should set context/course/cm properly.
...
1. We need this so that, for example, when previewing a question from
the quiz editing page, the preview uses the filter settings, theme and
language set for that quiz and course.
2011-06-29 21:25:56 +01:00
Tim Hunt
3a6eb8efdf
MDL-27418 qtype numerical correct grading of 'right value, wrong unit' reponses.
...
Probably easiest to explain by example: If the right answer is 1.23 m with alternate
unit 100 cm = 1m then the completely right answers are 1.23 m and 123 cm.
Right answer, wrong unit responses include 1.23, 1.23 frogs and 1.23 cm.
123 m is not considered to have the correct numerical value.
We may well re-consider the way this works in a future version of Moodle.
Unit grading was not implemented before Moodle 2.0. In Moodle 2.0, the unit grading
was more permissive than here, for example 123 m would have been graded correctly in
2.0. However, I'm not sure I follow the rationale for that.
2011-06-29 15:41:56 +01:00
Tim Hunt
c5aaf41739
MDL-27418 add unit tests for the problem case identified by Pierre.
2011-06-29 06:55:45 +01:00
Tim Hunt
f040d4b046
MDL-27418 add validation to stop students intering a thosands sep.
...
If it might be confused by a decimal point from another locale.
2011-06-28 18:26:34 +01:00
Tim Hunt
1a1353a5ce
MDL-27418 qtype numeric go back to the very permissive number parsing from Moodle 2.0.
...
I hope my unit tests are good enough to make this change safe.
2011-06-28 18:13:44 +01:00
Tim Hunt
eef75d4b31
MDL-27418 qtype_numeric correct output of numbers in locales that use , for decimal point.
2011-06-28 17:37:09 +01:00
Tim Hunt
9048940701
MDL-27418 correct validation of numerical answers in qtype numeric.
...
This mostly affects locales that use , as decimal point.
2011-06-28 17:36:24 +01:00
Tim Hunt
3aa159706c
MDL-27418 fix typo
...
I really should refactor to eliminate this duplicated code.
2011-06-28 17:34:24 +01:00
Tim Hunt
8566369f63
MDL-27430 qtype numerical put multiple-choice units back to radio buttons
...
It seems that people want to be able to use <sup> and <sub> here, which
makes sense, so we need to keep radio buttons for questions upgraded
from 2.0. The dropdown menu, however, is also nice, so keep that option
too for new questions.
2011-06-28 16:33:01 +01:00
Tim Hunt
0366ef262a
MDL-28035 problems with upgrade/restore of ataptive quizzes from 2.0
...
There were two main problems:
1. The unit tests for upgrading adaptive quiz attempts had slighly the
wrong $expectedqa, and so matching that the upgrade was doing the wrong
thing in certain situations. The main issue was that it was setting
-_try = 1 on the first step, which broke the penalty calculation when
the quiz was regraded. There were also some other subtleties with
incrementing -_try that were not right before.
2. It was possible in 2.0 and earlier for two question_states to get the
same seq_number, and restoring 2.0 backups was rashly assuming that that
was unique.
2011-06-27 17:10:02 +01:00
Eloy Lafuente (stronk7)
32038aaccc
Merge branch 'MDL-28033' of git://github.com/timhunt/moodle
2011-06-27 17:12:40 +02:00
Eloy Lafuente (stronk7)
3bdc10150c
Merge branch 'MDL-28049' of git://github.com/timhunt/moodle
2011-06-27 15:56:03 +02:00
Tim Hunt
19f7bb5b7e
MDL-28049 conditional include so xml question format can work for both lesson and 3rd party qtypes.
...
This is a regression caused by MDL-27956.
2011-06-27 13:59:57 +01:00
Tim Hunt
2779cc7d89
MDL-28033 Fatal error upgrading form 1.9 to 2.1 due to missing include.
2011-06-27 13:43:16 +01:00
Sam Hemelryk
29e2d0a820
Merge branch 'MDL-26199' of git://github.com/timhunt/moodle
2011-06-27 16:03:48 +08:00
Tim Hunt
5cc532e8e9
MDL-28024 adaptive qbehaviour. Displayed penalties not rounded correctly.
2011-06-24 14:26:49 +01:00
Tim Hunt
f19ed874ee
MDL-26199 further changes needed to make the question bank navigation behave.
2011-06-23 07:18:49 +01:00
Eloy Lafuente (stronk7)
4c15bde8f1
Merge branch 'MDL-27948' of git://github.com/timhunt/moodle
2011-06-23 01:14:19 +02:00
Eloy Lafuente (stronk7)
e345969ae2
Merge branch 'MDL-27937' of git://github.com/timhunt/moodle
2011-06-23 00:46:29 +02:00
Eloy Lafuente (stronk7)
e059fa90b1
Merge branch 'MDL-27973' of git://github.com/timhunt/moodle
2011-06-23 00:43:11 +02:00
Eloy Lafuente (stronk7)
4d05c972ea
Merge branch 'MDL-27974' of git://github.com/timhunt/moodle
2011-06-23 00:37:13 +02:00
Eloy Lafuente (stronk7)
a2854474ce
Merge branch 'MDL-27979' of git://github.com/timhunt/moodle
2011-06-23 00:34:03 +02:00
Tim Hunt
da72991636
MDL-27979 Should be an edit link for each question when previewing or reviewing a quiz.
2011-06-22 21:07:40 +01:00
Tim Hunt
eb624cf7e0
MDL-27937 Calculated tolerance field should have the label Tolerance +-
2011-06-22 19:49:39 +01:00
Tim Hunt
35d5f1c28d
MDL-27948 The question engine should use recordsets to load attempt data
...
This should be good for performance (memory usage). It also avoids having to construct a meaningless, unique, first column, which is a pain on MyQSL.
2011-06-22 18:53:15 +01:00
Tim Hunt
ef01d2c8f5
MDL-27973 hopefully fix QTI2 question export.
...
Well, at least fix the most obvious notices.
2011-06-22 15:56:05 +01:00
Tim Hunt
3c78184552
MDL-27974 problems with gift question import/export.
...
Double-escapeing in match export and not initialising combined feedback on import.
Also remove a lot of redundant breaks.
2011-06-22 15:26:34 +01:00
