mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-03-15 13:10:08 +01:00
Code Issues Projects Releases Wiki Activity
95,911 Commits 36 Branches 523 Tags
Commit Graph

95911 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Andrew Nicols
fb803f8854 Merge branch 'MDL-67268-master' of git://github.com/mihailges/moodle 2019-11-15 12:08:33 +08:00
Mihail Geshoski
c7cb3b297b MDL-67268 mod_forum: Group and label radio buttons in forum grader 2019-11-15 12:05:59 +08:00
Andrew Nicols
630a1b0e01 MDL-67269 mod_forum: Capture form submission in grading panel 2019-11-15 11:47:37 +08:00
Andrew Nicols
f45a2860e5 Merge branch 'MDL-67265' of git://github.com/Chocolate-lightning/moodle_forum-project 2019-11-15 10:35:00 +08:00
Mathew May
4e796e2205 MDL-67265 core: Set max-height on toast wrapper 2019-11-15 09:21:06 +08:00
Jake Dallimore
891e027cf1 Merge branch 'MDL-67241-master' of git://github.com/lameze/moodle 2019-11-14 16:34:28 +08:00
Jake Dallimore
324258e5f5 Merge branch 'MDL-67144-integration' of git://github.com/Chocolate-lightning/moodle_forum-project 2019-11-14 15:17:24 +08:00
Mathew May
fc741e030e MDL-67144 mod_forum: If no users exist do not show the grading interface 2019-11-14 15:00:30 +08:00
Jun Pataleta
ff175fce22 Merge branch 'MDL-67246-master' of git://github.com/jleyva/moodle 2019-11-14 14:34:17 +08:00
Jake Dallimore
0460d21b28 Merge branch 'MDL-67207-master' of git://github.com/andrewnicols/moodle 2019-11-14 14:27:42 +08:00
Jun Pataleta
e9f63f3fc0 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-14 12:37:22 +08:00
Andrew Nicols
c3777543a6 MDL-67116 course: Restore removed line 
This line was inadvertently removed in a previous commit.
 2019-11-14 11:43:37 +08:00
Andrew Nicols
8a0b9b1830 Merge branch 'MDL-67250-master-httpswwwroot' of git://github.com/mudrd8mz/moodle 2019-11-14 10:54:14 +08:00
Simey Lameze
0e287a0e7b MDL-67241 mod_forum: raise memory limit when exporting 2019-11-14 10:12:15 +08:00
Adrian Greeve
b6343156f9 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-14 09:03:31 +08:00
Andrew Nicols
0a5a2ca89b MDL-67116 course: Strict empty string check required 
In PHP the following are true:

    assert('' == '');
    assert(0 == '');
    assert(null == '');

The options in the course completion settings are now:

    ''    => none selected
    [int] => itemnumber of activity course completion item.

In the case where the itemnumber was 0  this was being incorrectly
evaluated as an empty string due to the implicit cast to int of the
empty string:

    (int) '' === 0

As a result, the non-strict comparison means that the following are
identical:

    assert(0 == '');
    assert(0 == (int) '');
    assert(0 == '0');

Changing the comparison to a strict comparison is correct because it
ensures the type consitency between the empty string value, and the int
of itemnumber 0. It is safe because the value always comes from the
form, where an int is always returned, and not the DB, where a string is
returned.
 2019-11-14 08:59:56 +08:00
Eloy Lafuente (stronk7)
ccd5f606c3 Merge branch 'MDL-67248-master' of git://github.com/cescobedo/moodle 2019-11-14 01:12:01 +01:00
David Mudrák
469d4b7f35 MDL-67250 setup: Revert removal of the httpswwwroot setting 
It is still used widely in the plugins that would stop working suddenly
without being warned via a debugging message. We must keep it forever as
an alias for the wwwroot.
 2019-11-13 19:58:10 +01:00
cescobedo
f12d708e61 MDL-67248 filter_displayh5p: Add new description on filter 2019-11-13 18:36:09 +01:00
Juan Leyva
666de97917 MDL-67246 admin: Return course color settings for external clients 2019-11-13 15:33:20 +01:00
Jun Pataleta
f136aa1933 Merge branch 'MDL-67231-master' of git://github.com/andrewnicols/moodle 2019-11-13 16:00:16 +08:00
Jun Pataleta
289c9e14c4 Merge branch 'MDL-67116-master' of git://github.com/andrewnicols/moodle 2019-11-13 15:31:03 +08:00
Andrew Nicols
799418ad12 MDL-67207 forum: Reset focus after closing grade viewer 2019-11-13 14:30:54 +08:00
Andrew Nicols
21900f035e MDL-67207 forum: Return focus when closing expanded discussion 2019-11-13 14:30:54 +08:00
Andrew Nicols
c50bc1bf7c MDL-67207 core: Use focus lock manager in modals 2019-11-13 14:30:54 +08:00
Andrew Nicols
4395ef464d MDL-67207 forum: Reset focus after closing grader 2019-11-13 14:30:54 +08:00
Andrew Nicols
7ede47b738 MDL-67207 forum: Lock focus in grader 2019-11-13 14:30:48 +08:00
Andrew Nicols
dcdcc12cb2 MDL-67207 core: Add new ARIA focus locker 
This is based on code and examples provided in the ARIA specification
https://www.w3.org/TR/wai-aria-practices/examples/dialog-modal/dialog.html
 2019-11-13 14:30:32 +08:00
Adrian Greeve
23ac81e396 Merge branch 'MDL-67178' of git://github.com/Chocolate-lightning/moodle_forum-project 2019-11-13 14:30:06 +08:00
Andrew Nicols
8bd3e49cc9 MDL-67231 h5p: Correct naming of h5p unit test files 2019-11-13 14:24:28 +08:00
Jun Pataleta
783897e56f Merge branch 'MDL-67232-master' of git://github.com/lameze/moodle 2019-11-13 13:49:22 +08:00
Mathew May
2cac67a016 MDL-67178 mod_forum: Allow users to backup forum grades 2019-11-13 13:25:54 +08:00
Andrew Nicols
c035141971 MDL-67116 course: Fix completion disabled for gradable items 
The default value is an empty string (""), which in PHP evaluates to 0 when
cast to a string in our DML layer.

The fix is to forcibly make it null which is not cast to string in DML
for optional strings.
 2019-11-13 12:49:59 +08:00
Jun Pataleta
2e08e15065 Merge branch 'MDL-67199' of https://github.com/stronk7/moodle 2019-11-13 11:20:02 +08:00
Jun Pataleta
ec99ffd352 Merge branch 'MDL-67218-master' of git://github.com/andrewnicols/moodle 2019-11-13 11:00:22 +08:00
Simey Lameze
e28388735c MDL-67232 mod_forum: remove initialuserid data attr from template 2019-11-13 10:33:55 +08:00
Jake Dallimore
df8fff9f34 Merge branch 'MDL-66812-master' of git://github.com/bmbrands/moodle 2019-11-13 10:25:42 +08:00
Adrian Greeve
c3044a19b9 Merge branch 'MDL-67215-master' of git://github.com/peterRd/moodle 2019-11-13 10:18:59 +08:00
Andrew Nicols
fe795b59e4 MDL-67116 form: Require grade in multi-grade-item activities 
AMOS BEGIN
  CPY [rating,rating],[grade_rating_name,rating]
AMOS END
 2019-11-13 10:14:37 +08:00
Ryan Wyllie
a492f69caf MDL-67116 course: allow grading completion for non ratings grade item 2019-11-13 10:11:44 +08:00
Andrew Nicols
d21ba3f6a8 MDL-67218 form: Do not clear grade when rescaling not enabled 2019-11-13 10:11:44 +08:00
Andrew Nicols
09ab002746 Merge branch 'MDL-67194-master' of git://github.com/vmdef/moodle 2019-11-13 08:38:34 +08:00
Andrew Nicols
003c856a7e Merge branch 'wip_MDL-67205_master' of git://github.com/gjb2048/moodle 2019-11-13 08:31:25 +08:00
Eloy Lafuente (stronk7)
adc5449399 MDL-67199 versions: main version bump 2019-11-12 17:58:42 +01:00
Eloy Lafuente (stronk7)
d5be859063 MDL-67199 versions: bump all versions and requires near release 
version = 2019111800 release version
requires= 2019111200 current beta (week7roll1) version
 2019-11-12 17:57:08 +01:00
Eloy Lafuente (stronk7)
1633a6035d Moodle release 3.8beta v3.8.0-beta 2019-11-12 16:50:55 +01:00
Jun Pataleta
bbb7cb2173 Merge branch 'MDL-66906-master-fix' of git://github.com/andrewnicols/moodle 2019-11-12 22:01:37 +08:00
Andrew Nicols
49d5920ac6 MDL-66906 gradingform_rubric: Add back missing field 2019-11-12 21:04:54 +08:00
Jun Pataleta
134f11e15a Merge branch 'MDL-66906-integration-3' of git://github.com/Chocolate-lightning/moodle_forum-project 2019-11-12 16:38:58 +08:00
Mathew May
07d8669dbf MDL-66906 mod_forum: Show learners their grades in a Modal 2019-11-12 16:17:04 +08:00