51 Commits

Author SHA1 Message Date
Tim Hunt
25a03faaca MDL-20636 fix many code-checker issues in mod/quiz. 2011-05-12 00:30:25 +01:00
Tim Hunt
55ca80edde MDL-20636 Fix lots of problems found by the new improved codechecker. 2011-04-04 20:11:29 +01:00
Tim Hunt
c7df5006b9 MDL-20636 Add lots of missing public/protected/private. 2011-03-23 16:22:25 +00:00
Tim Hunt
3c6185e979 MDL-20636 Move restart preview button into the quiz nav block & remove unnecessary titles.
Also, remove automatic redirects to the quiz edit page. Show a message and a button instead.
2011-02-25 12:12:09 +00:00
Tim Hunt
2daffca554 MDL-20636 Fix 30 TODOs 2011-02-24 17:47:51 +00:00
Tim Hunt
f7970e3ca7 MDL-20636 Eliminate integer and boolean in PHPdoc comments. should be int and bool. 2011-02-23 16:25:25 +00:00
Tim Hunt
a17b297d60 MDL-20636 Add missing defined('MOODLE_INTERNAL') || die(); 2011-02-23 16:00:20 +00:00
Tim Hunt
9b40c540ee MDL-20636 Responses report mostly working. 2011-02-14 17:57:47 +00:00
Tim Hunt
7ee80cab53 MDL-20636 Manual comment popup comment.php now works. 2011-02-09 20:29:59 +00:00
Tim Hunt
6577832390 quiz reports MDL-25206 Make it more obvious how to review the students responses. 2010-11-15 16:41:42 +00:00
Eloy Lafuente
8ad6765887 NOBUG quiz - overview & responses reports fixes 2010-09-17 01:07:17 +00:00
Tim Hunt
414e727676 quiz reports MDL-23161 notify(get_string('nostudentsyet')) breaking downloads. 2010-08-11 18:34:42 +00:00
Tim Hunt
f6c7f15883 quiz reports MDL-17388 tweak layout so more useful stuff fits on the first page.
In particular, I think you should be able to see at least the top of the table or results without scrolling, if your monitor is not too small.
2010-08-04 18:45:05 +00:00
Tim Hunt
24f17d7588 quiz responses report MDL-23377 responses report needs to be fixed in HEAD as well as overview. 2010-08-04 15:05:31 +00:00
Tim Hunt
a49cb927fd NOBUG more consistent use of URLs for the quiz reports. 2010-07-28 15:08:34 +00:00
Tim Hunt
cd0a2ed882 quiz reports MDL-22847 Cannot delete quiz attempts when a group is selected. 2010-06-23 20:09:09 +00:00
Rossiani Wijaya
f484c0ad08 MDL-22257 - Change the fields value (3rd parameter) from 'id' to 'u.id' 2010-05-28 07:24:01 +00:00
Tim Hunt
37b5b69f2e quiz reports MDL-22257: was loading the complete user record, when it only wanted userid.
On a coures with 16000 users, that is a very bad idea ;-)
2010-04-30 13:15:42 +00:00
Tim Hunt
db77f4103c quiz reports: MDL-21688 Add missing sesskey checks. 2010-04-07 11:26:02 +00:00
Petr Skoda
b9bc201962 MDL-21233 escaped parameter is far more importatnt than the overrideparams in out() method - especially all JS urls should be converted to out(false); also it is possible to create new url with overrided parameters in constructor which might be actually work around the double encoding problems in the url (we should never use the out() in moodle_url constructor itself!) 2010-01-17 09:50:55 +00:00
Petr Skoda
eb7880654f MDL-21233 finally removed the omitquerystring parameters from the out method because: 1/ the least used parameter should nto be first, 2/ it is colliding with the other two paramters, now we have separate funtion for that instead 2010-01-17 09:37:30 +00:00
Petr Skoda
a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
Petr Skoda
78946b9bdb MDL-20204 first batch of major theme changes, some regressions are still there, expect more changes and improvements soon; see tracker for details and list of subtasks 2009-12-16 18:00:58 +00:00
Petr Skoda
aeb15530b8 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-04 11:57:52 +00:00
nicolasconnault
825116fb22 MDL-19813 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:16:08 +00:00
tjhunt
34a2777ccb themes: MDL-19077 new $OUTPUT->header/footer to replace print_header/footer.
Also, part of the change from weblib.php functions to $OUTPUT-> methods.

This is part of http://docs.moodle.org/en/Development:Theme_engines_for_Moodle%3F

This is a big change, and the result is not perfect yet. Expect some debugging output
on some pages.

The main part of these changes are that $OUTPUT->header now looks for a file
in the theme called layout.php, rather than header.html and footer.html. Also
you can have special templates for certain pages like layout-home.php. There is
fallback code for Moodle 1.9 themes, so they still work.

A few of the old arguments to print_header are no longer supported. (You get an
exception if you try to use them.) Sam H will be cleaning those up.

All the weblib functions that have been replaced with $OUTPUT-> have version in
deprecatedlib, so existing code will go on working for the foreseeable future.
2009-06-26 09:06:16 +00:00
tjhunt
eacb462e38 quiz reports: MDL-19205 Improved tooltips on individual question grades. 2009-06-05 06:54:42 +00:00
tjhunt
96c7d771df quiz: MDL-14926 New capability mod/quiz:reviewmyattempts, separate from mod/quiz:attempt. Merged from MOODLE_19_STABLE. 2009-01-14 07:08:02 +00:00
dongsheng
85c30b9c91 "MDL-14129, fix hardcoded print_error" 2008-09-25 01:55:39 +00:00
jamiesensei
bfcaf5e684 MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" Ooops. We do need highlighting on the reponses report. The responses page does have a grade displayed that needs highlighting. I was looking at an ungraded quiz. Need highlighting to highlight grade of graded attempt.
Reverted earlier patch and instead using a different colour for highlighting graded grade. Now using light yellow with a darker yellow border instead of green which is used in reports to highlight the correct answer.
2008-09-24 09:10:43 +00:00
jamiesensei
14133ad913 MDL-16632 "green highlighting should not be applied to grading method in quiz responses report form" 2008-09-23 10:39:12 +00:00
tjhunt
739b07112e MDL-16625 Detection of whether a quiz has grades was broken in HEAD.
1. Fix this by factoring out a quiz_has_grades function.
2. Fix the quiz unit tests.
3. Fix quiz_has_feedback to return false for ungraded quizzes.
4. Fix use of get_records to do record_exists in quiz reports.
2008-09-23 07:18:15 +00:00
tjhunt
337fa7a0ef MDL-16263 - followup - fix notices. 2008-08-29 11:30:16 +00:00
tjhunt
f88fb62c40 MDL-10682 - Ensure quiz and question grades are formatted consisently and correctly. While testing, I also fixed a few XHTML Strrrict errors. 2008-08-15 06:42:38 +00:00
tjhunt
c89f2f13d8 Fix comment. 2008-07-29 13:32:28 +00:00
jamiesensei
3e71541fde MDL-15729 "detailled responses report not showing responses" 2008-07-21 10:27:47 +00:00
jamiesensei
6559096f2c MDL-15728 "quiz_report_load_questions should alias qqi.grade to maxgrade so that questions array has the required fields expected by much of the question code." 2008-07-21 09:06:46 +00:00
jamiesensei
d71226a4ac whitespace fixes 2008-07-21 08:02:37 +00:00
jamiesensei
35bf63526a MDL-15718 "overview report slow for large data sets - print_user_picture queries the db if only provided with a userid" 2008-07-20 14:40:22 +00:00
jamiesensei
162db41723 MDL-15198 "non-standard sql in reportlib.php" using CASE statement to wrap logic in fields list 2008-07-20 14:34:53 +00:00
jamiesensei
7f29a7dbe4 MDL-15631 "move detailled responses report out of contrib into main distribution" adding responses report to main distribution 2008-07-20 14:29:10 +00:00
gustav_delius
5f9ef821df Moved detailed responses report into contrib 2006-03-26 12:02:46 +00:00
mjollnir_
ecb5d875af Updated the comments around the horrible sql construction in the quiz reports for overview & response 2006-03-01 03:00:33 +00:00
mjollnir_
eeaf5ebce1 Ported the rework of the reports to the responses report. PLEASE try not to load all users into memory and then implode it into a string for the sql - just JOIN, it is what the database is good at :( 2006-03-01 02:46:15 +00:00
gustav_delius
4f48fb42af Towards removing reference to quiz module from the question code
Renaming tables:
quiz_questions -> question
quiz_states -> question_states

Renaming functions:
quiz_delete_question -> delete_question
quiz_get_question_options -> get_question_options
quiz_get_states -> get_question_states
quiz_restore_state -> restore_question_state
quiz_save_question_session -> save_question_session
quiz_state_is_graded -> question_state_is_graded
quiz_extract_responses -> question_extract_responses
quiz_regrade_question_in_attempt -> regrade_question_in_attempt
quiz_process_responses -> question_process_responses
quiz_isgradingevent -> question_isgradingevent($event)
quiz_search_for_duplicate_responses -> question_search_for_duplicate_responses
quiz_apply_penalty_and_timelimit -> question_apply_penalty_and_timelimit
quiz_print_question_icon -> print_question_icon
quiz_get_image -> get_question_image
quiz_make_name_prefix -> question_make_name_prefix
quiz_get_id_from_name_prefix -> question_get_id_from_name_prefix
quiz_new_attempt_uniqueid -> question_new_attempt_uniqueid
quiz_get_renderoptions -> question_get_renderoptions
quiz_print_quiz_question -> print_question
quiz_get_question_responses -> get_question_responses
quiz_get_question_actual_response -> get_question_actual_response
quiz_get_question_fraction_grade -> get_question_fraction_grade
quiz_get_default_category -> get_default_question_category


Renaming constants:
QUIZ_EVENT.... -> QUESTION_EVENT....
QUIZ_MAX_NUMBER_ANSWERS -> QUESTION_NUMANS
2006-02-28 09:26:00 +00:00
gustav_delius
f02c6f017e Renamed QUIZ_QTYPES to QTYPES 2006-02-24 13:48:43 +00:00
gustav_delius
03d1753c1c Renamed table quiz_newest_states to question_sessions 2006-02-15 08:38:41 +00:00
stronk7
8867a3bb88 Now Quiz is using the new Excel generation API.
Merged from MOODLE_16_UTF8. Abandoning the branch.
2006-01-05 16:43:05 +00:00
moodler
69ef01c00d We don't show unenrolled users in quiz reports normally 2005-11-08 06:52:32 +00:00
gustav_delius
3db6659d2d fix for bug 3953 provided by Jean-Michel 2005-08-26 08:00:19 +00:00