mirror_php/moodle
1
0
Fork 0
mirror of https://github.com/moodle/moodle.git synced 2025-02-25 20:43:33 +01:00
Code Issues Projects Releases Wiki Activity
35,252 Commits 36 Branches 523 Tags
Commit Graph

998 Commits

Author SHA1 Message Date
tjhunt
2aef1fe52f question editing: MDL-18035 Nice refactoring from Oleg Sychev that saves 50+ lines of code between the various editing forms. 2009-02-18 06:52:11 +00:00
tjhunt
5348b899c4 random question: MDL-18174 Fix notice when adding a random question to a quiz. 2009-02-17 06:14:54 +00:00
tjhunt
24e8b9b684 question bank: MDL-12719, MDL-15774, MDL-17105, and MDL-18174 
These are all to do with the combination of the $form->category, and $form->categorymoveto fields on the question editing forms since Moodle 1.9. These are now resolved to a single ->category value in question.php, which simplifies the logic for the individual question types.

MDL-15774 and MDL-12719 errors editing Cloze question
MDL-17105 problems with qustion saving logic.
MDL-18174 'Select from subcategories' option not preserved when editing a random question.
 2009-02-13 06:11:42 +00:00
tjhunt
2d1e69d37b question bank: MDL-18215 select all checkbox does not always work. 2009-02-13 05:06:01 +00:00
tjhunt
2a874d65ce quiz editing: MDL-17455 refactor the editing code to use the locallib functions to print the icons. 
Also, use the new method in the random question class to get the list of random questions reliably.
 2009-02-11 10:08:07 +00:00
tjhunt
64ead3edee Nuke irrelevant comment. 2009-02-11 07:24:29 +00:00
pichetp
9af77e9d17 MDL-18034 Rename answers field to answer in calculated qtype form to increase consistency 2009-02-03 00:40:40 +00:00
Francois Marier
6280ef3e58 Fix CVS-git drift (remove some files deleted in CVS) 2009-02-01 23:43:28 +00:00
pichetp
0a6555f854 MDL-18034 saving answers data in $question->answer if they come from edit from. 2009-01-27 15:00:19 +00:00
pichetp
103a800d67 MDL-17995 replacing is_null() by empty(). 2009-01-26 01:21:58 +00:00
pichetp
8795a5ae25 MDL-17995 replacing $wrapped !='' by !is_null($wrapped) 
MDL-17857 Allowing multianwer (Cloze) question to have a 0 default grade as other question types
 2009-01-25 14:49:02 +00:00
tjhunt
692d0480e0 question bank: MDL-16345 minor pritification. 2009-01-23 07:29:12 +00:00
tjhunt
bfb1691da3 question bank: MDL-18000 Make select all work by clicking the checkbox column heading. 
Yay! I got bug 18000 and it is already fixed.
 2009-01-23 06:05:25 +00:00
tjhunt
b7a9dc5193 question bank: MDL-17992 and MDL-17397. Put back questiontext as a separate row option, and increase consistenscy between stand-alone qbank and the display in the quiz editing page. 2009-01-23 05:01:37 +00:00
tjhunt
bcda961144 matching qtype: MDL-17981 extra distractors feature was not working on MS SQL server, since MDL-14420 was fixed. 2009-01-23 02:19:30 +00:00
tjhunt
714aaf918a shortanswer qtype: MDL-17800 Fix merge problem. Thanks to Oleg for spotting this. 2009-01-23 01:11:21 +00:00
tjhunt
e4d1d5e010 question bank: MDL-17871 finish refactor of code into one class per column. 
Needs tidying up, but basically there, so checking it in.
 2009-01-22 09:19:37 +00:00
tjhunt
971c6fca06 question bank: MDL-17871 Kill most of the duplicated code between mod/quiz/editlib.php and question/editlib.php 2009-01-22 05:38:18 +00:00
tjhunt
0ff5afdfbf question bank: MDL-17871 Possibility for tool tips on column headings. 2009-01-22 02:32:39 +00:00
tjhunt
babdcb4024 question bank: MDL-17302 fix errors in the previous commit. 2009-01-21 08:52:42 +00:00
tjhunt
b221dc6f23 question bank: MDL-17302 refactor question bank display code into a class. 
Step 3. Start working ot the code to initialise things from a list of columns, and build the corresponding SQL query.
 2009-01-21 08:49:15 +00:00
tjhunt
5bd22790c4 question bank: MDL-17871 refactor the code that displays particular information about each question into classes. 
More work in progress. Print column headers, and improve sorting. These classes are still not used.
 2009-01-21 07:21:43 +00:00
Jonathan Newman
4d933beb8a cvsimport fixups 2009-01-20 23:53:34 +00:00
tjhunt
46795afcbd question bank: MDL-17871 refactor the code that displays particular information about each question into classes. 
Work in progress. Most required classes are writted, but nothing uses them yet, and I have not dealt with column headers yet.
 2009-01-20 10:11:23 +00:00
tjhunt
80829be920 quiz backup: MDL-17970 MSSQL text / varchar compare issue. 
Commiting this fix so it gets into 1.9.4. I've tested and it does not break sensible databases, and probably fixes the problem on MSSQL.
 2009-01-20 04:24:07 +00:00
tjhunt
d61f7b7641 backup/restore: MDL-16614 more reliable test for when we are restoring a backup that was made of the same site that we are restoring to. 
* Use this to fix a question restore bug.
* Replace older code that does something similar with the new test.
* Refactor initialisation of $CFG->siteidentifier into a function. There were about 4 copies of this code ;-)
 2009-01-20 03:16:30 +00:00
tjhunt
5b5e5ab20c question bank: MDL-17302 refactor question bank display code into a class. 
Step 2. Remove as many as possbile of the differences between the two classes. This is mostly whitespace and irrelevant code formatting issues, but there are also a few changes to the generated output, taking the best of both views.
 2009-01-19 08:50:48 +00:00
tjhunt
f4b879ddea question bank: MDL-17302 refactor question bank display code into a class. 
Step 1. Just convert the existing functions quiz_question_showbank and question_showbank and friends into methods of a class and subclass.

More to come.
 2009-01-19 05:30:01 +00:00
skodak
56949c17de MDL-14992 refactored use of session_write_close() 2009-01-17 15:25:08 +00:00
tjhunt
c599a68240 question bank: MDL-12787, MDL-17870 field in the question editing form to tag questions, and load and save the tags from the DB. 2009-01-16 08:00:06 +00:00
tjhunt
a18ba12ca6 quiz / questions: MDL-17919 Bad link edit questions from quiz preview page. 
Thanks to Ann Adamcik for noticing this. It was a regression from MDL-6085.
 2009-01-16 04:47:23 +00:00
tjhunt
c795dc7843 questiontypes: MDL-17800 
Fix another merge error.
 2009-01-16 04:24:24 +00:00
tjhunt
815262cab6 questiontypes: MDL-17800 
Fix merge error.
 2009-01-16 04:23:21 +00:00
tjhunt
c51c539d11 questiontypes: MDL-17800 Add extra_question_fields() support to backup/restore functions. 
* Implement this in the base class, and
* use this in the shortanswer type as a proof of concept.

This makes writing new question type subclasses a bit easier. Thanks to Oleg Sychev for this code.
 2009-01-15 07:29:07 +00:00
tjhunt
d65c238b2c question engine: MDL-17651 this context is not used anywhere, so remove it. 
(There was a bug in the get_context_instance call.)
 2009-01-15 05:15:38 +00:00
skodak
58fa5d6f75 MDL-16483 - renamed MoodleUnitTestCase to FakeDBUnitTestCase; MDL-17841 removed bogus remove lib/simpletest/slowcodetest.php 2009-01-10 13:47:26 +00:00
tjhunt
d001dac77b shortanswer qtype: MDL-17706 use extra_question_fields mechanism to save on code. Changes thanks to Oleg Sychev. 2009-01-09 05:10:33 +00:00
tjhunt
71990c7cf6 question preview: MDL-17418 Enable previewing of random questions. 
Also, fix a grade rounding issue.
 2009-01-08 09:03:49 +00:00
tjhunt
b4a2e41313 quiz editing: MDL-17284 fix infinite redirect bug. 2009-01-07 07:12:37 +00:00
tjhunt
807a1a8427 question bank database: MDL-17608 Drop originalquestion field from the question_states table - it was never used for anything. 2009-01-06 05:20:21 +00:00
skodak
11e7b506ce MDL-17754, MDL-11061, MDL-9276, MDL-17777, MDL-17787 - various url handling improvemetns; rewritten $FULLME and added $ME, $SCRIPT and $FULLSCRIPT; improved slashargument handling especially for IIS; removed legacy slasharguments functions obsoleted since 1.6; some other refactoring; reverse procy support, ssl appliance support 2009-01-05 21:37:20 +00:00
thepurpleblob
9843511764 MDL-17779 
Add simple check that question at least has questiontext before allowing it.
 2009-01-05 15:23:10 +00:00
skodak
973d2660e6 MDL-16613 sesskey cleanup 2009-01-02 10:51:26 +00:00
skodak
d4a1fcaf11 MDL-16613 sesskey cleanup 2009-01-02 10:36:25 +00:00
tjhunt
7028ab335d match qtype: MDL-17326 backup and restore problems 
* The shuffleanswers options was not backed up or restored.

* Responses were not properly recoded on restore.
 2008-12-12 06:45:07 +00:00
dongsheng
771dc7b298 "MDL-14129, fix error() in moodle2" 2008-12-12 05:45:43 +00:00
dongsheng
60e40dda6c "MDL-14129, remove the rest error() in moodle2" 2008-12-12 04:53:32 +00:00
tjhunt
299d9fb834 matching qtype: MDL-17496 With filterall and multilang, the contents of the dropdowns was not being properly filtered 
This was caused becuse the solution to MDL-9005 was not quite right.
 2008-12-12 04:39:38 +00:00
tjhunt
be8563b63a numerical and shortanswer question types: problems with compare_responses and test_response. 
MDL-15315 The previous fix for this issue with wildcard answers in the item analysis report caused the following two regressions. This patch fixes it properly.

MDL-17247 This is basiclly pointing out the weridness in the previous fix and gave some useful clues as to a proper solution. Thanks Oleg.

MDL-17610 This was a report of a problem with each attempt builds on last, with a shortanswer question, where the sutdent's response contains a '.

Also, lots of unit tests to try to ensure the new code is right.
 2008-12-12 03:48:39 +00:00
tjhunt
f932b81953 matching qtype: MDL-14420 Could not use '0' as a question stem. Oops, more tests need to be corrected. 2008-12-11 05:01:37 +00:00