2228 Commits

Author SHA1 Message Date
tjhunt
4e1132a8c5 forum: MDL-19119 missing requires now course/lib.php is not included everywhere.
Put in most of the obvious missing require_once($CFG->libdir . '/completionlib.php');
2009-05-08 09:00:41 +00:00
tjhunt
b7b2d0f37d moodle_page: MDL-12212 improve comments and add some work-in-progress warnings 2009-05-06 09:29:05 +00:00
tjhunt
6bf44482c6 pagelib: MDL-12212 eliminate quiz_page 2009-05-06 09:24:45 +00:00
tjhunt
93d4a373f9 blocklib: MDL-19010 always include blocklib in setup.php, stip includes elsewhere 2009-05-06 09:13:16 +00:00
tjhunt
ad52c04f4c moodle_page: MDL-12212 Kill legacy url_... and blocks_... methods
Start calling $PAGE->set_url in all the places it will be necessary
Start of a stub implementation of $PAGE->blocks to stop other things breaking
Remove some of the special case methods in admin_page
2009-05-06 08:55:53 +00:00
tjhunt
f230ce19ea moodle_page: MDL-12212 implement ->pagetype 2009-05-06 08:34:32 +00:00
stronk7
74c288a100 MDL-18577 drop enums support - step2: enums out from install.xml files 2009-05-01 14:07:43 +00:00
stronk7
2a88f626f7 MDL-18577 drop enums support - step2: enums out from editor, dbmanager and all upgrade scripts. 2009-05-01 01:19:16 +00:00
tjhunt
2f2ade1609 quiz unit tests: remove dubious and failing test. 2009-04-24 10:00:09 +00:00
skodak
3268cf9921 MDL-18910 full support for module intro editor with embedded images 2009-04-22 06:48:15 +00:00
skodak
0cd1affc58 MDL-18910 full support for module intro editor with embedded images 2009-04-22 04:57:34 +00:00
skodak
dc5c2bd9eb MDL-18910 full support for module intro editor with embedded images 2009-04-21 21:17:21 +00:00
skodak
42f103be4c MDL-18910 moving modedit features to modname_supports() 2009-04-21 08:57:20 +00:00
skodak
18b5df9155 MDL-18910 normalised module intro and introformat 2009-04-20 19:29:15 +00:00
tjhunt
2f5f73d014 quiz editing: MDL-18871 logic was backwards for deciding whether to show the 'This quiz is not graded, so you cannot set overall feedback that differs by grade' warning introduced in MDL-18583. 2009-04-16 03:12:27 +00:00
fmarier
316914bf6e MDL-17037 ran all GIF images through gifsicle and PNG through optipng 2009-04-05 23:33:00 +00:00
tjhunt
dab9be1ad1 quiz manual grading: MDL-17586 'Grade all 4 ungraded attempts' acutally does the opposite' 2009-03-26 01:50:22 +00:00
tjhunt
72b9b78682 quiz: MDL-18637 fix 1.9-style DB code merged to HEAD by mistake. 2009-03-24 04:15:49 +00:00
tjhunt
c159da4ce5 Fix typo. 2009-03-23 03:57:45 +00:00
tjhunt
44d1cba4af quiz: MDL-18635 log every single hit to mod/quiz/attempts.php
I don't know why the quiz only logged every 10 minutes. No other part of Moodle worked like that. However, it has always been like that and I did not have a good reason to change it until now.

What was a problem becuase it made it harder to catch people doing a primitive DOS attack against the server by hitting Reload repeatedly.
2009-03-23 01:59:30 +00:00
tjhunt
e0b7cfcb31 quiz settings: MDL-18583 When a quiz has no grade, make it clear that you can only enter one lot of overall feedback.
When the maximum grade for the quiz is 0, we disable all the overall feedback form controls except for the first, and display an explanitory message.
2009-03-18 07:33:56 +00:00
tjhunt
5ecfab5148 quiz outline report: MDL-18285 Show regrade date, not last attempt date.
I also took the opportunity to clean up the code a bit.
2009-03-18 05:16:49 +00:00
tjhunt
3e10e4292d quiz editing: MDL-17454 first attemtp, and MDL-18554
This is a minimal fix for MDL-18554, I have just added a cancel button and made it work.

The more substantial part of this is MDL-17454, trying to make the quiz editing screen behave appropriately when shuffle questions is on. I am sure Olli will have opinions about this and want to change it further. Rought summary:
* When shufflequestions is off, never restrict manual paging, even if questionsperpage is set.
* When shuffle questions is on:
** Always display the quiz with the defined number of questions per page.
** Remove controls to add things except at the end of the quiz.
** Disable most of the order and paging tab, but still allow the question list to be reordered, in case that helps teachers track which questions they have added.
** Still allow questions to be reordered on the edit tab, but when moving the top question on a page up, reorder with the previous question, rather than moving to the previous page.
* Change the status bar, so that the yellow highlight is reserved for alert information. The more informative stuff is now plain, and moved to under the title. To my mind that associates it more closely with the quiz name. Also it moves Total of grades and Maximum grade closer together.
* JavaScript cleaned up. I learn more about YUI every day.
* Some PHP code clean ups that I forgot to commit separately before making substantive changes.
2009-03-17 09:51:34 +00:00
tjhunt
de57941d2a quiz editing: unindent entire file. 2009-03-17 08:21:37 +00:00
tjhunt
eeab18f0b3 quiz settings: MDL-17333 Resolve the interrelations between shufflequestions and questionsperpage.
* change the wording of the settings.
* add a repaginate now checkbox (disabled if shuffle is on).
* JavaScript to automatically check the checkbox when qpp changes.
* (remove some irrelevant return value checks now we use exceptions.)
2009-03-17 07:08:33 +00:00
Francois Marier
200164446a Fix drift with CVS 2009-03-11 13:16:54 +00:00
tjhunt
692e0c3395 MDL-18521 Countdown timer should be visible on the summary page 2009-03-11 07:10:57 +00:00
tjhunt
1d9673b648 quiz timer js: Fix typo (that was not causing problems) 2009-03-11 07:00:36 +00:00
tjhunt
26da840f6b quiz and qtypes: Regressions from MDL-7308 since '0.0000000' is not empty() in PHP. 2009-03-11 06:36:25 +00:00
tjhunt
84e628a027 quiz settings: MDL-18485 Improve quiz settings form
* Reorder form fields to group things more logically.
** and on the corresponding admin page too.

* Set some options to be 'Advanced' by default:
** Apply penalties.
** Each attempt builds on the last.
** Decimal places for question grades.
** The five 'Extra restrictions on attempts' settings. (password, etc.)
* Admins can still change this to suit their institiution at Administration > Plugins > Activity modules > Quiz.
* These new defaults are applied if the admin had not previously set any fields to be advanced.

* Disable some filds when they are not applicable:
** Grading method, if num attempts = 1
** Penaly scheme, if adaptive mode = no
** Each attempt builds of last, if num attempts = 1
** Review after quiz closed options, if no close date.
** Delay between 1st and 2nd attempts, if num attempts = 1
** Delay between later attempts, if num attempts < 3

* Convert quiz.timelimit to be in seconds, for consistency, and ready for the new duration field type (MDL 18500).
** Including ensuring that backup and restore is backwards compatible.

* MDL-5537 New setting, questiondecimalpoints, so, for example, you can show the quiz grade as an integer, but have fractional question grades.
** There is a 'Same as overall decimal points' option, which is the default.

* Improve some field labels.

* Make corresponding changes in the help files.
2009-03-10 08:39:51 +00:00
tjhunt
f5831eeac0 quiz editing: coding style cleanup. 2009-03-06 04:06:48 +00:00
tjhunt
26574bbad7 quiz/questions: Improve documentation of database tables. 2009-03-05 11:24:41 +00:00
tjhunt
790524a32e quiz overview report: Fix type of the grade columns to be NUMBER(12,7).
Also, improve comments.
2009-03-05 11:24:15 +00:00
tjhunt
2457254946 quiz reports: Fix up unit tests. 2009-03-05 08:50:01 +00:00
tjhunt
53004e480f quiz lib: MDL-17579 should call delete_attempt from questionlib.php rather than trying to do the job itself. 2009-03-04 08:35:05 +00:00
tjhunt
4299df1daf quiz editing: Refactor the editing actions to make functions in editlib.php for most of them.
In the process, do MDL-17456, move/delete questions by question id rather than position, for greater robustness.
2009-02-27 08:45:05 +00:00
tjhunt
1fd211a770 quiz: Fix unit tests. 2009-02-27 08:43:28 +00:00
tjhunt
324d65763c quiz editing: MDL-17284 Major coding style cleanup.
This is a mixture of stuff in the coding guildelines and personal preference.
2009-02-26 08:30:45 +00:00
tjhunt
944efb3e8b quiz editing: MDL-18376 Since there is no grading for description, we can show more question text. Thanks Olli. 2009-02-26 06:51:35 +00:00
tjhunt
8e84d9788c quiz editing: MDL-18173 tidy up wording and add cursor: help. 2009-02-25 07:27:02 +00:00
tjhunt
cd120b2344 quiz editing / question bank: MDL-18355 Convert the add question drop-down to be a button that pops up a YUI dialogue.
That allows us to have a few sentences explanation of each question type, and is also easier to fit into a tight layout.

This commit should also fix MDL-18214 Layout screwed in Safari with long category names.
2009-02-25 07:14:03 +00:00
tjhunt
5d6f63bf71 quiz editing: tidy up quotes. 2009-02-25 06:53:10 +00:00
tjhunt
3cac440b76 quiz editing: MDL-18173 Make clear in the UI whether a random question selects from subcategories or not. 2009-02-24 05:16:23 +00:00
tjhunt
1bd66f3914 quiz attempts: MDL-18283 add accept-charset="utf-8" to avoid encoding problems. 2009-02-17 07:21:56 +00:00
tjhunt
2b6ec12cd4 quiz editing: MDL-18016 fix regression, adding questions on the order and paging tab was broken. 2009-02-13 07:12:41 +00:00
tjhunt
7b161e1290 quiz editing: MDL-17284 improve wording for delete -> remove all selected questions. 2009-02-13 07:11:55 +00:00
tjhunt
5bbdaed2a1 quiz editing: MDL-17455 fix non-unique first column in get records. Thanks Olli for spotting this. 2009-02-12 05:04:19 +00:00
tjhunt
4cc11ff992 quiz editing: MDL-17455 fix missing global. Oops. 2009-02-11 10:35:41 +00:00
tjhunt
2a874d65ce quiz editing: MDL-17455 refactor the editing code to use the locallib functions to print the icons.
Also, use the new method in the random question class to get the list of random questions reliably.
2009-02-11 10:08:07 +00:00
tjhunt
68b1b19b16 quiz editing: Whitespace improvements. 2009-02-11 09:48:30 +00:00