6803 Commits

Author SHA1 Message Date
stronk7
e4552afb15 Handle properly in restore the change data->notification from NULL to NOT NULL. MDL-14548 2008-05-15 22:34:52 +00:00
skodak
f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
tjhunt
994c8c3509 MDL-14835 - Grade not checked against valid range when manua grading 2008-05-15 16:02:12 +00:00
tjhunt
9c22b42ef7 MDL-14857 - Clean up summary table generation code at the top of the quiz review page - This is basically a merge of improvements we made at the OU. 2008-05-15 15:32:43 +00:00
jamiesensei
ca35974827 MDL-14852 "improve sql in overview report for fetching question grades" moved all querying for question grades into main attempts sql query. AND MDL-14200 "Add group and course averages" some fixes for functionality to display question grades averages. Grade averages are not displayed when grading method is set to Average - as this cannot be done in sql and would be expensive to do in memory.
merged from 1.9 branch
2008-05-15 13:59:52 +00:00
jamiesensei
e649d4b120 MDL-14200 "Add group and course averages" fix for bug introduced in this patch. We are now using a seperate sql command to get the feedback text as we need to get it for the average rows too. Since it is not part of the sql to fetch attempt data we can't sort on Feedback anymore so removed the option from the table. Sorting by feedbacktext is not really useful anyway, users are more likely to want to sort by grade.
Merged from 1.9 branch.
2008-05-15 12:54:01 +00:00
jamiesensei
aad5b0fca9 MDL-14200 "Add group and course averages" added extra rows to the end of the table in quiz overview report also MDL-14187 "Improve tablelib - improve api and add functionality to download table contents in a variety of formats - XLS, ODS and CSV" implemented the first of my proposals for improving tablelib. Added a extra method to use keyed arrays to add a row to a table. Seems obvious that this is an improvement to tablelib and it is an addition to the API so won't affect existing code.
Merged from 1.9 branch.
2008-05-15 12:27:27 +00:00
jamiesensei
a568653185 MDL-14844 "Quiz Report: Bar Graph doesn't displayed maximum grade" added perfect grade to last 'band' on graph. 2008-05-15 11:01:23 +00:00
sam_marshall
8fae6d11d2 MDL-14838: Corrected javadoc package names in wiki 2008-05-15 10:08:55 +00:00
agrabs
c184660d31 MDL-14522 - new capability "receivemail" for better control who gets the email after
a response.
New option site_after_submit to define the url of the continue-button after completing
 a feedback
2008-05-14 22:34:00 +00:00
agrabs
d92cadd63e MDL-14823 - changed $feedbackid to $feedback->id in function feedback_set_events() 2008-05-14 21:35:32 +00:00
robertall
3df06e6b33 MDL-14442: apply addslashes() before importing values, to allow quotes in field's values. Merged from MOODLE_19_STABLE 2008-05-14 18:11:22 +00:00
jamiesensei
c187720b74 MDL-14201 "Summary graph" - small improvement to robustness for sql.
Merged from 1.9 branch.
2008-05-14 11:18:04 +00:00
jamiesensei
7d4d5cb918 MDL-14822 "Quiz Report: the quiz report do not find the first attempt" needed to include quiz id in WHERE conditions.
merged from 1.9 branch.
2008-05-14 09:17:09 +00:00
dongsheng
64e6c53d57 "MDL-14442, some error checking added" 2008-05-14 02:54:18 +00:00
thepurpleblob
74da63289f Wasn't checking for empty due date. 2008-05-13 15:19:31 +00:00
thepurpleblob
7a3f8bf4b7 Small tidy up - left in some stuff, and now use proper error function. 2008-05-13 15:10:36 +00:00
jamiesensei
51ca9f3095 MDL-14201 Summary graph in Overview Report - needed a little more spacing between bars of graph in some cases.
Merged from 1.9 stable branch.
2008-05-13 15:05:35 +00:00
thepurpleblob
62e49765a4 MDL-14045:
Assignment type now links to type/xxxx/all.php if it exists.
2008-05-13 14:56:29 +00:00
thepurpleblob
3b0d5ca301 MDL-14045:
Add ability to list all online assignments in a course.
Rather like what Journal used to do.
2008-05-13 14:46:10 +00:00
thepurpleblob
e1faf3b99b MDL-14813:
submittedlink() returns an absolute rather than relative link.
2008-05-13 10:43:20 +00:00
dongsheng
f85c75b72e "MDL-14442, Import all records of a database activity that has been exported as CSV, merged from MOODLE_19_STABLE, thanks, Robert" 2008-05-13 02:56:51 +00:00
stronk7
00f9b05834 Avoid $_REQUEST["id"] usage. MDL-14806 ; merged from 19_STABLE 2008-05-13 01:48:45 +00:00
jamiesensei
c5fedf065c MDL-14223 "Add a column for the user's idnumber, controllable by a site-wide setting" and MDL-14224 "Add a site-wide setting to hide the user profile image from quiz reports"
The quiz overview report now respect the settings for the gradebook - whether to display idnumbers and user pictures.

Also re-factored the code to build table / download content a little to reduce code duplication.
2008-05-09 13:59:36 +00:00
agrabs
bf5ebe7366 MDL-14518 - changed $SESSION->feedback->current_tab to $current_tab 2008-05-08 12:09:59 +00:00
agrabs
3cad95693b removed a call print_box_end(). It was not needed. 2008-05-08 11:49:48 +00:00
jamiesensei
44eb3b6e9e For the overview report : MDL-14199 "Option to only show / export final grade" small improvement to UI. Include highlighted message in the form about what the current grading method is.
Merged from 1.9 branch.
2008-05-08 09:53:31 +00:00
jamiesensei
b621e1a006 MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" adding a message about the highlighting above the table.
Merged from 1.9 branch.
2008-05-08 09:35:08 +00:00
jamiesensei
2fecd85ba6 MDL-14734 "improve interface for deleting attempts"
* The control for deleting attempts is a drop down box with onchange javascript to submit the form, you cannot see the label to say what the drop down box does. Better to use a button. The button label is visible so you can see what it does.
* Checkboxes should be displayed when there is no attempt to delete.
* The whole column for checkboxes should be removed when no attempts are displayed ie. when showing students with no attempts.
2008-05-07 16:00:56 +00:00
jamiesensei
8b87ab0000 MDL-14201 "Summary graph" included a summary graph at the bottom of overview report page. Shows the distribution of grades achieved by students. If a group is selected the grades from the group are compared with the grades for all participants. 2008-05-07 14:38:18 +00:00
jamiesensei
9b617d9210 For the overview report : MDL-14199 "Option to only show / export final grade" fixing a notice warning from the form definition 2008-05-07 14:01:04 +00:00
skodak
932f9b6f8d MDL-14724 Students cannot see discussions in forums made by teachers if timedposts enabled; merged from MOODLE_19_STABLE 2008-05-07 11:32:06 +00:00
scyrma
59fa45d0f1 MDL-11113: simplify the code - use only one function to check for html editor availability 2008-05-07 07:40:50 +00:00
dongsheng
23360b81dd "MDL-13233, replace the uses of old files to new ones, see tracker" 2008-05-07 03:08:44 +00:00
agrabs
d040813855 MDL-14711 - added a class feedback_item_pagebreak in feedback_item_class.php 2008-05-06 19:27:04 +00:00
mudrd8mz
6b34c1d45c MDL-14712 Remove function hotpot_get_report_users() 2008-05-06 18:25:47 +00:00
jamiesensei
f4ed09faae For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" fixed a small problem I noticed in this patch. 2008-05-06 18:04:03 +00:00
jamiesensei
4469159e2d For the overview report : MDL-14199 "Option to only show / export final grade" and MDL-14198 "Make it clear which student attempt gives the final grade, if the scoring method is first, last or highest score" 2008-05-06 17:34:39 +00:00
jamiesensei
0217f93275 For overview report - MDL-14185 "Switch to using formslib and improve the interface" and MDL-14186 "Switch to using moodle_url and eliminate the use of $SESSION global" 2008-05-05 13:12:11 +00:00
stronk7
4a005b22e3 Fixing query to be cross-db. Credit goes to David Mudrak. MDL-14583 ; merged from 19_STABLE 2008-05-05 00:28:45 +00:00
stronk7
2d1e097157 Glossary concepts must support multilang filter (all filters, in fact).
And accesible alt texts for action buttons too. MDL-14687 ; merged from 19_STABLE
2008-05-05 00:09:58 +00:00
agrabs
416c42286b MDL-14657 - additional check if instance-id is numeric for better compatibility to
postgres
2008-05-03 21:41:53 +00:00
jamiesensei
1a85336b79 non consequential, little typo. 2008-05-03 13:56:32 +00:00
jamiesensei
2badf2e6ec MDL-14677 "should rescale the grades displayed for each question in the detailed marks view of the overview report so that all grades add up to the sum total grade" used quiz_rescale_grades function to rescale the grade properly before displaying it. Also this patch includes some general clean up and refactoring of overview report. 2008-05-03 13:06:49 +00:00
jamiesensei
e49906d3b1 MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row." 2008-05-02 15:26:47 +00:00
jamiesensei
92c5499a84 MDL-14666 "overview report is very inefficient when view detailed marks is selected. There are several sql queries per row." Made a new query outside the loop for adding rows. 2008-05-02 15:11:59 +00:00
jamiesensei
e0b01669ce MDL-14664 "sorting by question mark when viewing detailled mark in overview quiz report not working" Found that the problem ocurred when attempt.id != attempt.uniqueid as the sql was using the wrong field to join the question records. 2008-05-02 14:21:33 +00:00
jamiesensei
85a8704fe2 MDL-14663 "link_to_popup_window displays 'Click here....' as the link text if you pass in 0 as the link text."
Solved this by formatting the grade using number_format to display the grade with a number of decimal places. So for 0 we display something like 0.00 and this displays OK in link_to_popup_window.
2008-05-02 13:27:49 +00:00
poltawski
45e94d82dd MDL-13716 - When storing progress of scorm activity a 404 is
encountered and js failure on split. Cast to string to avoid this.

thanks to Peter Chamberlin of LJCreate
merged from MOODLE_19_STABLE
2008-05-02 10:48:54 +00:00
scyrma
29cb9c5c8e MDL-11342: Urlencode the filepath in directory resource (merge from 1.9) 2008-05-02 08:18:11 +00:00