28171 Commits

Author SHA1 Message Date
sam marshall
dbc09f74e9 MDL-45242 Admin: User list supports custom profile fields 2021-03-10 10:57:11 +00:00
sam marshall
558cc1b85e MDL-45242 Lib: Replace calls to deprecated functions
In all cases changes have been kept to a minimum while not making
the code completely horrible. For example, there are many instances
where it would probably be better to rewrite a query entirely, but
I have not done that (in order to reduce the risk of changes).
2021-03-10 10:57:10 +00:00
sam marshall
3f003455f3 MDL-45242 Lib: Replace direct references to ->showuseridentity 2021-03-08 09:20:18 +00:00
sam marshall
60a1b159aa MDL-45242 Lib: Deprecate field-related library functions 2021-03-08 09:20:18 +00:00
sam marshall
677e1c6248 MDL-45242 Lib: Allow custom profile fields in showuseridentity 2021-03-08 09:20:18 +00:00
sam marshall
9ddb51b07e MDL-45242 Testing: Generators for user profile fields 2021-03-08 09:20:17 +00:00
sam marshall
e18b37c61d MDL-45242 Admin: Added lazy-loading callback to multicheckbox
Currently admin_setting_configselect has lazy-loading support via a
callback function (so you don't have to make pointless single-use
classes for each unusual setting), but this is not present in other
similar types.

This commit adds identical support to
admin_setting_configmulticheckbox.
2021-03-08 09:20:17 +00:00
Ilya Tregubov
eaf40e050e MDL-69680 lib: Replace deprecated jQuery functions 2021-03-04 12:48:26 +08:00
Ilya Tregubov
ec47946ea9 MDL-69680 lib: Update jQuery version in Moodle files 2021-03-04 12:48:26 +08:00
Ilya Tregubov
d00e53dd31 MDL-69680 lib: Upgrade jQuery lib to 3.5.1 2021-03-04 12:48:26 +08:00
Eloy Lafuente (stronk7)
8cf7878e18 Merge branch 'MDL-70424-auth-avoid-changes' of https://github.com/brendanheywood/moodle 2021-03-04 00:27:53 +01:00
Marina Glancy
9cfacff738 MDL-65552 user: escape idnumber and email in table_sql 2021-03-03 23:15:07 +08:00
Paul Holden
a7e0ba1e71 MDL-65552 user: escape idnumber field on output.
This commit also corrects parameter definition of the field to
match core_user.
2021-03-03 23:15:07 +08:00
Sara Arjona
01959703ba Merge branch 'MDL-70125_master-3' of git://github.com/mdjnelson/moodle 2021-03-03 15:47:16 +01:00
Sara Arjona
9d58d4de46 Merge branch 'MDL-67494-master' of git://github.com/lameze/moodle 2021-03-03 11:45:28 +01:00
Sara Arjona
535c0277de Merge branch 'MDL-67119-master' of git://github.com/aanabit/moodle 2021-03-03 11:11:29 +01:00
Jun Pataleta
572ec82454 Merge branch 'MDL-70987-master' of git://github.com/andrewnicols/moodle 2021-03-03 16:42:18 +08:00
Sara Arjona
187801ccf5 Merge branch 'MDL-70966-master' of git://github.com/marinaglancy/moodle 2021-03-03 09:30:41 +01:00
Simey Lameze
633a822f88 MDL-67494 calendar: user_delete_user should delete all user events 2021-03-03 16:06:32 +08:00
Simey Lameze
2dd31504b9 MDL-67494 calendar: set userid to zero for shared events 2021-03-03 16:06:32 +08:00
Simey Lameze
ba04a79ac6 MDL-67494 calendar: step to set userid 0 to all shared events 2021-03-03 16:06:32 +08:00
Andrew Nicols
3cda34adf2 Merge branch 'MDL-70268-master-2' of git://github.com/peterRd/moodle 2021-03-03 12:23:04 +08:00
Peter Dias
63cb8999ce MDL-70268 core: Update the oauthlib to exclude scope if none provided 2021-03-03 12:03:40 +08:00
Sander Wind
c9855a8b20 MDL-70668 auth: Fix secret validation during user confirmation
Co-authored-by: Michael Hawkins <michaelh@moodle.com>
2021-03-02 23:44:24 +01:00
Jun Pataleta
e86504fbcf Merge branch 'MDL-70457' of https://github.com/stronk7/moodle 2021-03-02 17:39:36 +08:00
Víctor Déniz
b1bbfbbbdb Merge branch 'MDL-70172-master' of git://github.com/rezaies/moodle 2021-03-02 09:16:41 +00:00
Sara Arjona
b64ee9ecf3 Merge branch 'MDL-70877' of https://github.com/stronk7/moodle 2021-03-02 09:29:17 +01:00
Jun Pataleta
2b113fd93c Merge branch 'MDL-70876' of https://github.com/stronk7/moodle 2021-03-02 16:02:52 +08:00
Eloy Lafuente (stronk7)
ece2fe5da1 Merge branch 'MDL-70899-master' of git://github.com/marinaglancy/moodle 2021-03-01 20:20:46 +01:00
Shamim Rezaie
612a1741f6 MDL-70172 output: pages with main logo should have a first-level header 2021-03-02 05:35:14 +11:00
Sara Arjona
f5bee1b704 Merge branch 'MDL-68735' of https://github.com/stronk7/moodle 2021-03-01 16:17:19 +01:00
Eloy Lafuente (stronk7)
76e5b1b59d Merge branch 'MDL-70913-master' of git://github.com/sarjona/moodle 2021-03-01 14:21:59 +01:00
Sara Arjona
9e5655b7c7 MDL-70913 core_badges: Use and update properly sortorder
Sortorder field in badge_external_backpack was updated with a wrong
value. This patch fixes this behaviour and adds sortorder as
sorting criteria for displaying the list of site backpacks.

In the phpunit method reviewed for covering this, a couple of
assertEquals() calls have been changed too to put the expected value
first.
2021-03-01 13:04:00 +01:00
Eloy Lafuente (stronk7)
b7d3e56d7e Merge branch 'MDL-70931-master-xmldbeol' of git://github.com/mudrd8mz/moodle 2021-03-01 10:00:27 +01:00
Eloy Lafuente (stronk7)
ac9b920981 Merge branch 'MDL-70964-master-enfix' of git://github.com/mudrd8mz/moodle 2021-03-01 09:33:49 +01:00
Marina Glancy
612c230709 MDL-70966 various: Under PHP8 empty string is no longer equals to 0 2021-02-28 19:16:09 +01:00
Eloy Lafuente (stronk7)
08ae245926 MDL-70876 php80: 5th param removed from custom error handlers
It was deprecated in php72 and now it's gone.

Have used this regexp to find all the uses in core:

ag set_error_handler | uniq

And then checked all them manually, that parameter was not
being used in the 3 methods where we are removing it.
2021-02-26 13:08:27 +01:00
Eloy Lafuente (stronk7)
0dea9a80c8 MDL-68735 env: Moodle 3.8.x, 3.9.x and 3.10.x do not support PHP 8.0 2021-02-26 13:07:59 +01:00
Marina Glancy
a7553de7ad MDL-70877 php: remove final functions __clone and __wakeup
Implementing these functions as final does not prevent the object to be
cloned or serialized, so the comment to them was wrong.
However having these functions not public breaks in PHP 8.0.
It still does not make sense to clone or serialise file_system or external_settings classes
but there are a lot of classes in moodle that should not be cloned, no reason to have
a specific solution here.
2021-02-26 13:07:52 +01:00
Eloy Lafuente (stronk7)
599567977f MDL-70457 forms: php74 fix for the (not used in core) date element
Curly brackets to access by index to strings or arrays is
deprecated since php74.
2021-02-26 11:55:24 +01:00
Amaia Anabitarte
3feafb1a4c MDL-67119 core_analytics: Analyse users once per course
User's activity in a course should be analysed only once
no matter the number of enrolments the user has in that course.
2021-02-26 11:50:16 +01:00
David Mudrák
0c9eaeff59 MDL-70964 lang: Use the fixed strings in tests 2021-02-25 16:20:58 +01:00
Jun Pataleta
2024a32283 Merge branch 'MDL-70169-master' of git://github.com/lameze/moodle 2021-02-25 12:30:22 +08:00
Eloy Lafuente (stronk7)
aa1c493a2a Merge branch 'MDL-70828-master' of git://github.com/abgreeve/moodle 2021-02-24 11:14:25 +01:00
Adrian Greeve
cb69d6389c MDL-70828 performance: Allow session locking issue to be turned off.
If a developer has debugging on then they will recieve all debugging
messages for locking whether wanted or not. We already have a setting
to display these messages.
2021-02-24 11:26:08 +08:00
Andrew Nicols
972e6ffe47 MDL-70987 core_form: Use correct id for elementid during validation
The id of the formid was being passed instead of the elementid.
2021-02-24 09:05:38 +08:00
Eloy Lafuente (stronk7)
6cf59943ca Merge branch 'MDL-52817' of git://github.com/paulholden/moodle 2021-02-23 19:07:56 +01:00
Eloy Lafuente (stronk7)
90f1c55191 MDL-70314 lib: Remove a few more hidden files and add instructions 2021-02-23 18:40:29 +01:00
Eloy Lafuente (stronk7)
e5c163a48b Merge branch 'MDL-70314' of https://github.com/Chocolate-lightning/moodle 2021-02-23 18:33:29 +01:00
Brendan Heywood
300213ee2e MDL-70424 auth: Avoid random changes to $CFG->auth 2021-02-23 11:40:57 +11:00