Squashed commit of the following:
commit 5881cccc95c135e1440ce0c5441a84b462941758
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Thu Aug 21 02:15:05 2014 +0100
MDL-46812 grade/report/grader: Reset previous commit for left scroller.
commit 5abeb60470f02ab4c79c27b2a6f6187e75891e0b
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Thu Aug 21 01:29:41 2014 +0100
MDL-46812 grade/report/grader: Added jsenabled css body class to rtl style.
commit a95d23d8b753a590d980e5427e8c74ba597c2b91
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Thu Aug 21 00:59:06 2014 +0100
MDL-46812 theme_base; Removed more redundent CSS.
commit 3fb326e5b39738343e0b7c0d9c8da17adf5a09bb
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Wed Aug 20 13:24:59 2014 +0100
MDL-46812 theme_base: Removed redundent grade/report/grader CSS in style/grade.css
commit c602e7e277f9ce1fed6d0eccf72c547432e130b6
Author: Mary Evans <lazydaisy@visible-expression.co.uk>
Date: Thu Aug 14 12:50:14 2014 +0100
MDL-46812 grade/report/grader: Need to tie up loose ends in Gradebook after MDL-43824
1. fixed gradebook layout when JS is disabled
2. added height and background color to scroller when JS is enabled
3. removed redundent top margin in user-grades table
This was a regression from MDL-46548.
I also added to the behat test to cover this, and sped up the behat test while I was there.
I also restored the behaviour where usercustomfields was hardcoded to true for all
export types except XML - but the default was false.
This makes the strings more descriptive and consistent.
AMOS START
MOV [eventreportviewed, gradereport_grader],[eventgradereportviewed, gradereport_grader]
MOV [eventreportviewed, gradereport_outcomes],[eventgradereportviewed, gradereport_outcomes]
MOV [eventreportviewed, gradereport_overview],[eventgradereportviewed, gradereport_overview]
MOV [eventreportviewed, gradereport_user],[eventgradereportviewed, gradereport_user]
AMOS END
The grader report table makes use of various user preferences, and strings
which on every iteration. On a large gradebook, this can have a significant
impact upon performance.
The table also uses html_writer::tag to generate spans for
machine-generated content which becomes expensive on larger gradebooks.
The code only needs the id column to perform its count. On courses with a lot of users
fetching the whole user record for them all easily adds up to several hundred MB of
memory.
Move the list of grade items to the top, and leave them expanded by default.
Move the idnumber warning into the grade items section, now it is visible by default.
This ui change requires changes to the API so I have deprecated the old functions while maintaining
compatibility (if you don't mind lots of debugging).
