391 Commits

Author SHA1 Message Date
Petr Skoda
48cbe43ded MDL-31213 fix incorrect modifications of quickforms attributes 2012-01-17 11:18:56 +01:00
Sam Hemelryk
6b37c2b093 MDL-31000 Added comment about the importance of repository array keys and hardened new dnd repository lookup 2012-01-10 12:21:24 +13:00
Davo Smith
f08fac7c89 MDL-29766 Add drag and drop upload to filemanager / filepicker elements 2012-01-09 17:27:32 +00:00
Sam Hemelryk
3b53b85b47 Merge branch 'w52_MDL-29917_m23_autocomplete' of git://github.com/skodak/moodle 2012-01-04 10:58:03 +13:00
Petr Skoda
6e9989dbd3 MDL-29917 prevent form autocompletion in most Moodle forms
The password autocompletion in case of Moodle makes sense only on the login page, the form autocompletion in general is most probably useful only on the user signup page.

This patch is compatible with html 5, unfortunately we have to ignore strict warnings in legacy xhtml 1.0 standard.
2011-12-30 14:38:52 +01:00
Tim Hunt
820b41e34f MDL-30168 formslib: untangle automatic id generation.
Previously, we had overridden the _generateId method in almost all
subclasses; and then we mostly, but not always; ignored the value that
was generated there, and instead generated new (nicer) values in
MoodleQuickForm_Renderer::renderElement. Of course, that is not really a
logical place to (re)generate ids.

I have fixed the code so that the _generateId method now uses the 'nice
id' algorithm from renderElement. This should make the whole code flow
more logical.

This make all our overriding of _generateId unnecessary.

We do need a special _generateId for radio buttons, because you often
have different radio buttons with the same name but different values.

This change should only change the ids on radio, checkbox and
advcheckbox elements. Previously, those were essentially random, so I
don't think anyone could have been relying on the particular values.

This commit also has new unit tests, first to test the basic _generateId
algorithm, and then to create and render an example form (including some
tricky things like repeat_elements) and chech the acutal ids in the
generated HTML.
2011-12-23 11:51:45 +00:00
Rossiani Wijaya
8367651ee4 MDL-29239 fixed edit course setting for moodle/course:changesummary permission is set to prevent. 2011-12-12 15:52:13 +08:00
Petr Skoda
b608b227ba MDL-27364 use https for recaptcha when site runs via https
Based on solution by Rajesh Taneja.
2011-12-06 12:00:32 +01:00
Tim Hunt
8f6384a9ec MDL-27045 formslib: fix disabledif for advcheckbox
This is based on earlier work by Henning Bostelmann and Tom Potts.
2011-11-17 17:57:27 +00:00
Sam Hemelryk
1ae9aa2b8f Merged MDL-29108 Advanced grading 2011-11-14 22:01:05 +13:00
Marina Glancy
3c2b3cb3ee MDL-29108: added comments, declared functions visibility, renamed variables; also fixed MDL-30240 2011-11-14 14:53:14 +08:00
Jason Fowler
483239087c MDL24200 - Admin Users - Changing the submit button to just a button to prevent it from taking focus when entering text. (Patch provided by Hubert Chathi) 2011-11-07 15:29:11 +08:00
David Mudrak
01609c9ad9 Merge remote branch 'origin/master' into rubric
Conflicts:
	lib/db/upgrade.php
	version.php
2011-10-24 22:13:01 +02:00
Marina Glancy
36937f0264 MDL-29483: advanced grading methods support on assignment module, grading form element, rubrics
- gradingform API now has not only controller class but also instance class with functions and data related to the particular grading instance
- assignment grading form and grading form element deal with elements of gradingform_instance class instead of gradingform_controller
- implemented the class gradingform_rubric_instance
- added more phpdocs
2011-10-20 12:15:51 +08:00
sam marshall
6282381d05 MDL-27242 Conditional availability dates should support time as well as day
Change also adds minor feature to date-time selector so you can specify the time it uses as default when the value is 0 (disabled).

Credit: This feature was developed collaboratively by Charles Fulton, Neill Magill, and me.
2011-10-13 10:23:23 +01:00
Marina Glancy
6798c63e20 Added form element grading and integrated it with grading_controller 2011-10-12 15:01:53 +08:00
Sam Hemelryk
66d216c574 Merge branch 'wip-mdl-25937-disableif' of git://github.com/rajeshtaneja/moodle 2011-10-04 15:52:57 +13:00
Rajesh Taneja
63d5c4ac85 MDL-25937 Forms Library: Filepicker will respect disable if 2011-10-03 16:26:21 +08:00
Rajesh Taneja
c6aa3670d0 MDL-25937 Froms Library: Added server side validation for filepicker and filemanager 2011-09-29 09:39:44 +08:00
Rajesh Taneja
856484f92f MDL-29539 HTML Editor: Fixed XHTML formatting for editor 2011-09-29 09:36:57 +08:00
Sam Hemelryk
fea98bd4c3 Merge branch 'MDL-29139' of git://github.com/nebgor/moodle 2011-09-26 10:46:39 +13:00
Eloy Lafuente (stronk7)
ac4a2a8c08 MDL-29512 Revert "MDL-25937 Froms Library: Added server side validation for filepicker and filemanager"
This reverts commit f03a17bb09bed83a29cda253c2049c937852dd38.
2011-09-25 17:13:40 +02:00
Eloy Lafuente (stronk7)
f0e2317087 MDL-29512 Revert "MDL-25937 Forms Library: Added Javascript validation for filepicker and filemanager. Also fixed disbledif rule check for both"
This reverts commit 7dfe3c517b8cf88356b1d1e208480b1a15452273.
2011-09-25 17:10:27 +02:00
Aparup Banerjee
bfc60f5d1b MDL-29139 Forms Library : fixed missing require_once 2011-09-22 14:57:11 +08:00
Colin Chambers
5a1a7112cd MDL-29394 form editor - Use hidden field when only 1 format option is available #947 2011-09-20 00:35:01 +02:00
Rajesh Taneja
7dfe3c517b MDL-25937 Forms Library: Added Javascript validation for filepicker and filemanager. Also fixed disbledif rule check for both 2011-09-16 09:17:20 +08:00
Rajesh Taneja
f03a17bb09 MDL-25937 Froms Library: Added server side validation for filepicker and filemanager 2011-09-16 09:17:19 +08:00
Rajesh Taneja
ab978b38c4 MDL-28987 Forms Library: Added tinyMCE onblur event callback for required tinymce fields 2011-09-05 12:19:40 +08:00
Rajesh Taneja
cbe20ec362 MDL-28987 Forms Library: Added tinyMCE save for tinymce editor validation 2011-08-31 14:13:35 +08:00
Adam Olley
567282021a MDL-28987: Affix [text] to editor element in JS validation and add blur event 2011-08-31 14:09:12 +08:00
Petr Skoda
0958759dc2 MDL-28554 workaround for http://yuilibrary.com/projects/yui3/ticket/2530999
Do not load io-xdr and io-upload-iframe on the same page.
2011-08-25 11:38:34 +02:00
Rajesh Taneja
3a70ccb8ac MDL-27837 enrol - Fixed checkboxes for multiple self enrolment 2011-07-14 09:55:13 +08:00
Jamie Pratt
5b5206e1cb MDL-28099 Fixed regression as outlined in tracker. 2011-06-30 14:34:10 +07:00
Jamie Pratt
b1eca34453 MDL-28099 fixes issue with filepicker and element names with index not passing
value for draftitemid.
2011-06-29 18:39:15 +07:00
Dongsheng Cai
f392caba15 MDL-26388, pop up a dialog when attaching a file already being used in draft area. 2011-05-02 10:11:19 +08:00
Eloy Lafuente (stronk7)
ff6b4cdb6d Merge branch 'MDL-26167-master' of git://github.com/agwells/moodle 2011-04-18 11:09:38 +02:00
Petr Skoda
bdc782470b Merge branch 'wip-MDL-27145-master' of git://github.com/samhemelryk/moodle 2011-04-17 16:11:49 +02:00
Aaron Wells
4b72f9eb78 MDL-26167 lib/form: Altering Javascript so that "disabledIf" will disable the "Choose" button for a filepicker 2011-04-15 09:59:46 +12:00
Sam Hemelryk
fec617dee5 form-dateselector MDL-27145 Fixed up error resulting from incorrectly required 'optional' argument on create event 2011-04-12 14:14:34 +08:00
Dongsheng Cai
6d30723e41 MDL-27098
1. Fixed add file language string
2. Fixed hard-coded 'moving' string
3. Fixed hard-coded 'Files' string
2011-04-11 17:09:15 +08:00
Rod Norfor
1e668c4d85 MDL-13983 show frozen radio buttons in a more accessible way. 2011-03-09 16:26:37 +00:00
Petr Skoda
431ac39634 MDL-26623 fix file permissions
The permissions are now going to be verified as part of the weekly release process.
2011-03-01 12:26:49 +01:00
Tim Hunt
057815f341 formslib editor NOBUG delete unused global file reference. 2010-11-11 18:33:11 +00:00
Dongsheng Cai
783f148609 MDL-24474, fixed warning message from filepicker element, fixed missing packageurl when adding new scorm instance 2010-10-21 04:46:05 +00:00
Petr Skoda
6ef1402e3d MDL-24650 xhtml strict fix in forms 2010-10-13 17:35:21 +00:00
Dongsheng Cai
1a79133b20 MDL-24375, fixed mulilt main files in filemanager 2010-10-06 04:17:21 +00:00
Dongsheng Cai
18e632593f MDL-24471, FILEMANAGER change <button> to <input type="button" />, moodle form may fire onclick event when enter pressed in other field 2010-10-04 04:09:02 +00:00
Dongsheng Cai
b817205bec MDL-24382, fixed display of file size limit in filepicker 2010-09-30 03:36:38 +00:00
Sam Hemelryk
e18d7d2fe8 mform-dateselector MDL-23829 Removed patch to fix YUI issue that was fixed in 3.2.0 2010-09-23 05:30:22 +00:00
Petr Skoda
6bdfef5da9 MDL-24321 switching to standard stdClass() 2010-09-21 08:54:01 +00:00