Commit Graph

5681 Commits

Author SHA1 Message Date
toyomoyo
ba1393b43f MDL-12180, blocks capabilities not appearing when overriding block roles 2007-11-15 07:46:04 +00:00
nicolasconnault
dea2f0d945 MDL-12182 Only testgradeitem.php isn't yet completed. 2007-11-15 06:44:26 +00:00
martinlanghoff
6fd511eb1c MDL-9399 moodlelib: set_config() deletes config entries if the value is NULL
New! Improved! If you pass NULL as the value, it will delete the
config entry for you.
2007-11-14 22:10:21 +00:00
martinlanghoff
8f9e1d2c4d accesslib: Move check_enrolment_plugins() to complete_user_login()
... where it belongs ;-)

load_all_capabiloties() gets called at several points where we don't
want to be re-querying the enrolment backends. It needs to  be called
before load_all_capabilities() and only by callers that are setting up
a logon session.

Those callers need to be calling complete_user_login() anyway, as they
need to set the Moodle cookie, log the logon action, etc. In fact,
those callers duplicate a lot of that code already.

The callers that don't duplicate code for the login are actually the
cases where the backend enrolment plugins should not be queried.

To be followed by callers cleanup...
2007-11-14 22:04:05 +00:00
martinlanghoff
a238e822a2 login/index, moodlelib: move session setup logic to complete_user_login()
Move most of the user session setup logic from login/index.php to
complete_user_login().
2007-11-14 22:03:46 +00:00
tjhunt
9cb69c1910 MDL-12172 - print_continue should create a method="get" button, not post. Merged from MOODLE_19_STABLE. 2007-11-14 16:34:26 +00:00
skodak
190af29fef MDL-12146 grade category defaults, forced settings and advanced options, merged from MOODLE_19_STABLE 2007-11-14 11:52:21 +00:00
toyomoyo
5e900da1ce removing duplicate entries in grade_grades prior to adding unique key 2007-11-14 05:07:33 +00:00
martinlanghoff
8c80cc1738 htmlarea: fix in FF - MDL-11242
The previous fix for IE left some problems in the FF side of
things because we were trying additions/substractions on
width once its had turned to a string of value + unit.

Do the math before we attach 'px' to it...
2007-11-14 01:25:20 +00:00
nicolasconnault
b7cf8eac52 Fixing a few bugs identified by Petr and attacking grade_item unit tests 2007-11-13 19:12:37 +00:00
skodak
717f432f2d MDL-12154 used proper cast to float before !== comparison merged from MOODLE_19_STABLE 2007-11-13 16:47:33 +00:00
skodak
4ac209d5bd MDL-12154 used proper cast to float before !== comparison 2007-11-13 16:08:39 +00:00
skodak
f1ad9e042a MDL-10901 new SUM aggregation type
MDL-12154 used proper cast to float before !== comparison

part 2
2007-11-13 15:32:16 +00:00
skodak
0758a08e2a MDL-10901 new SUM aggregation type
MDL-12154 used proper cast to float before !== comparison
2007-11-13 15:08:59 +00:00
nfreear
bc1bbaf477 MDL-12153, "Validome - moodle.org invalid - require Content-Script-Type". 2007-11-13 14:46:44 +00:00
nicolasconnault
9a68cffcbb Restoring some of the static calls which were converted unnecessarily 2007-11-13 13:44:27 +00:00
nicolasconnault
aaefeda438 More fine-tuning of gradebook classes 2007-11-13 10:31:08 +00:00
nicolasconnault
795bee3460 Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object). 2007-11-13 09:08:43 +00:00
skodak
cd1edf9e8a MDL-12101 cleanup/fixing/refactoring of user bulk operation and admin user browsing 2007-11-13 08:43:20 +00:00
nicolasconnault
4fc9ec1ec0 Managed to remove static calls from the core gradebook classes without removing support for such calls in gradebook interface code. I used a singleton pattern for this (get_instance in grade_object). 2007-11-13 07:36:00 +00:00
toyomoyo
cee037c660 MDL-12138, set aggregate graded only as default 2007-11-13 03:07:48 +00:00
skodak
a258f25619 MDL-12131 db debug messages now quoted properly 2007-11-12 17:21:00 +00:00
skodak
46f3921edd MDL-12130 and MDL-12129 - fixed advanced status of elements when header not closed; disableIf now works inside grouped elements too; code cleanup in focus() and _getElNamesRecursive() 2007-11-12 17:12:35 +00:00
nfreear
0dbb2191fb Fixes MDL-12125, Call to a member function FetchRow on a non-object in get_user_access_sitewide. 2007-11-12 16:53:53 +00:00
urs_hunkler
f7c926ee9f merged from 1.9 :: MDL-12093 2007-11-12 11:17:24 +00:00
martinlanghoff
755a625d95 htmlarea: Fix fullscreen editor on IE6/7 -- MDL-11242
Only say px if the width is a pure number. Under IE we
get the "100%" for the width of the editor, so blindly
appending "px" results in a JS execution error.

With this patch we only attach px if it's a pure int.

Also tested the sizing of HTMLArea in the messaging
window. So both should be working now.
2007-11-12 04:13:24 +00:00
urs_hunkler
60a94e79c3 merged from 1.9 :: added the clearfix option to the custom_corners call for admin pages to keep the "Save Changes" button within the area. 2007-11-11 17:30:52 +00:00
urs_hunkler
8e501a45f0 merged from 1.9 :: Added the check, if all opend custom_corners are closed. This way it's possible to add the close call in the footer which closes eventually open ccs. 2007-11-11 15:04:34 +00:00
urs_hunkler
ee9beb53bf merged from 1.9 :: MDL-12093 :: added function get_in_popup() 2007-11-10 14:53:54 +00:00
stronk7
23610d6ff7 Adding lang support within profile fields to make them selfcontained.
Merged from MOODLE_19_STABLE
2007-11-09 19:11:40 +00:00
skodak
1ee0df067f MDL-10365 grade history can be turned off + lifetime 2007-11-08 08:59:26 +00:00
toyomoyo
e4065e84e3 keeping version number in sync 2007-11-08 05:52:47 +00:00
nicolasconnault
a5b08715a7 MDL-9306 upgrade.php set to upgrade course whose format is weekscss to weeks 2007-11-08 05:43:15 +00:00
toyomoyo
4fa6cb4733 1.9 Beta 2 should not be read as 1.9.2 in environment page 2007-11-08 05:13:18 +00:00
toyomoyo
1dda50ea08 merged fix for MDL-11909, putting a unique constraint userid-itemid on grade_grades table 2007-11-08 02:01:34 +00:00
nicolasconnault
1f0e492171 Unit test refactoring using mock objects. NOT FINISHED: testgradecategory and testgradeitem are incomplete. The other tests work great however, and no longer a need for DB data 2007-11-07 17:59:33 +00:00
jmg324
bec52f19b5 fixes notice error caused in form validation of file attachments - need not assume variable is set but use empty() 2007-11-06 15:56:00 +00:00
nicolasconnault
1ce18c08d3 MDL-9306 Applied Ann's patches: seems to work very well, the output is entirely XHTML compliant, and displays really nicely. 2007-11-06 14:01:13 +00:00
skodak
e4e38544f8 MDL-11996 bulk user upload - improvements, bugfixes and cleanup;
new csv import library included ;-)
2007-11-05 00:43:37 +00:00
skodak
6d11d0ee0e MDL-12020 can not bulk delete users with the same email - new username collision 2007-11-04 13:51:26 +00:00
stronk7
5fab4931b4 Changed check_dir_exists() behaviour to be more robust
and to work better when used recursively under sites
with open_basedir enabled. Credit goes to René Samselnig. MDL-11437

Merged from MOODLE_19_STABLE
2007-11-02 09:53:32 +00:00
nicolasconnault
98a85772f5 MDL-11912 Creating 1000's layer directory first, then userid directory: no need for recursion 2007-11-01 08:45:30 +00:00
skodak
ced5ee5921 MDL-11966 implemented dategraded and datesubmitted, tweaked altering of grades depending in hidden grades
MDL-11974 improved gradebook CSS
2007-11-01 08:25:05 +00:00
nicolasconnault
a8caf69d3a Minor changes in unit tests 2007-10-31 14:55:23 +00:00
skodak
597f50e616 MDL-11973 Improved showing of hidden items in ouuser and user report 2007-10-30 21:25:50 +00:00
skodak
5966487712 MDL-11951 a little typo - no recursive call intended in has_any_capability() I guess 2007-10-30 20:51:37 +00:00
tjhunt
6c58e1985b MDL-6376 - fix minor errors in the previous commit.
More significantly, this patch changes the '1 Students have made 1 attempts' string.

To start with, this code was being produced in five different places, so I made a function to do the work!. Next, as you can see, it is not gramatical. Also, some people find it confusing, as in MDL-6376.

Therefore, it now just says 'Attempts: 1'.

Merged from MOODLE_19_STABLE.
2007-10-30 19:29:45 +00:00
sam_marshall
f63d29223e MDL-11916 Added managegroupevents capability 2007-10-30 16:19:47 +00:00
skodak
a677165290 fixing previous merge 2007-10-30 11:55:49 +00:00
skodak
0f392ff4f0 MDL-11957 improving and cleanup in grade overriding 2007-10-30 11:40:50 +00:00