Commit Graph

44 Commits

Author SHA1 Message Date
tjhunt
38e179a4ed MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.
This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.
2007-10-12 15:55:49 +00:00
stronk7
ea16f9b2dc Now the glossary->allowcoments setting is respected. MDL-8056
Credit goes to Matt Clarkson. Thanks.

Merged from MOODLE_18_STABLE
2007-07-15 22:27:16 +00:00
mattc-catalyst
01e3838853 MDL-9473: Initialise navlinks array before use
Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:55:24 +00:00
mattc-catalyst
3b27b0fe21 MDL-9615: Correct incorrect use of term breadcrumbs
- $crumbs -> $navlinks


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:40:48 +00:00
mattc-catalyst
70c6c0ad70 MDL-9474: Updated build_navigation() to use global $COURSE
- Removed $course parameter from build_navigation()
- Updated all calls to build_navigation()


Author: Matt Clarkson <mattc@catalyst.net.nz>
Committer: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-23 21:11:10 +00:00
mattc-catalyst
f3c8392617 Breadcrumbs: mod/glossary changes
- Modified to use build_navigation() for breadcrumb generation.


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-16 21:16:38 +00:00
stronk7
96e4104def Always print the entry when adding, updating/deleting comments. MDL-9047
Merged from MOODLE_18_STABLE
2007-03-26 23:02:35 +00:00
skodak
beac4717de MDL-8166 rename in/out methods in formslib - HQ consensus 2007-01-12 18:52:09 +00:00
jamiesensei
1d284fbd85 fixing all the form names as per new class naming convention (PHP class names are also used for html id for styling) 2006-12-28 15:43:47 +00:00
skodak
d73e265e9a added cancel button to glossary comment form and fixed initialization of button arrays MDL-7778 2006-12-05 09:44:11 +00:00
skodak
eebc919280 MDL-6940 - I decided to rewrite the glossary comments UI, the original code (pre 1.8) was not nice at all, it is IMHO more readable now and the forms implementation could be greatly simplified; this can also serve as sample trusttext implementation outside of forms code 2006-10-28 21:55:19 +00:00
jamiesensei
c3c5f0bd86 migrated comment.php over to using new formslib. 2006-10-26 07:59:22 +00:00
skodak
efa0eb1dcd improved validation when deleting comments from glossary SC#325 ; merged from MOODLE_17_STABLE 2006-10-18 20:21:28 +00:00
stronk7
0703d22ede One less reserved word. glossary->comment is out! 2006-09-04 20:37:27 +00:00
skodak
7d8a3cb06a trusttext:
* proposed by Martin Dougiamas
 * implemented by skodak

Usage:
1/ change enabletrusttext to yes in site settings (it is off by default) or set it in config.php
2/ assign moodle/site:trustcontent capability to users whose text submitted in glossary entries, comments, forum posts etc. should not be cleaned == they can use javascript or any other forbidden tags in glossary and forums...

done:
 * core
 * glossary (without proper upgrade)

to do:
 * data cleaning in upgrades
 * forum, blocks and some other places (MD decides)
2006-08-26 13:00:07 +00:00
moodler
0468976c9a SWEEPING CLEANUP
The API was changed slightly so that has_capability now takes the
whole $context object (we almost always have it anyway)

The $kill thing was removed.   If you want to assert a capability
then use:

    require_capability('capname', $context);

with optional variables to modify the error message

Misc bugs here and there also removed and code tidied
2006-08-14 05:55:40 +00:00
moodler
dabfd0ed85 Removed tabs 2006-08-09 13:45:49 +00:00
skodak
f9d5371b28 new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283 2006-08-08 22:09:55 +00:00
moodler
bbbf2d4015 ROLES AND PERMISSIONS - FIRST CHECK-IN
=======================================

WARNING:  DEV IS CURRENTLY VERY UNSTABLE.

This is a mega-checkin of the new Roles system.   A lot of changes have
been made in core and modules.

Currently there are a lot of rough edges and known problems.  We are
working hard on these .. .the reason for getting this into HEAD at this
stage is enable us to move faster (our branch was diverging from HEAD
too much).

Please keep an eye on http://docs.moodle.org/en/Roles for current status
and information for developers on how to use the new Roles system.
2006-08-08 05:13:06 +00:00
moodler
aa8139414e Replaced optional_var with optional_param 2005-12-07 06:21:58 +00:00
stronk7
7d34f1adab Now the entry being commented is showed when
adding comments for non-approved entries. Bug 3638.
(http://moodle.org/bugs/bug.php?op=show&bugid=3638)

Merged from MOODLE_15_STABLE
2005-06-26 09:34:10 +00:00
stronk7
5bd9aa933a Now glossary->name is working under filterall. It was really complex!
Just thinking about to add support for filterall inside:
   - category->name
   - concept->name
   - filter!
2005-03-30 11:14:19 +00:00
moodler
b8340d1938 Removal of THEME, added some classes, general tidy up. 2005-02-17 08:38:50 +00:00
gustav_delius
ec81373f50 In order to ensure that when a teacher hides a resource or an activity that students really can't get at it, even if they know the direct links to its pages, I have given an optional third argument $cm to the functions require_login() and require_course_login(). Pages showing information about a particular course module now pass the course module object in this third argument. The login functions will then test if either the course module is visible or the user is a teacher. If neither is the case then the user is redirected to the course homepage after being shown a message "Sorry, this activity is currently hidden".
(While I was at it I also turned the autologinguests off for most module pages, except on the index.php pages and the view.php pages for those modules that allow guests)
2005-02-16 10:40:48 +00:00
stronk7
1b4002e0b7 Just changing some parameters stuff to new functions...
See SC and Bug 1837

Merged from MOODLE_14_STABLE
2004-11-17 00:14:34 +00:00
gustav_delius
839f2456bb XHTML compliance
- fixed (hopefully) all <img> tags
- global replace on <br> to <br />
- &amp; in URLs
- got the forum module XHTML compliant
Julian Sedding
2004-09-16 17:13:57 +00:00
gustav_delius
41905731b7 fixed capitalization and quoting of attribute values 2004-09-12 16:24:41 +00:00
gustav_delius
a9ef4a630a closed <input /> <br /> <hr /> 2004-09-12 14:41:49 +00:00
stronk7
8a2fe40709 strip_tags() to some parameters. Thanks skodak.
Bug 1836
(http://moodle.org/bugs/bug.php?op=show&bugid=1836)

Merged from MOODLE_14_STABLE
2004-08-29 22:57:41 +00:00
stronk7
59c265b390 Now students cannot add/edit/delete entries if glossary->studentcanpost = 0
using manual URLs.

Merged from MOODLE_14_STABLE
2004-08-28 19:15:52 +00:00
stronk7
944d82d4d3 - students cannot add/edit/delete comments if it isn't allowed
- students can view comments if they exist
- teachers bypass the commentsallowed field always (this can be useful to create glossaries with public comments from the teacher).
- buttons are showed correctly.

Bug 1814
(http://moodle.org/bugs/bug.php?op=show&bugid=1814)

Merged from MOODLE_14_STABLE
2004-08-28 18:34:10 +00:00
stronk7
cf1ab7c300 Now action is checked and defaults to edit.
Thanks skodak!

Bug 1813
(http://moodle.org/bugs/bug.php?op=show&bugid=1813)

Merged from MOODLE_14_STABLE
2004-08-28 11:13:48 +00:00
stronk7
3a512f86c7 Some important changes arrive:
- 'editalways' applied to comments.
   - some minor notices out.
   - security bug solved:
      + users cannot edit any comment now.
      + users cannot delete any comment now.
      + users cannot edit any entry now.
      + users cannot delete any antry now.

Thanks to skodak, discovering the bug!!!

Merged from MOODLE_14_STABLE
2004-08-28 00:28:56 +00:00
stronk7
32ce883ee6 Don't clean posted text on input (will be cleaned on output).
Merged from MOODLE_14_STABLE
2004-08-24 22:59:54 +00:00
gustav_delius
90fcc576ea Removed notices by introducing new function print_header_simple() which works on site as well as in courses without extra logic. 2004-08-21 20:20:58 +00:00
moodler
7613890851 BRANCH MERGE
These are the changes from MOODLE_13_STABLE, merged into trunk

The tag MOODLE_13_MERGED on the MOODLE_13_STABLE branch now refers to this point

The biggest changes here are the fixes for HTML editor in all standard modules
2004-06-04 06:17:30 +00:00
stronk7
d3acd64d59 Little bug storing wrong comment->id in the info field
when performing the "delete comment" action. Now it works fine. :-)
2004-02-18 21:50:33 +00:00
stronk7
fabf55e684 Added the cmid field to some add_to_log() calls. To use it when
restoring logs. Now I think that everything is ready !! :-)
2004-02-18 20:52:44 +00:00
moodler
a61cf7e35e Hope you don't mind, Will, but I had to do some cleaning up of the comments pages
- comments look more like forums
   - glossary entry is displayed consistently
   - workflow makes more sense to me at least (more like forums)
   - code is shorter   :-)
2003-12-10 16:29:56 +00:00
willcast
1ac87c7397 - Rewrite of the internal API in order to, hopefully, create an easy way to handle the flow of data internally and externally.
- Adding a new frame: Browse by Author
- A new, friendly way to show entries (asked by Martin): view?id=cm&mode=term&hook=[concept | alias ]
- Handling user activies, outline and complete.
- Properly showing new entries in recent activity box.
- Adding a flag to categories to specify if a category should or should not be automatically linked.
- Adding some missing strings and files as well.
- Adding a field to each glossary that specify how many entries by pages it should show.
2003-11-15 15:55:47 +00:00
willcast
290891415d - Preventing guest for posting comments on entries 2003-10-21 18:32:36 +00:00
willcast
c76e673ab5 - Cleaning a lot of code in edit.php and view.php
- Removing more notices when debug is ON
- Added a new feature: Now the entries have a default approval status... Not approved entries are shown on a teachers-only frame from which they can be approved or not prior to be visible by everyone.
2003-10-21 04:55:22 +00:00
moodler
13152b970b Some tidying up of the code to display the comment editing page 2003-10-17 08:49:00 +00:00
willcast
ed0201dd7f - Now entries could be commented by other users.
- KNOWN BUG: It does not restore the comments even when userinfo is set... Eloy! I need your help! :)
2003-10-16 05:15:59 +00:00