Commit Graph

73 Commits

Author SHA1 Message Date
mark-nielsen
41d5033732 Mergin fix for MDL-11696 from MOODLE_19_STABLE 2007-10-13 02:36:08 +00:00
tjhunt
38e179a4ed MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.
This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.
2007-10-12 15:55:49 +00:00
mattc-catalyst
01e3838853 MDL-9473: Initialise navlinks array before use
Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:55:24 +00:00
mattc-catalyst
3b27b0fe21 MDL-9615: Correct incorrect use of term breadcrumbs
- $crumbs -> $navlinks


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:40:48 +00:00
mattc-catalyst
70c6c0ad70 MDL-9474: Updated build_navigation() to use global $COURSE
- Removed $course parameter from build_navigation()
- Updated all calls to build_navigation()


Author: Matt Clarkson <mattc@catalyst.net.nz>
Committer: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-23 21:11:10 +00:00
mattc-catalyst
f8513eca8d Breadcrumbs: mod/lesson changes
- Modified to use build_navigation() for breadcrumb generation.


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-16 21:20:20 +00:00
mark-nielsen
362f2ce973 Merging in fixes for MDL-8414 and MDL-9250 from MOODLE_18_STABLE 2007-04-08 21:02:16 +00:00
mark-nielsen
888f0c5460 Adding blocks to lesson
* added pagelib.php with lesson_page class definition
 * Lesson view now uses standard page layout classes
Other fixes:
 * minor fix to mod settings form
 * fixed function names (some were missing lesson_ prefix)
2007-03-24 23:07:59 +00:00
mark-nielsen
0ae3b5d334 Merging in fix for MDL-8196 2007-03-16 03:53:30 +00:00
mark-nielsen
ccfe8fddfe Merging in navigation to breadcrumb conversion fix for MDL-8843 2007-03-12 23:04:07 +00:00
mark-nielsen
18ec35d97b Merging in fix for MDL-8843 from MOODLE_18_STABLE 2007-03-12 03:38:06 +00:00
toyomoyo
76d4ec0095 replacing fieldsets in small forms to divs 2007-03-01 05:29:50 +00:00
vyshane
4085962ae9 xhtml fixes for MDL-7861. 2007-01-11 08:51:46 +00:00
skodak
0d905d9f34 MDL-7861 new class .icon and .iconsmall 2007-01-08 09:14:05 +00:00
skodak
fa73873105 MDL-8050 1.2 Remove all target="_top" - refactoring of previous commit 2007-01-04 18:23:55 +00:00
skodak
32f0b38a4a MDL-8049 Remove all language=Javascript from javascript includes 2007-01-03 19:33:44 +00:00
skodak
e25cb71041 MDL-8050 1.2 Remove all target="_top" 2007-01-03 19:24:48 +00:00
mark-nielsen
f521f98a22 modified some strings to add more meaning to buttons and links
left menu, clock and media file all display like blocks
some general code cleanup eg: went through several of the todo's in the code
2006-12-30 17:29:44 +00:00
toyomoyo
7ac95a7181 MDL-7861, fixing tags 2006-12-22 06:31:34 +00:00
toyomoyo
2ba9db3cd5 MDL-7861 fixng lesson xhtml tags 2006-12-20 02:17:13 +00:00
toyomoyo
37aa59a932 no need to use javascript for a submit button 2006-12-19 02:34:38 +00:00
toyomoyo
4cb35c1b95 MDL-7861, fixing xhtml for lesson. When in strict mode, javascript button is not working 2006-12-19 01:52:39 +00:00
toyomoyo
78d112679d MLD-7861, making moodle xhtml strict. There are still errors in lesson mod 2006-12-18 06:13:04 +00:00
skodak
1936c10e54 fixed obsoleted use of course->category to find site course - now used SITEID instead MDL-1899 2006-11-12 08:55:13 +00:00
mark-nielsen
5491947aa1 NO CODE CHANGES. Just added PHPdoc comments at the top of lesson files. 2006-09-30 19:49:40 +00:00
mark-nielsen
563106f0a8 Fixed branch table buttons to work with JavaScript turned off. This fix lead to some minor changes to the button output, but hopefully simplified things.
Also, removed .hidden-label class because it was no longer in use due to label fixes earlier.
2006-09-23 18:45:59 +00:00
mark-nielsen
b14123498f Saw several problems with lesson_choose_from_menu, so finally replaced its use with choose_from_menu in lib/weblib.php 2006-09-19 04:06:32 +00:00
mark-nielsen
62bb11d837 Added display default feedback in lesson settings
Led to reducing some redundant code in action/continue.php
Also, a bug fix in locallib.php for function lesson_print_submit_link (needed to add slashes or else js would break)
2006-09-18 01:31:35 +00:00
mark-nielsen
260a56b114 Added some more stats to reports, added more actions to collapsed view and increased speed of lesson by using lesson_set_message() and redirects with 0 second delays. 2006-09-13 03:42:16 +00:00
mark-nielsen
68a1e8fbba Started to rework the overall page editing interface for teachers. 2006-09-10 22:47:57 +00:00
mark-nielsen
c94d37997d Removed action set to navigation because view.php no longer uses action 2006-09-10 18:41:38 +00:00
mark-nielsen
5631925a26 Started to separate out logic and presentation in view.php. Decided to wrap the question printing with HTML templates (viewstart.html and viewend.html)
Still needs a lot of work
2006-09-10 18:19:29 +00:00
mark-nielsen
fb992d716a Started to reorganize view.php 2006-09-10 02:38:09 +00:00
mark-nielsen
15f3d44ae7 Moved teacherview (lesson editing) out of view.php into edit.php
No code improvements in edit.php as of now.  Just works ;)
2006-09-10 02:09:14 +00:00
mark-nielsen
d1b025d013 Moved high scores logic out of view.php into highscores.php
Changed: now need to enter password on password protected lessons before being able to view high scores
Added logs to high scores and reworked logic
2006-09-10 01:20:00 +00:00
mark-nielsen
2163c22634 Forgot the lesson_ prefix 2006-09-09 22:23:50 +00:00
mark-nielsen
2cb24b647c Improved clock output and works when javascript is disabled 2006-09-09 22:20:51 +00:00
mark-nielsen
259990d2c6 Lesson buttons should now work with javascript disabled
Also improved the layout of action/continue.html
2006-09-09 21:39:11 +00:00
mark-nielsen
f15eb92c2c Removed essay grading code from view.php into essay.php. 2006-09-09 01:58:48 +00:00
mark-nielsen
6e1ff5c8fb MDL-6477: Added roles support.
Also added lesson_set_message() and lesson_print_message() to locallib.php
Also fixed problem in continue.html with not printing nextpageid
2006-09-08 23:17:18 +00:00
mark-nielsen
9fcf51d9bf Added function for printing a standard header for lesson
Added function for fetching course module, course and lesson based on course module id or lesson id
2006-09-06 04:02:02 +00:00
mark-nielsen
c87a341cb9 Merged bug fix for bug MDL-6323 2006-08-25 22:53:17 +00:00
skodak
46341ab710 Bug #5732 - Lesson Scores &quot;out of XX&quot; marks report incorrect mark; merged from MOODLE_16_STABLE 2006-07-10 21:52:12 +00:00
mark-nielsen
88427c077b [Merged][BugFix] Bug #5405 - made a new function that grades a lesson for a specific user's attempt. This is then used for grading lessons at the end of a lesson, for ongoing score feature and for updating the grade for essay question grading.
This new grading algorithm now enforces the lesson setting Max attempts when custom scoring is turned Off

Changed the reporting of minquestions setting to match the help file.  Now it is question based instead of attempt based.

Changed the reporting of ongoing score to use the new grade function.
2006-05-19 01:05:13 +00:00
mark-nielsen
a1d0b3eb81 [BugFix] Bug 5505 - function lesson_print_tree now checks for teacher editing priv before printing editing icons. Had to change arguments for this function as well which is the edit in view.php.
lesson.php how checks for teacher editing priv for all actions except for continue.  This is just in case the user hacks the URL.
2006-05-15 19:14:22 +00:00
mark-nielsen
90455bb3ab [Fixed] Import. Updated code to work with /question instead of /mod/quiz. Lead to a few interal bug fixes. Also moved two hard coded strings to the lang file. 2006-03-26 00:10:39 +00:00
mark-nielsen
97d2756c65 [New Feature] Tabbed navigation added to lesson (similar to quiz)
[Added] Graceful fails added to view.php, essay grading, and reports
[Changed] got rid of a lot of references to $_POST/GET/REQUEST
[Fixed] In reports, it required teacheredit, should only be teacher
[Changed] High scores - teachers can actually see them!  Also, improved output by using print_table and print_heading
[Changed] Grade essays now uses fullname() to print user names
2006-03-25 21:38:57 +00:00
mark-nielsen
0646963948 [Changed] function execute_teacherwarning to function lesson_display_teacher_warning because it was violating the function naming policy 2006-03-17 03:37:31 +00:00
mark-nielsen
4b55d2aff2 [Added] added phpdoc comments to locallib.php 2006-03-17 03:31:19 +00:00
michaelpenne
acab90991a BUG FIX: progress bar now does not break when student reviews the lesson.
BUG FIX: matching question type upgrade script now supports quotes.

CHANGED: Improved labels for form elements to improve accessibility.

NEW: added a skip navigation link for left menu.
2005-11-16 22:35:46 +00:00