Commit Graph

134 Commits

Author SHA1 Message Date
tjhunt
2b3b36d0af Eliminate duplicate $Id$ tag. Merged from MOODLE_19_STABLE. 2007-11-07 12:35:33 +00:00
tjhunt
4f189a8e17 Fix possible notice. Merged from MOODLE_19_STABLE. 2007-10-16 20:52:28 +00:00
tjhunt
38e179a4ed MDL-11741 - Convert core modules to take advantage of recent improvements to build_navigation.
This check-in removes about 400 lines of code. I hope I have not screwed anything up. I would be grateful if people could review this change, and keep an eye on the navigation bar in modules.

Any navigation bar bugs you find in the near future, feel free to file them in the tracker and assign them to me. Thanks.

If not to many problems are found, I think I would like to backport this to 1.9 stable, but I am not sure that is a good idea. Opinions to the General Developer Forum please. I am about to start a thread there.
2007-10-12 15:55:49 +00:00
tjhunt
fba3ea31bc MDL-8682: Pressing enter when answering a short answer question can submit the wrong one. To fix this, I have disabled the enter key unless the keyboard focus is on a submit button (or inside a text box or HTML editor).
MDL-9451: Quiz answers can be lost if user navigates before page reloads. I am not totally sure I have fixed this, but I hope so. I moved the printing of the hidden form field with the list of questions on the page to the end of the form, so no answers will be processed unless the whole form loaded. Note that you could still lose data, but only if the page takes a really long time to load and you answer the first question and click submit before the whole quiz is loaded.

MDL-11463: The quiz uses two different timers, which is silly. I have removed the javascript that was ocasionally used to put a timer in the browser's title bar. Now we only use the one in the page for all cases.

Because MDL-8682 also needed javascript, I renamed timer.js to quiz.js so it could be a library of all the quiz's JavaScript, and started including it properly with require_js.
2007-09-26 18:15:31 +00:00
tjhunt
e63faf2b50 MDL-10376 - since roles and capabilities came along, the quiz was not very gracious if you were logged in as guest, or really logged in on the server, but using guest access to look a a particular course, or were enrolled in a course, but in a role that did not let you preview or attempt quizzes. This patch should clean up the logic for all these cases. 2007-09-20 15:14:24 +00:00
jamiesensei
9f877cb072 fix for MDL-10835 Results and Preview Tabs broken - requred param 'cmid' missing (for quiz with no questions) 2007-08-14 02:50:56 +00:00
tjhunt
d5ab1b0cf4 Minor tidyup. 2007-07-26 12:04:34 +00:00
tjhunt
8995ddda2a MDL-10619 - Quiz password form does not work. 2007-07-26 11:39:04 +00:00
tjhunt
ed8bebce5a MDL-10452 - start quiz UI is confusing if you have quiz:preview capability. Change the 'start/continue attempt button' to say 'start/continue preview' in this case. Merged from MOODLE_17_STABLE. 2007-07-13 15:58:42 +00:00
tjhunt
99a1bf3d9c MDL-10374 - Quiz layout improvements, selectively merged from OU-moodle. 2007-07-06 16:37:06 +00:00
mattc-catalyst
01e3838853 MDL-9473: Initialise navlinks array before use
Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:55:24 +00:00
mattc-catalyst
3b27b0fe21 MDL-9615: Correct incorrect use of term breadcrumbs
- $crumbs -> $navlinks


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-07-05 04:40:48 +00:00
tjhunt
ac48e43a89 MDL-648 - Email notification and confirmation when quizzes are submitted. Thanks to Graham Miller for implementing this to my design. 2007-06-26 16:34:05 +00:00
tjhunt
ccac7305ea Make a library function for deleting quiz attempts, rather than having duplicated code - Followup: make sure we only delete preview attempts. Merged from OU Moodle. 2007-06-23 10:39:28 +00:00
tjhunt
8165523992 Put information about which quiz and page in the URL for attempt.php, instead of in hidden form fields. Merged from OU Moodle.This makes things a little more robust in some situations, for example you can bookmark a page half way through a quiz attempt to make it easier to get back later. 2007-06-20 16:18:37 +00:00
tjhunt
ff51d64621 Make a library function for deleting quiz attempts, rather than having duplicated code. Merged from OU Moodle. 2007-06-18 16:19:00 +00:00
tjhunt
294e63eadd Make it possible for question types to do file uploads. 2007-06-15 11:02:47 +00:00
tjhunt
571da76788 MDL-6368 and MDL-6369 - supplimental - I missed one bit. 2007-04-27 11:18:08 +00:00
tjhunt
5df53d0082 * Fix layout problem on password form. (invisiblefieldset). * Question state fixes: + Don't change from EVENTOPEN too soon. + Make sure all questions get closed at the end of the attempt in adaptive mode. * Get rid of the delay on the redirect when you submit all and finish. 2007-04-25 15:45:24 +00:00
mattc-catalyst
70c6c0ad70 MDL-9474: Updated build_navigation() to use global $COURSE
- Removed $course parameter from build_navigation()
- Updated all calls to build_navigation()


Author: Matt Clarkson <mattc@catalyst.net.nz>
Committer: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-23 21:11:10 +00:00
mattc-catalyst
9ac0c1b328 Breadcrumbs: mod/quiz changes
- Modified to use build_navigation() for breadcrumb generation.
- Removed print_header method is now provided by base class.


Author: Matt Clarkson <mattc@catalyst.net.nz>
2007-04-16 21:23:17 +00:00
tjhunt
99ba746d29 MDL-6368 and MDL-6369 - allow question type plugins to easily provide some bits of Javascript and CSS.
If there are any of the files styles.css, styles.php, script.js or script.php in the plugin folder, they will be linked to in the head of the quiz attempt page (only for the question types used on that page).

If you need to do something more complicated in your question type, you can override the get_html_head_contributions method instead.
2007-04-12 15:58:32 +00:00
tjhunt
86ccf19cdb MDL-9280 - JavaScript countdown timer did not work in 1.8 due to XHTML strict changes. Also, fixing a few more XHTML strrrrict things in attempt.php. Merged from MOODLE_18_STABLE. 2007-04-11 20:07:36 +00:00
tjhunt
50d7b53ecb attempt.php refactor.
* Move all output code to the end.
 * Make comment style consistent.
 * Trim trailing whitespace from lines.
2007-04-10 14:27:56 +00:00
tjhunt
dc6c8ca1ac Minor cleanups to the quiz code. 2007-04-10 13:02:09 +00:00
tjhunt
46e910c7cd Fix notice. Merged from MOODLE_17_STABLE. 2007-03-30 09:34:05 +00:00
tjhunt
fb708c1130 MDL-6269, MDL-8958, MDL-8990 - Major fix to do with each attempt builds on last:
It used not to work with random questions, and there were problems with the computation of the grade, and regrading. Fix thanks to Paulo Matos, who not only fixed the bug and tested it, but was also incredibly patient waiting for me to have time to commit the changes to CVS.

Merged from MOODLE_17_STABLE.
2007-03-29 16:36:16 +00:00
tjhunt
a6b691d84d Add developer debugging to something that should not happen, and fix one instance of it. 2007-03-29 16:05:55 +00:00
toyomoyo
e5c158bbbd fixing javascript error in MDL-8652 2007-03-01 05:47:57 +00:00
tjhunt
645dff1cf7 Correct logic for stopping people using guest access from doing quizzes. Merged from MOODLE_18_STABLE. 2007-02-28 11:34:50 +00:00
toyomoyo
5328c274d5 merged fix for MDL-8686, MDL-8576, replacing <fieldset> with <div> for display issues 2007-02-28 04:58:48 +00:00
vyshane
0927589412 Xhtml fixes for MDL-7861. 2007-01-09 09:07:16 +00:00
skodak
b7dc225654 MDL-8062 1.3 Remove name attribute from <form> and fix focus everywhere - more changes ahead 2007-01-04 21:32:36 +00:00
moodler
f4ba7e1a54 Bend over for XHTML 1.0 Strict ... MDL-8049
Removed Javascript language attribute tags and added CDATA
2007-01-03 14:44:17 +00:00
skodak
b708f1bf47 MDL-7631 Incorrect grading when Each attempt builds on the last and questions on more than one page 2006-11-26 23:00:28 +00:00
toyomoyo
4c2275d557 fix for MDL-7395, adding capaiblity mod/quiz:ignoretimelimits for quiz takers with disability. 2006-11-23 07:52:54 +00:00
tjhunt
40cc892b6a Fix bug with getting the capability. 2006-09-20 16:17:27 +00:00
toyomoyo
4f83ae95ca adding capabilities 2006-08-31 08:51:09 +00:00
tjhunt
a4a6eb8a17 Fix toyomoyo's syntax errors. 2006-08-22 13:12:24 +00:00
toyomoyo
5cf38a57cd some quiz capabilities 2006-08-22 09:04:23 +00:00
moodler
dabfd0ed85 Removed tabs 2006-08-09 13:45:49 +00:00
skodak
f9d5371b28 new function get_coursemodule_from_id() is now used for obtaining of valid $cm from coursemodule id SC#283 2006-08-08 22:09:55 +00:00
tjhunt
00c300692f Fix whitespace. 2006-08-04 16:47:57 +00:00
tjhunt
00aeaec820 Bug 6019: Quiz timer does not submit the form when it reaches zero. Merged from MOODLE_16_STABLE. 2006-07-05 10:43:53 +00:00
tjhunt
7d83bbc2bd Bug #5506: Fix for calculated questions where each one builds on the last. Merged from MOODLE_16_STABLE. 2006-06-06 14:29:05 +00:00
skodak
5e205b74dd fixed bug #5562 I hope; merged from MOODLE_16_STABLE 2006-05-24 18:56:33 +00:00
gustav_delius
91d7ead073 Answers to essay questions are now saved correctly when navigating to another page, fixing bug 4478 2006-05-15 20:42:14 +00:00
gustav_delius
2e8973e779 Teachers now can preview timelimited quizzes even after the closing date 2006-04-11 21:49:43 +00:00
urs_hunkler
d975f343ba replaced DEPRECATED center tag with a div. introduced a new class=mdl-align with the CSS text-align: center 2006-04-07 16:17:17 +00:00
gustav_delius
9c7c8d63f4 Prevent student from seeing quiz when closed, bug 5070 2006-04-05 09:43:29 +00:00