25243 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7)
b702dbf6dd MDL-63422 lib: lessphp - review core loop / switch / case / continue 2018-10-31 00:17:59 +01:00
Eloy Lafuente (stronk7)
77331aed27 MDL-63422 lib: horde - review core loop / switch / case / continue 2018-10-31 00:17:59 +01:00
Eloy Lafuente (stronk7)
ed24d21b78 MDL-63422 lib: tcpdf - review core loop / switch / case / continue 2018-10-31 00:17:59 +01:00
Eloy Lafuente (stronk7)
bd5fdcfccd MDL-63422 general: review core loop / switch / case / continue
This commit reviews all continue uses in core happening within a
loop / switch / case hierarchy. This does not cover:

- Changes to libraries. Will be handled in another issue / commit.
- Uses out from loops, will be reviewed by other commit.

The policy followed has been:
- When possible, take rid of the continue.
- When clearly the intention was to jump to next element in loop
  change to continue 2
- When it was not clear, keep old behavior switching to break, no
  matter how weird the behavior may be.
2018-10-31 00:17:59 +01:00
Andrew Nicols
1ac8ae517d Merge branch 'MDL-63742-master' of git://github.com/jleyva/moodle 2018-10-30 07:46:00 +08:00
Adam Olley
edd51eb245 MDL-63811 phpunit: Fix typo in new allowed config variable
Without this, phpunit doesn't allow the pathtophp unit config setting to be set
in config.php as intended.
2018-10-30 09:15:59 +10:30
David Monllao
77ac4d8c31 Merge branch 'MDL-63445-master' of git://github.com/bmbrands/moodle 2018-10-29 16:47:45 +01:00
Tim Hunt
616442a2fa MDL-63738 question bank: a link to download a single question 2018-10-29 10:38:24 +00:00
Juan Leyva
6f79370531 MDL-63742 auth: New WS core_auth_resend_confirmation_email 2018-10-29 11:04:02 +01:00
David Monllao
4bd78d79a8 Merge branch 'MDL-63040-master' of git://github.com/peterRd/moodle 2018-10-29 10:42:51 +01:00
Peter
7dcb274c9e MDL-63457 block_myoverview: Update getters for enrolled courses
* Update the enrol courses getter to accept an 'exclude course' id array
* Use the db query to filter hidden courses
2018-10-29 08:36:59 +08:00
Bas Brands
fd68f5a9e0 MDL-63457 block_myoverview: Rerender the paged content and jump
Jump to the page the user was last on after hiding
2018-10-29 08:36:59 +08:00
Andrew Nicols
d4274bd951 Merge branch 'MDL-60520_master' of git://github.com/dmonllao/moodle 2018-10-29 07:39:58 +08:00
Andrew Nicols
74138e927c Revert "MDL-63466 core_message: rename cache for last message time"
This reverts commit f978593d6c3b98db5b3feb29448a642b4f540edc.
2018-10-26 14:54:01 +08:00
Andrew Nicols
4699b8bc41 Revert "MDL-63466 core_message: removed get_last_message_time_created_cache_key"
This reverts commit 4f22d7f23b022c143910a9a136fecbd325dce356.
2018-10-26 14:53:58 +08:00
Andrew Nicols
621e7eb022 Merge branch 'MDL-63466-master' of https://github.com/snake/moodle 2018-10-26 12:33:13 +08:00
Andrew Nicols
79b5095f28 Merge branch 'MDL-63280_master-fix' of git://github.com/markn86/moodle 2018-10-26 09:07:30 +08:00
Mark Nelson
06cdb82d23 MDL-63280 core: correct index on upgrade vs install 2018-10-26 08:52:27 +08:00
Andrew Nicols
56076d5991 Merge branch 'MDL-63280_master' of git://github.com/markn86/moodle 2018-10-26 07:49:13 +08:00
Mark Nelson
76540bec52 MDL-63280 core: removed 'message_conversation_area' table
These new fields have been added to the 'message_conversations'
table.
2018-10-25 18:05:20 +08:00
Mark Nelson
f0e137c539 MDL-63280 core: minor changes after review
- Fixed reference to non-existent column 'timeread'.
- Fixed alignment issues.
- Fixed inconsistencies between upgrade.php and install.xml.
- Cleaned unit tests of unnecessary DB calls.
- Renamed 'get_does_conversation_area_enabled' to
  'is_conversation_area_enabled' and moved to api.php.
- Replaced "$mform->elementExists('enablemessaging')"
  check with a capability check.
- Removed the change of [] to array() in unrelated to upgrade code.
- Updated conversation 'timemodified' field when updating name.
- Bumped version based on latest master.
2018-10-25 17:51:04 +08:00
Jun Pataleta
35b76161b3 Merge branch 'MDL-60514-master-new-cron-execution' of https://github.com/tonibarbera/moodle 2018-10-25 15:06:47 +08:00
Andrew Nicols
c3d1878ff3 Merge branch 'MDL-63655' of git://github.com/stronk7/moodle 2018-10-25 14:53:18 +08:00
Toni Barberà Melià
c759ae5d55 MDL-60514 tasks: added new config parameter. changes in cron execution 2018-10-25 08:02:44 +02:00
cescobedo
55fda006e3 MDL-63280 core_message: Create conversation area 2018-10-25 12:20:00 +08:00
Andrew Nicols
2263bbdfce Merge branch 'MDL-63058-master' of git://github.com/bmbrands/moodle 2018-10-25 11:49:45 +08:00
Nick Phillips
2070142f46 MDL-63763 javascript: don't have define( in AMD comments at top of files 2018-10-25 16:21:35 +13:00
Eloy Lafuente (stronk7)
3d18697115 Merge branch 'MDL-63153_master' of https://github.com/aanabit/moodle 2018-10-25 01:11:36 +02:00
Eloy Lafuente (stronk7)
19dbce00a1 Merge branch 'MDL-63714-master' of git://github.com/andrewnicols/moodle 2018-10-25 00:10:45 +02:00
Andrew Nicols
eb514bb3e5 MDL-63714 javascript: Add new core/pending module 2018-10-24 12:49:09 +08:00
Andrew Nicols
66de50c366 Merge branch 'wip-MDL-62411-master' of https://github.com/timhunt/moodle 2018-10-24 10:21:42 +08:00
Mark Nelson
4f22d7f23b MDL-63466 core_message: removed get_last_message_time_created_cache_key 2018-10-24 09:39:59 +08:00
Mark Nelson
f978593d6c MDL-63466 core_message: rename cache for last message time 2018-10-24 09:39:42 +08:00
Sara Arjona
fb04293bb1 MDL-63466 core_message: Add conversation support to get_messages
- The get_conversation_messages has been added to the API and the WS
with the conversation identifier (convid) instead of the userto,
to let get conversation messages and the members involved.
- The cache has been also reviewed, to use the convid instead of the
[userfrom, userto] keys.
- The get_most_recent_conversation_messages has been added to the API
to update the cache when needed.
2018-10-24 09:39:05 +08:00
Sara Arjona
ecf7567a89 MDL-63466 core_message: Add conversationid to message class 2018-10-24 09:38:01 +08:00
Andrew Nicols
4b7ad8845c MDL-63714 core: Wrap doRender in pendingjs 2018-10-24 08:12:10 +08:00
Andrew Nicols
dc39d0cf39 MDL-63714 javascript: Improve docs for pendingjs 2018-10-24 08:00:00 +08:00
Damyon Wiese
a3d57af872 MDL-62139 output: Revert template changes
Revert accessibility changes for menus in standard themes.
2018-10-23 10:14:19 +02:00
Bas Brands
a7712a9851 MDL-63445 core_renderer: display course image in context header 2018-10-23 09:41:26 +02:00
Andrew Nicols
6a91cc80c9 MDL-63535 core_rss: Coding style fix 2018-10-23 11:15:04 +08:00
Andrew Nicols
e186fb407e Merge branch 'MDL-63535-master' of git://github.com/mihailges/moodle 2018-10-23 11:11:22 +08:00
Mihail Geshoski
c61132c6bf MDL-63535 core_userkey: Add method that returns users in context
This issue is part of the MDL-62560 Epic.
2018-10-23 10:46:25 +08:00
Andrew Nicols
0ff384dbf1 Merge branch 'MDL-63548_master' of git://github.com/markn86/moodle 2018-10-23 10:25:54 +08:00
Andrew Nicols
34fa5ec414 Merge branch 'MDL-63713-master' of git://github.com/rezaies/moodle 2018-10-23 10:08:32 +08:00
Mark Nelson
09ec501781 MDL-63548 core_message: added mark_all_conversation_messages_as_read WS 2018-10-23 09:52:43 +08:00
Mark Nelson
e4c3099444 MDL-63548 core_message: deprecated mark_all_messages_as_read web service 2018-10-23 09:52:05 +08:00
Shamim Rezaie
c37407ba9d MDL-63713 core: Support for removal of context users
This issue is part of the MDL-62560 Epic.
2018-10-23 11:55:49 +11:00
David Monllao
64a00dffbd Merge branch 'MDL-61388-master' of git://github.com/damyon/moodle 2018-10-22 16:48:56 +02:00
David Monllao
7e5f0fa66a Merge branch 'MDL-62144-master' of git://github.com/damyon/moodle 2018-10-22 16:33:17 +02:00
David Monllao
d10643fbe6 Merge branch 'MDL-63625-master' of git://github.com/marinaglancy/moodle 2018-10-22 14:41:12 +02:00