66 Commits

Author SHA1 Message Date
Petr Skoda
a685593466 MDL-21233 moodle_url improvemewnts, code simplification, more diagnostics; fixed several regressions 2010-01-16 15:39:56 +00:00
Petr Skoda
78946b9bdb MDL-20204 first batch of major theme changes, some regressions are still there, expect more changes and improvements soon; see tracker for details and list of subtasks 2009-12-16 18:00:58 +00:00
Petr Skoda
49ab5e1950 MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 15:32:33 +00:00
samhemelryk
474f6bfed9 core MDL-19799 Added set_url calls and replaced deprecated functions 2009-10-15 03:43:28 +00:00
samhemelryk
70f25518ad core MDL-19799 Updated print_header and build_navigation to OUTPUT and PAGE equivalents 2009-09-07 07:20:14 +00:00
nicolasconnault
aa9a686740 MDL-19799 Upgraded calls to helpbutton, print_simple_box* and notify 2009-08-18 05:20:12 +00:00
skodak
aa54ed7b02 MDL-20065 new implementation of File module, modules sub-types are being migrated to separate modules; remaining issues to be listed as sub-tasks in tracker 2009-08-13 20:45:50 +00:00
nicolasconnault
7e0d66753e MDL-19799 Converted all print_footer() calls 2009-08-06 14:21:34 +00:00
nicolasconnault
5231a15c0f MDL-19799 Migrated calls to close_window_button() 2009-08-06 02:52:39 +00:00
nicolasconnault
f8065dd287 MDL-19756 Migrated the following functions from weblib to outputlib:
1. button_to_popup_window
2. link_to_popup_window
3. print_single_button
4. print_spacer
5. print_file_picture (deprecated)
6. print_user_picture
7. print_png (deprecated)
8. helpbutton
9. doclink
10. print_paging_bar
11. notice_yesno
2009-07-27 10:33:00 +00:00
tjhunt
151165e3d1 Fix some fallout from the pagelib changes. 2009-06-12 12:08:25 +00:00
tjhunt
e79079deae help.php: related to MDL-13816. Clean up the URLs used for help files by removing unused parameters. 2009-03-30 06:11:32 +00:00
tjhunt
bb45fe62c4 get_string: Refactoring, performance improvements, bug fixes and unit tests
MDL-18669 get_string refactored to elimiate duplicate code and make it easier to understand.
MDL-17763 parent language not processed correctly when getting a plugin string.
MDL-16181 more intelligent caching to avoid repeated file_exists checks.
MDL-12434 move values to array keys to improve lookup times.

The main part of the refactoring is to create a singleton string_manager class to encapsulate the cached data and the processing, while breaking the code up into more smaller methods.

Other performance improvements include:
* Cache results of plugin name -> locations to search array.
* Cache parent lang lookup.
* Skip eval if the string does not contain $ \ or %.
* Remove the unnecessary sprintf from the eval.

There is a performance testing script in lib/simpletest/getstringperformancetester.php. For now this script has the old get_string implementation copied and pasted to the end, and renamed to old_get_string to allow for comparitive timings.

There are now some unit tests for get_string in lib/simpletest/teststringmanager.php. I think I have managed to cover most of the tricky cases.
2009-03-30 02:21:27 +00:00
mudrd8mz
9dc1fb4dde MDL-14743 offer a link to the English help file. Merged from 1.9 stable 2009-03-02 14:14:19 +00:00
tjhunt
8bc590f5df qtypes help: MDL-5106 Create questiontype help file dynamically 2009-02-26 07:07:40 +00:00
tjhunt
740939ec61 MDL-16654 Move javascript used by the emoticons help file from javascript.php to javascript-static.js. Fix it so that it actually works. 2008-09-25 10:07:11 +00:00
jerome
d81f018f3a MDL-11461 all ressource types are now displayed in the ressource help popup, merged from 1.9 2008-06-17 02:00:54 +00:00
skodak
f33e1ed4ae MDL-14679 ok, here is the big patch with new dmllib and ddlib API, some code is already converted, XML db editor works; see tracker for details of regressions and TODOs 2008-05-15 21:40:00 +00:00
dongsheng
b8b3d87c2c "MDL13233, fix unclosed li elements, and remove extra <html> tags, see tracker" 2008-05-01 02:46:09 +00:00
dongsheng
01260c78fa "MDL-13233, make emoticons documentation should be dynamic" 2008-04-30 03:49:12 +00:00
sam_marshall
facc7b387f MDL-14286: Help popup now includes title of help page in window <title> 2008-04-10 11:50:52 +00:00
dongsheng
5a2a53316f MDL-14129, remove all the other error() call 2008-04-04 02:54:20 +00:00
nicolasconnault
072901a9eb MDL-13789 Fixed the index file issue (with a hack) and also documented extra credits properly. 2008-03-21 15:05:51 +00:00
mudrd8mz
45f5cfd4bf MDL-12291 help.php is now able to skip _local langpacks. Merged from MOODLE_19_STABLE 2008-01-19 22:00:39 +00:00
tjhunt
dba21d4a19 Use the locale to sort the list of activites everywhere. This matches a change a made in one place before christmas. If you don't do this, the PHP sorts by ASCII order, so mixed case names, or special characters, get sorted wrongly. Merged from MOODLE_19_STABLE. 2008-01-07 16:46:35 +00:00
nicolasconnault
3b84c6bd05 MDL-8853 Applied Ann's patch 2007-11-06 13:39:42 +00:00
nfreear
73418a3ce3 Big fix for MDL-9890 "Help should be well-formed, XHTML Strict and semantic". 2007-05-23 12:03:22 +00:00
tjhunt
6cad9e6069 MDL-8772 - Use the same list of places to search in get_string and help.php. Merged from MOODLE_18_STABLE. 2007-03-14 20:15:20 +00:00
mudrd8mz
2f40b60145 _local language packs take precedence with both forced language and non-forced language settings.
Fixes reopened MDL-8089.
2007-02-10 21:54:19 +00:00
dwoolhead
20cc8f6066 MDL-7442 Changed search order for help files to be more consistent with language files (backwards compatible) 2007-01-12 12:29:42 +00:00
mudrd8mz
f35a69cfca Help files stored in _local language packs take precedence. Implements MDL-8089. 2007-01-08 09:04:08 +00:00
moodler
7475775d4a XHTML Strict fixes MDL-7861 2007-01-05 16:16:21 +00:00
skodak
868ca14f1f fixed trailing whitespace in last commit :-(; merged from MOODLE_16_STABLE 2006-08-22 22:12:17 +00:00
skodak
6be7abc726 Rewritten help.php by Tim Hunt with minor fixes - SC#292; merged from MOODLE_16_STABLE 2006-08-22 22:04:06 +00:00
skodak
508d4a0d14 adding proper checks that the requested help file exists SC#292; merged from MOODLE_16_STABLE 2006-08-14 20:08:52 +00:00
skodak
496d06443a better cleaning of $file parameter SC#276; merged from MOODLE_16_STABLE 2006-07-11 13:19:52 +00:00
moodler
8634bc275d Fixed bug 5300 and removed moodle docs link from help pages 2006-04-24 01:58:31 +00:00
vyshane
c05181937a Added $forcelang optional parameter. This is useful if we want to get help.php
to display the help content in a language irrespective of the site language
settings. This is needed for /admin/helpdoc.php script. This view requires
previews for:

1) en_utf8
2) the current language the site is set to

Without the change to /help.php, 1) is not possible.
2006-03-22 03:16:27 +00:00
toyomoyo
f344731398 fix for 4758 2006-02-20 01:30:30 +00:00
toyomoyo
9214c22430 fix for 4758 2006-02-15 01:55:04 +00:00
moodler
6db498061f Fixed bug #4536 : error in optional_param 2006-01-09 01:55:42 +00:00
moodler
fc64d5cf2c Merged param fixes from stable, even though they were already here :-) 2005-12-05 04:23:50 +00:00
gustav_delius
b1c9e0998a Allow underscore and hypen in module names 2005-09-25 20:46:43 +00:00
thepurpleblob
ad644234b1 Replaced optional_variable() instances with secure alternatives. 2005-06-10 19:19:08 +00:00
moodler
1c2999bcd1 New documentation for new assignment types 2005-04-18 09:30:45 +00:00
gustav_delius
68396ed91f If help file is not found in language directory then look in language subdirectory of module directory. 2005-04-10 05:08:31 +00:00
moodler
6bc21ecf93 Close footer properly 2005-03-27 05:44:31 +00:00
dhawes
822a106319 Added a file level phpdoc docblock tag. Also converted double quote strings to single quote literals. 2004-09-29 18:19:39 +00:00
moodler
6da4b2618f The resource types are now always displayed in a standard order
no matter what the language.
2004-08-02 19:11:15 +00:00
moodler
32a4f1f160 Merged XSS bug fix from stable 2004-07-13 03:51:05 +00:00