Shamim Rezaie
0897d6588e
MDL-60188 groups: cache user's groups and groupings
...
The function groups_get_user_groups is called too often both before rendering the page and after the page is rendered (using ajax).
The function was executing a query joining 3 tables in each call. The plementation of the function has now modified to store the
query result in a request cache.
2017-11-27 10:46:35 +08:00
Ryan Wyllie
d6942fb5ba
MDL-59382 calendar: fix CiBoT warnings
2017-08-03 01:07:01 +00:00
Simey Lameze
705eea84d1
MDL-59382 core: make CiBoT happy.
2017-08-02 07:52:20 +00:00
Ryan Wyllie
aa0912258d
MDL-59382 calendar: add modal to create and update events
2017-08-02 04:47:43 +00:00
Damyon Wiese
f746a078cb
MDL-59368 groups: Postgres fix
...
Postgres is strict about mixing types.
2017-07-12 10:07:58 +08:00
Damyon Wiese
76c493b3f2
MDL-59368 groups: Add behat for new group edit
2017-07-12 10:07:58 +08:00
Damyon Wiese
2fa35b8d16
MDL-59368 groups: Inplace editing for users groups
2017-07-12 10:07:57 +08:00
Juan Leyva
8c60d198c2
MDL-57411 groups: Fix tests for MSSQL
2017-04-05 13:17:46 +02:00
Juan Leyva
a7d9c5373e
MDL-57411 groups: New helper functions
...
- groups_get_groups_members
- groups_get_activity_shared_group_members
2017-03-31 09:04:58 +02:00
John Beedell
905953909f
MDL-31243 access/enrol libs: rename new groups functions
2016-09-30 09:27:59 +01:00
John Beedell
9121bb2d23
MDL-31243 access/enrol libs: new fns returning useful SQL fragments
...
Refactor similar SQL generation code from get_users_by_capability
and get_enrolled_uses to make get_with_capability_sql.
Modified files: accesslib.php, enrollib.php, grouplib.php, new tests.
2016-09-30 09:27:56 +01:00
Juan Leyva
c616c5f145
MDL-49314 groups: New API function groups_user_groups_visible
2015-04-01 10:19:26 +02:00
Jason Platts
a75a381f04
MDL-48437 Make Visible/All groups selector show own groups first
2015-02-18 09:32:23 +00:00
sam marshall
061e6b2864
MDL-44725 Availability: Replace groupmembersonly - upgrade, core (1)
...
* Upgrades existing data so that the groupmembersonly option is
replaced with equivalent data for the new availability API.
* Removes the database field and admin setting used for
groupmembersonly.
* Changes core modinfo library to remove/deprecate groupmembersonly
data and functions.
* Changes other core library files to remove groupmembersonly
references.
Includes deprecation of several functions, listed in lib/upgrade.txt.
2014-09-02 13:03:07 +01:00
Ruslan Kabalin
dfaedf0854
MDL-46833 mod_assign: Fix assignment view when available for group members only.
...
When assignment is "Available for group members only" and no users with
mod/assign:submit role permision is enrolled (students),
groups_filter_users_by_course_module_visible is causing error (as $users
array is empty). The patch resolves the issue.
2014-08-14 16:06:08 +01:00
Marina Glancy
92e2e85523
MDL-44720 modinfo: make it easier to use cm_info instead of get_coursemodule_from_id
...
by adding function cm_info::get_course_module_record()
2014-03-27 11:24:00 +08:00
Damyon Wiese
c46db93c28
MDL-43721 Assign + groups: Improve performance of assign grading table
...
Add a function to the groups lib to filter a list of users down
to the ones who can see the module. Required because calling
groups_course_module_visible() for a list of users is too slow
and we shouldn't spread group logic outside of grouplib.php.
Using it in the assign grading table reduces DB queries from 6198/1 to 256/3.
This is 12secs down to 2.5secs.
2014-03-06 15:50:13 +08:00
sam marshall
4c31243fc7
MDL-43252 Group menu in wrong order when groupings used
2013-12-09 13:02:12 +00:00
Aaron Barnes
2eaa440c34
MDL-42913 lib/grouplib.php: Avoid cache sometimes for groups_get_all_groups
...
The new groups cache returns unexpected results when you pass
in a field parameter than would normally change the result array index
2013-11-20 11:56:42 +13:00
Ankit Agarwal
ef9ca10699
MDL-21415 reports: We should fetch active group from session not page params
...
Also donot allow active group to be set to something that user doesn't have access to
2013-09-12 11:18:25 +08:00
Ankit Agarwal
28c4399b6b
MDL-21415 reports: Adding support of groups to course participation reports
...
Also introducing new api groups_allgroups_course_menu() that generates a selector for all groups in course"
2013-09-10 13:14:33 +08:00
Marina Glancy
6d04c4f2a2
MDL-41192 course: Added property-read cm_info::effectivegroupmode
2013-09-10 14:11:36 +10:00
Marina Glancy
1171ad564b
MDL-40897 avoid extra DB queries in groups_get_activity_groupmode()
2013-07-28 18:47:57 +10:00
Ankit Agarwal
e481f05c0d
MDL-40354 groups: Fix issues in groups_group_visible()
2013-07-10 10:50:22 +08:00
Ankit Agarwal
2d4d29da06
MDL-40354 groups:groups_get_activity_allowed_groups() should use passed userid to check capabilities
2013-07-10 10:50:22 +08:00
Ankit Agarwal
e7eb992d3a
MDL-40354 groups: Add new api groups_group_visible()
2013-07-10 10:50:21 +08:00
Ankit Agarwal
475896bdbc
MDL-37100 webservices: Implement core_calendar_get_calendar_events()
2013-01-21 11:05:50 +08:00
Sam Hemelryk
e17dbeeb1a
MDL-34398 groups: implemented caching of group information.
2013-01-17 09:24:58 +13:00
Adrian Greeve
b0c6dc1cac
MDL-34465 - lib - Replacing get_context_instance with context_XXXX::instance (group 8)
2012-07-27 10:10:46 +08:00
Eloy Lafuente (stronk7)
dd420abadf
Merge branch 'MDL-24419-master' of git://github.com/sammarshallou/moodle
...
Conflicts:
lib/db/upgrade.php
lib/phpunit/lib.php
version.php
Fixed:
lib/db/upgrade.php - duplicate course->sectioncache add code
lib/db/install.xml - cleanup needed because xmldb editor was not used
lib/phpunit/classes/util.php - cleanup $GROUPLIB_CACHE on test reset
2012-05-16 23:53:47 +02:00
Andrew Robert Nicols
74b714df7e
MDL-32005 Add idnumber field to groups and groupings
2012-05-15 09:38:51 +01:00
sam marshall
ae3fbf7b06
MDL-24419 (2): Moved groupings cache to get_all_groupings function
...
There was a static cache inside course/lib.php. I need to access this
information in other places, so to avoid making two queries, I am
moving the cache into the groups_get_all_groupings function instead.
2012-05-14 11:15:15 +01:00
Adrian Greeve
4d8e241742
MDL-30997 - group - update of the api block documentation.
2012-02-21 11:17:27 +08:00
Petr Skoda
c160da9cb8
MDL-28450 prefer member group for default
2011-08-07 13:06:45 +02:00
Petr Skoda
998ced0805
MDL-26577 fix several groups and groupings issues
...
The current group in verified on each page which prevents problems when group settings are changed. The default group for course level is now using correct grouping id which solves problems when activity and course are using different grouping. The grouping is now displayed in group selector if user has access to all groups.
2011-04-10 13:31:17 +02:00
Petr Skoda
1d57f8622c
revert MDL-26577 added session cleaning to groups_get_activity_group() that fixes an issue with dirty session data. refactored session cleaning into one function, added caching to reduce queries.
...
(reverse-merged from commit 0d1e49d468
) This change was causing fatal errors on the course level, I am going to fix it myself.
2011-04-05 18:33:35 +02:00
Aparup Banerjee
0d1e49d468
MDL-26577 added session cleaning to groups_get_activity_group() that fixes an issue with dirty session data. refactored session cleaning into one function, added caching to reduce queries.
2011-04-05 12:22:27 +08:00
Eloy Lafuente (stronk7)
b967c54185
MDL-25708 recordsets - fix events/grade/group/moodle libs
2011-01-25 19:58:59 +01:00
Petr Skoda
2e24dd645e
MDL-25174 adding a workaround for old passwords that were hashed with magic quotes
2010-11-12 10:13:40 +00:00
Andrew Davis
078397d28e
gradebook MDL-21907 grader report group view was being limited to groups in the course's default grouping
2010-11-12 04:00:45 +00:00
Petr Skoda
78bfb562a0
MDL-21249 improved php docs and adding direct access prevention in core libs
2010-07-25 13:35:05 +00:00
Dan Marsden
5138bae0d7
MDL-23280 fix typo in var name
2010-07-15 08:21:41 +00:00
Petr Skoda
98da60215e
MDL-22033 groupings now enabled unconditionally, groupmembersonly kept as experimental - this simplifies groups code logic a bit, user interface changes should not be significant because the groupings are not visible much until at least one created; hopefully the new description of groupmembersonly will have to preventsome gradebook complaints
2010-04-07 07:37:12 +00:00
Petr Skoda
c564ee2ac8
MDL-21704 fixed recent regression
2010-02-23 16:39:56 +00:00
Petr Skoda
f8dab96615
MDL-20204 a lot more steps away from html_select
2010-02-10 09:37:50 +00:00
Sam Marshall
f1035deb97
MDL-21009 Group selector must use absolute links in order to work with javascript off
2009-11-30 17:12:48 +00:00
Petr Skoda
117bd74897
MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup
2009-11-01 11:31:16 +00:00
skodak
9a0df45a01
MDL-12886 new design of external service functions, groups api improved and known problems fixed - still work in progress with lots of todos - sorry
2009-09-14 23:52:08 +00:00
nicolasconnault
7b1f2c829f
MDL-19756 Renamed moodle_select to html_select for better API consistency
2009-08-10 08:38:45 +00:00
nicolasconnault
d81b05e701
MDL-19799 Converted calls to popup_form()
2009-08-10 03:39:21 +00:00