73 Commits

Author SHA1 Message Date
Dan Poltawski
f76bd72234 Merge branch 'MDL-38419' of https://github.com/moodlerooms/moodle 2013-10-28 12:33:39 +08:00
Sam Hemelryk
c3d2fbf9cd MDL-40931 useragent: separated user agent functionality into a lib
This commit moves user agent related functionality out of several
core libraries and combines it into a more manageable class.
All core uses are converted and functions deprecated in favor
of the new class.
2013-08-26 13:59:19 +12:00
Damyon Wiese
9ead041cdb Revert "MDL-40931 useragent: separated user agent functionality into a lib"
This reverts commit af62237d0e6e27df868d50848f7098f57c103f86.
This reverts commit 87a4194fdcd322d4aee5a6207b55a8da0864da94.
This reverts commit b2c66eb60c01805f26cc791966f05be52af7b406.

Conflicts:

	version.php
2013-08-22 13:31:25 +08:00
Sam Hemelryk
af62237d0e MDL-40931 useragent: separated user agent functionality into a lib
This commit moves user agent related functionality out of several
core libraries and combines it into a more manageable class.
All core uses are converted and functions deprecated in favor
of the new class.
2013-08-16 09:02:01 +12:00
Petr Škoda
2f1e464a88 MDL-40438 migrate all collatorlib:: and textlib:: uses 2013-08-06 21:04:35 +02:00
Sam Hemelryk
68736bd623 Merge branch 'MDL-40870' of https://github.com/moodlerooms/moodle 2013-08-06 14:47:38 +12:00
Sam Hemelryk
c7c020aad2 Merge branch 'MDL-39090_lti_dup_params' of https://github.com/moodlerooms/moodle 2013-08-06 10:23:45 +12:00
Mark Nielsen
533c42ea28 MDL-39090: Duplicate parameters in LTI launches
Removed endpoint query string params from body
to prevent param duplication.
2013-07-30 08:44:01 -07:00
Tim Hunt
cc12ae6c4f MDL-36399 LTI editing tool config breaks on Oracle.
Note that this fix will fail if the tool URL is longer than 1333
characters.
2013-07-26 10:38:17 +01:00
Mark Nielsen
7358471231 MDL-40870: Icon alt text in External Tool admin settings all read Accept 2013-07-24 14:44:25 -07:00
Mark Nielsen
adc23cc909 MDL-38419: External tool - when force SSL checked, URLs get corrupted 2013-06-27 13:29:35 -07:00
Mark Nielsen
e91be4ffa8 MDL-32301: Allow instructor custom parameters for LTI tools 2013-05-07 10:24:32 -07:00
Mark Nielsen
d81a603ee2 MDL-36060: Remove anonymous functions in mod/lti
This was breaking eaccelerator because it doesn't
support anonymous functions.
2013-04-30 17:50:07 +01:00
Eloy Lafuente (stronk7)
6d6bd5f114 MDL-32620 whitespace + comment fixes. 2013-02-19 13:21:18 +01:00
Eloy Lafuente (stronk7)
1ead0c63e9 Merge branch 'MDL-32620' of git://github.com/scriby/moodle 2013-02-19 13:13:43 +01:00
Mark Nielsen
e5ed5e6ab7 MDL-32620: Fixing up white space in comment 2013-02-13 09:21:03 -08:00
Adrian Fish
2a457227e2 MDL-37035 Pass user locale after course locale. 2012-12-17 10:25:38 +00:00
Frederic Massart
99938034df MDL-36782 usability: Adjustments following new mark as read icon 2012-11-27 13:46:21 +08:00
Frederic Massart
baf41e4b99 MDL-36802 usability: New icons used for LTI settings 2012-11-23 16:58:36 +08:00
Ankit Agarwal
c288a3dbf8 MDL-34467 lti: Repalce all instances of get_context_instanc() with respective context_XXX::instance() 2012-07-27 13:27:13 +08:00
Chris Scribner
1706e83bb4 Fixing an issue with not sending the launch_presentation_return_url 2012-04-24 10:48:47 -04:00
Petr Skoda
f8311defeb MDL-31301 use static textlib methods 2012-03-03 11:46:13 +01:00
Petr Skoda
33dca15616 MDL-30613 use standard https checks 2011-12-09 21:28:04 +01:00
Chris Scribner
4c598b133f MDL-20534 lti: Updating privacy settings dynamically based on matched Launch URL. 2011-11-21 16:42:12 +01:00
Eloy Lafuente (stronk7)
feeb52949f MDL-30328 some whitespace changes 2011-11-21 02:23:51 +01:00
Eloy Lafuente (stronk7)
27e5ce8b9f Merge branch 'MDL-30328' of git://github.com/scriby/moodle 2011-11-21 02:22:40 +01:00
Eloy Lafuente (stronk7)
e5235e6eef Merge branch 'MDL-30326' of git://github.com/scriby/moodle 2011-11-21 02:03:51 +01:00
Eloy Lafuente (stronk7)
5f72d1025b MDL-30354 lti - whitespace fixes 2011-11-21 01:57:24 +01:00
Eloy Lafuente (stronk7)
d167cc3397 Merge branch 'MDL-30354' of git://github.com/scriby/moodle 2011-11-21 01:48:52 +01:00
Chris Scribner
036e84c389 MDL-30354 lti - B27 - locallib changes 2011-11-18 12:38:41 -05:00
Chris Scribner
8f45215d1c MDL-20534 lti: B28 - Update attribution headers. 2011-11-17 16:29:50 -05:00
Charles Severance
6edcab7a1a MDL-20534
Undo change that Chris already did.
2011-11-17 10:35:07 -05:00
Charles Severance
461bde28d8 MDL-20534
Add the tool_consumer_info fields and fix parsing of custom parameters.
2011-11-17 10:34:58 -05:00
Chris Scribner
34eb05018f MDL-20534 lti: Some cleanup of locallib.php 2011-11-17 10:34:45 -05:00
Charles Severance
ddcfda87d6 MDL-20534
I ran the software through the certification and caught a few nits:

The error return is 'failure' not 'error'
The spec says that it needs to return 'failure' for out of range or non-numeric grades
The result score needs a language tag, hard-coded as 'en'
Setting a grade multiplied by 100 but reading the grade did not divide by 100
All those are now fixed with this patch as well as this bit of cruft:

I removed the "extension service url" as it is not implemented in service.php

Feel free to review and adjust - probably the one place you might want to refactor
is that I put code to catch out-of-range-and non-numeric in
lti_parse_grade_replace_message and threw an exception on error and then caught
it in service.php and sent back the 'failure' message. Feel free to refactor a
bit if you see this done in a cleaner manner.
2011-11-17 10:34:23 -05:00
Chris Scribner
0297a3d4b7 MDL-20534 lti: Updating the tool consumer information strings to match newest spec version. 2011-11-17 10:34:07 -05:00
Chris Scribner
776e5cfa0f MDL-20534 lti: B8 - Switching from $ME to $FULLME to properly detect SSL requests. 2011-11-17 09:35:56 -05:00
Eloy Lafuente (stronk7)
5f1362550f MDL-20534 lti: reformat queries and fix some errors 2011-11-08 02:12:39 +01:00
Chris Scribner
5de15b83cc MDL-20534 lti: Replacing <<< strings with normal multi-line strings. 2011-11-07 01:05:42 -05:00
Eloy Lafuente (stronk7)
fabd4fcf53 MDL-20534 lti: A4, add some todos towards unified Oauth 2011-11-06 22:05:11 -05:00
Eloy Lafuente (stronk7)
ea04a9f989 MDL-20534 lti: A3, coding style + some scope, constructors 2011-11-06 22:02:26 -05:00
Chris Scribner
e27cb316aa MDL-20534 lti: A3, whitespace fixes (Changes by stronk7) 2011-11-06 22:00:40 -05:00
Chris Scribner
61eb12d4df MDL-20534 lti: A3, copyright and DOS lf fixed 2011-11-06 21:51:06 -05:00
Chris Scribner
d8d0412168 Updating SSL settings & configuration for the LTI plugin. 2011-11-06 20:42:03 -05:00
Chris Scribner
1d4f052e46 Update role checking to check course role if module is not available 2011-11-06 20:42:02 -05:00
Chris Scribner
16cac56633 Fixing the method used to get LTI roles 2011-11-06 20:42:02 -05:00
Chris Scribner
feb30fd891 Only consider configured tools when receiving LTI web service calls 2011-11-06 20:42:01 -05:00
Chris Scribner
558be8fcef Adding a comment about the ext_submit button 2011-11-06 20:42:00 -05:00
Chris Scribner
c4d80efeb6 More work on the tool return page to help the user get the tool configured. 2011-11-06 20:42:00 -05:00
Chris Scribner
9d57ad1737 Fix a bug introduced recently that broke launches (adding the return url after signing). Trim the launch URL to prevent signature errors. 2011-11-06 20:41:59 -05:00