Petr Skoda
f2f45270ee
Merge branch 'MDL-26267' of git://github.com/samhemelryk/moodle
2011-02-07 23:07:16 +01:00
David Mudrak
32ea207a48
MDL-26298 Workshop: fixed trivial typos in phpDoc blocks
2011-02-07 10:49:34 +01:00
David Mudrak
d239b952a5
MDL-26296 Workshop: trivial change in manual allocator CSS
...
When only two rows of the allocations table are displayed with the new
allocation highlighted, it is better not highlight the odd row.
2011-02-07 10:49:30 +01:00
Sam Hemelryk
2addb4ba1b
mod-workshop MDL-26267 workshop_extend_navigation argument 4 is now always going to be a cm_info object
2011-02-07 13:20:09 +08:00
David Mudrak
51abc39695
MDL-26188 Workshop: get rid of a method that is not used anyway
...
The protected method get_allocations_recordset() is a relict from
earlier development phases of Workshop module. Removing it as it
confuses recent Eloy's recordset usage detection tool.
2011-02-04 14:33:48 +01:00
Petr Skoda
99d19c13ae
MDL-25855 some more missing filelib includes
2011-01-23 18:34:41 +01:00
David Mudrak
241e58e44b
MDL-25982 Workshop: users from the same group may be excluded from allocation in visible group mode
...
If the Workshop is in the visible group mode, members of the same group
can be now optionally excluded from random allocation for a given user.
2011-01-16 19:38:56 +01:00
David Mudrak
a1dc301ed5
MDL-25523 Workshop: not-grouped users are excluded from allocation in visible group mode
...
There was a bug as these users were ignored only as squares but not as
circles. This patch makes sure that no new allocation are added to
not-grouped users in visible group mode. However, the options 'Remove current
allocations' and 'Add self-assessments' apply to them intentionally.
Also, the user is warned if there are some not-grouped users found in a
workshop in visible groups mode or separate groups mode.
2011-01-16 19:38:37 +01:00
David Mudrak
47ce9385e8
MDL-25526 Workshop: fixed random allocation of reviews
...
The patch wraps that foreach ($circles as $circleid => $circle)
loop by yet another one for() loop. Reviews are allocated iteratively
now. During the first iteration, we try to make sure that at least one
circle link exists. During the second iteration, we try to allocate two,
etc. Circles are shuffled at the beginning of each iteration.
This is supposed to improve the randomness of the allocation.
The patch also fixes shuffle_assoc() implementation. The previous
implementation actually did not work at all. Also, that removed called
to shuffle_assoc() was redundant here.
2011-01-14 14:20:41 +01:00
David Mudrak
95d28f044e
MDL-25524 workshop: fixed random allocator removing current allocations
...
The bug was in filter_current_assessments() being applied before get_unkept_assessments()
so actually no current assessment records could be detected.
2010-12-07 11:39:50 +00:00
David Mudrak
0b5549de93
Workshop index page cleanup
2010-11-29 12:24:16 +00:00
David Mudrak
32a979e9a8
MDL-25436 workshop: fixed deprecated function call
...
Credit goes to Paul Ortman for the patch.
2010-11-29 12:23:42 +00:00
Petr Skoda
516c5eca68
MDL-24698 hopefully fixed all completion_info problems
2010-11-17 06:23:56 +00:00
Eloy Lafuente
f395cbddbd
MDL-23479 backup - now restoring workshop logs, thanks David for support!
2010-11-12 16:15:26 +00:00
David Mudrak
e7ff48d284
Fixed workshop view logging
...
add_to_log() used to log whole workshop name instead of just id. Thanks
to Eloy for spotting that.
2010-11-12 11:54:53 +00:00
David Mudrak
4588b17b2d
workshop: create empty legacy tables to keep DB consistency with install.xml
2010-11-12 10:33:13 +00:00
Eloy Lafuente
0f66acede0
MDL-22135 - logs restore, course and activities + cleanup
2010-11-11 19:46:04 +00:00
David Mudrak
cdff9eead3
NOMDL workshop more referential integrity checks
...
As reported by Trudy Koedooder at http://moodle.org/mod/forum/discuss.php?d=161322
there can be some orphaned grade records without the referenced
assessment. It threw upgrade error. Such grades are now just ignored
during the upgrade.
2010-11-10 16:02:07 +00:00
Sam Hemelryk
367a75fae4
themes lib MDL-24895 Multiple fixes to better handle overflow.
...
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
David Mudrak
c3a1f30f1c
Workshop aggregation is not expected to produce any output, just redirects back to the workshop main page
2010-11-04 14:45:03 +00:00
David Mudrak
5450f7b6c5
MDL-24765 workshop logging features reviewed
2010-10-20 13:13:45 +00:00
David Mudrak
c2a3526639
MDL-22507 workshop grading report rendering
2010-10-20 13:13:21 +00:00
David Mudrak
a8b309a37d
MDL-22507 workshop rendering of messages and allocation process fixed
2010-10-20 13:13:01 +00:00
David Mudrak
81b2288716
MDL-22507 workshop rendering fixed for submissions and example submissions
2010-10-20 13:12:31 +00:00
Sam Marshall
3a7507d081
chat, workshop MDL-24736 'require view' completion missing from these modules
2010-10-18 14:20:44 +00:00
David Mudrak
65601f04a3
MDL-21249 workshop and its subplugins: fixing phpdocs @package and @subpackage
2010-09-30 14:44:33 +00:00
David Mudrak
ac0f8f4559
MDL-19936 workshopform subplugins restore: use get_namefor() as mapping identifier
...
As I realized in rubric, get_namefor() should be used so that both
get_mapping() and get_new_parentid() can be used.
2010-09-30 12:05:59 +00:00
David Mudrak
8fa86fb8c4
MDL-19936 workshopform_rubric: fixed a bug causing Moodle Features Demo restore fail
2010-09-30 11:14:53 +00:00
David Mudrak
d318391c6b
MDL-19936 workshopeval_best: restore improved
2010-09-29 23:12:38 +00:00
David Mudrak
d5f5406610
MDL-19936 workshopform_rubric: restore implemented
2010-09-29 23:12:20 +00:00
David Mudrak
f1c8bb26d7
MDL-19936 workshopform_numerrors: restore implemented
2010-09-29 23:11:47 +00:00
David Mudrak
47861eaace
MDL-19936 workshopform_comments: restore implemented
2010-09-29 23:11:25 +00:00
David Mudrak
708684332d
MDL-19936 workshopform_accumulative restore improvements
2010-09-29 23:10:48 +00:00
Petr Skoda
6bdfef5da9
MDL-24321 switching to standard stdClass()
2010-09-21 08:54:01 +00:00
Petr Skoda
5924db724d
fixed a few spelling problems and standardised stdClass
2010-09-18 14:18:39 +00:00
Petr Skoda
1c5765dd7a
fixed missing cfg global
2010-09-18 14:02:32 +00:00
Petr Skoda
88bfbb926f
fixed $newdimension typos
2010-09-18 14:02:11 +00:00
Petr Skoda
edef454e08
exception typos fixed
2010-09-18 14:01:13 +00:00
Petr Skoda
b6aad59910
fixed css syntax errors
2010-09-18 13:57:24 +00:00
Petr Skoda
034ef76129
improved spelling
2010-09-18 12:31:20 +00:00
David Mudrak
76b3d9093a
MDL-24238 workshop: button to show all participants again after successful manual allocation
...
This replaces the closer of the status message. That bits of UI come
from very early times of workshop development and might be replaced
completely.
2010-09-18 00:25:04 +00:00
David Mudrak
eef46586e9
NOMDL workshop: fixing correct arguments order after recent Petr's play with property_exists()
2010-09-17 23:43:25 +00:00
Petr Skoda
4cc977a64d
fixing messed up property_exists() regression - sorrrry
2010-09-17 20:36:49 +00:00
David Mudrak
5452309a58
NOMDL workshop: improved SQL execution, use one query instead of loop
2010-09-17 13:26:10 +00:00
David Mudrak
1149b075c7
MDL-24091 workshop: deleting orphaned subplugins data in an upgrade step
2010-09-17 13:25:45 +00:00
David Mudrak
346af1a431
MDL-24091 workshop: deleting subplugins data together with the workshop instance
2010-09-17 13:24:52 +00:00
Petr Skoda
ef14c1e724
MDL-24090 new detection of plugins that were not upgraded to work with Moodle 2.x (uses $plugin->requires) + bumping ancient versions of plugins
2010-09-05 20:36:18 +00:00
Petr Skoda
dd88de0ebd
MDL-14679 fixed remaining old style update_record()s
2010-09-03 18:01:25 +00:00
Petr Skoda
b8ea3041eb
MDL-23184 activity names are now either PARAM_TEXT or PARAM_CLEANHTML, this should be more accurate
2010-09-02 18:29:39 +00:00
Sam Hemelryk
090417c109
workshop MDL-24046 Fixed SQL error in workshop submission validation
2010-09-02 03:22:46 +00:00
