Firstly - the list of roles to filter needs to be a combination of the assignable roles and the existing roles in the course.
Secondly - the auto-complete behat step needs to search for entire strings, not substrings.
We want to avoid page jumps wherever possible. This change uses the original select element as a "proxy" to reserve the space
in the DOM for the enhanced auto-complete when the JS runs.
It uses visibility: hidden to make the select not rendered - but still take up space.
The exact sizing for the CSS was determined by testing and reverse engineering the bootstrap calculations.
The size of user pictures in selectors was reduced to avoid flicker when switching between no selection and a selected user. I
could have reserved a larger amount of space, but it looks worse for pickers with no pictures.
Before the patch there were some problems with sorting
causing student1@ and student10@ to be sorted inconsistently
between databases.
Where that is not an important problem in real use, was
causing tests to fail consistently in sqlsrv.
So, adding student0@ to the tests in order to make them
stable collation-wise.
When users are automatically removed from the bulk action selection (due to a non-matching enrolment method)
we should show a warning to make it obvious.
This was done for indicators, targets and time splitting methods so that we
can get the string identifier and component in order to display a help_icon.
The functions were also made abstract, removing the default implementation.
Indicators, targets and time splitting methods should define this function.
This function used to check only those courses shared by both users
when it should have been checking all courses in which $user is
enrolled. Managers can view a user's course profile without necessarily
sharing the course (being enrolled in) with the $user.
The commit message above was my best attempt at meeting the very short restrictions on commit message first lines.
What it needed to say was: "Only show bulk enrolment operations for enrolment methods that have an instance in the course"
* Add coverage for the rendering of the edit/unenrol icons in the status
column.
* Add coverage for the rendering of the edit icon in the enrolment
details modal.
* Avoid usage of xpath_element selectors whenever possible.
The enrolment details popup should not have "Edit enrolment" as a primary action for the dialogue.
Instead it should just have an edit cog next to the enrolment name.
Href is required so that CSS can style these as clickable links (hand icon).
I also used comments to collapse the whitespace before and after the icons.
* Moved status_field to core_user\output namespace.
* Assigned status flags for the template context in order to determine
which label class to use for the given status.
Part of MDL-59290.
