Significant string changes:
* sitepolicies, core_admin - 'Site policies' changed to 'Site security
settings'
* processexpirationstask, enrol_paypal - more explanatory name
* sitepolicy_help and sitepolicyguest_help, core_admin - setting will
only have an effect if the site policy handler is set to default
* sitepolicyhandler_desc,core_admin - improved wording
* pathtodot_help, core_admin - Windows and Mac paths
* debugstringids_desc, core_admin - improved explanation
This includes:
- changing all usernames in feature to lowercase, for cross-db passing. Fixes:
- user/tests/behat/set_email_display.feature
- ensure that course_enrolment_manager::get_potential_users() and
external always returns user->maildisplay attribute, so email
visibility can be calculated by user_get_user_details(). Fixes:
- enrol/tests/behat/enrol_user.feature
- blocks/news_items/tests/behat/display_news.feature
- course/tests/behat/course_creation.feature
While testing the plugin in various scenarios, I've noticed that there
are two situations which the current code does not handle quite well:
* Detecting for existing txn_id record was likely to throw "found more
than one record" debugging message. Fixed by explicitly ignoring
multiple records.
* The incoming IPN verification message does not always contain the
recipient's email in the "business" field. When a payment has to be
claimed manually at PayPal (e.g. as a result of currencies mismatch
and other settings), the email is coming only in the "receiver_email"
field. This led to PHP notice and caused the script to fail falsely.
* We need to have unique feature names for our Behat tests.
* I also removed the custom Behat tag @role_visibility as we only allow
Behat tags with the component name in Frankenstyle format.
Similarly to what the previous patch does, we now change the default
sorting in functions enrol_get_users_courses() and
enrol_get_all_users_courses() too.
The patch also adds missing phpDocs for the functions, improves the
readability of some existing bits and mentions the changes in the
enrol/upgrade.txt file.
LTS (3.5) requires previous LTS (3.1)
This just deletes all the upgrade steps previous to 3.1.0. Some
small adjustments, like adding missing MOODLE_INTERNAL or tweaking
globals can also be applied when needed.
Also includes an upgrade step to prevent upgrading from any
version < 2016052300 (v3.1.0) as anti-cheating measure.
Next commit will get rid of/deprecate all the upgradelib functions
not used anymore in codebase.
