5135 Commits

Author SHA1 Message Date
Sara Arjona
0c71612294
MDL-80461 courseformat: Deprecate unused strings for topics and weeks 2024-01-19 08:53:17 +01:00
Shamim Rezaie
f11f30375d Merge branch 'MDL-79708-main' of https://github.com/ilyatregubov/moodle 2024-01-03 00:09:17 +11:00
Ilya Tregubov
b642d2710b MDL-79708 question_bank: Fix legacy filter condition.
build_query_from_filter method expects includesubcategories
to be inside filteroptions array
2023-12-11 11:27:21 +08:00
Philipp Imhof
b46453e457
MDL-80003 mod_quiz: watch all instances of tinyMCE 2023-12-07 17:29:43 +01:00
Huong Nguyen
2b59df00ef Merge branch 'MDL-80341' of https://github.com/timhunt/moodle 2023-12-07 10:27:37 +07:00
Jun Pataleta
030def7a46
Merge branch 'MDL-80079-master' of https://github.com/andrewnicols/moodle 2023-12-06 21:59:47 +08:00
Tim Hunt
c69ee049d1 MDL-80341 quiz: unseen descriptions are not unanswered questonis
This was causing confusing in the 'are you sure you want to submit' confirmation pop-up.
2023-12-06 11:11:59 +00:00
Jun Pataleta
c643ea197d
Merge branch 'MDL-79806_master' of https://github.com/marxjohnson/moodle 2023-12-05 12:48:41 +08:00
dragos5436
78e3edf3ef MDL-60632 mod_quiz: Fix chart rendering fail in quiz report
If a quiz activity has negative grading enabled for incorrect answers,
students can achieve overall negative grades in this quiz. If at least
one student achieves a negative grade, the chart at the bottom of the
quiz 'Results' tab will fail to display. This patch add a search for
negative results, removes them from the band below 0 and adds them to
the 0 band. This will make the chart render correctly again.

Co-authored-by: Susana Leitão <sleitao@uporto.pt>
Co-authored-by: Matthias Opitz <m.opitz@ucl.ac.uk>

Removed whitespace at end of lines
2023-12-01 15:17:42 +00:00
Mark Johnson
d1a4268839 MDL-79806 quiz_statistics: Queue recalculation on attempt_deleted 2023-11-30 08:54:14 +00:00
Mark Johnson
3fd2fefb5f MDL-79806 mod_quiz: Implement new quiz_attempt_deleted callback 2023-11-30 08:51:51 +00:00
Huong Nguyen
f2237faca5 Merge branch 'MDL-74378_master' of https://github.com/PhilippImhof/moodle 2023-11-30 10:10:12 +07:00
Jun Pataleta
d3d853bc2d
Merge branch 'MDL-79915-main' of https://github.com/sarjona/moodle 2023-11-29 18:11:56 +08:00
Sara Arjona
9e3acd9f06
MDL-79915 backup: Improve the Restore main page
Júlia, from the PX team, has suggested a few improvements to make it easier to
understand the Restore main page:

- Displaying a notification instead of the empty table when there are no files
in an area.
- Improve the copy, removing the help buttons and moving this information to the
main page.
- Replacing "Import a backup file" with "Upload a backup file".
- Adding some space between the different areas.
- Displaying a different text in the different "Manage backup files" buttons.
2023-11-29 09:19:46 +01:00
Jun Pataleta
ca7e0c26df
Merge branch 'MDL-80210' of https://github.com/timhunt/moodle 2023-11-28 10:36:17 +08:00
Philipp Imhof
e1cb2b3e0b
MDL-74378 mod_quiz: make sure timer is initialized 2023-11-24 08:51:41 +01:00
Tim Hunt
e7ab65f68e MDL-80210 quiz: fix default for reviewmaxmarks when upgrading
It is correct that the database default should be 0, to match
other similar columns, but when sites are upgraded, we need
to set the settings for all existing quizzes to match the previous
behaviour.
2023-11-23 10:55:10 +00:00
Huong Nguyen
e93a025823 Merge branch 'MDL-78496-main' of https://github.com/andrewnicols/moodle 2023-11-23 09:22:20 +07:00
Andrew Nicols
525212f2d2
MDL-78496 core: Address phpcs issues with upgrade.php files 2023-11-19 21:20:53 +08:00
Rodrigo Mady
22c114d21d MDL-78670 mod_quiz: Add offline atempt rule for sequential navigation 2023-11-17 20:16:01 -03:00
Andrew Nicols
545b36cd4a
MDL-78496 upgrade: remove all the < 4.1.0 upgrade steps
Also includes an upgrade step to prevent upgrading from any
version < 2021112802 (v4.1.0) as anti-cheating measure.
2023-11-17 23:25:36 +08:00
Andrew Nicols
dab4a2b66f
MDL-80079 core: Correct incorrect arg to format_string::$options 2023-11-14 22:28:55 +08:00
meirzamoodle
3ee7968552 MDL-79714 message: Enable all default notifications 2023-11-13 22:15:29 +07:00
Luca Bösch
9593d46512 MDL-71941 quiz_grading: use 'gradeverb' core string 2023-11-02 16:02:32 +01:00
Luca Bösch
628cb13e87 MDL-71941 mod_quiz: use 'gradenoun' core string 2023-11-02 16:02:32 +01:00
Mark Johnson
4552591eaa MDL-79807 quiz_statistics: Clear stats cache when question added/removed 2023-10-26 13:45:14 +01:00
Tim Hunt
ec0c4e18ad MDL-79747 quiz stats: task should run as admin the right way
The correct way to get an ad-hoc task to run as the main admin account
is to leave userid as null.

Setting it causes fatal errors if the main admin account is set to
auth: nologin.
2023-10-17 16:38:44 +01:00
Jun Pataleta
9beff03a96
MDL-79626 upgrade: add the 4.3.0 separation line to all upgrade scripts 2023-10-10 10:44:17 +08:00
Huong Nguyen
5ab3d0a02f
Merge branch 'MDL-79591-master' of https://github.com/sarjona/moodle 2023-10-05 09:35:10 +07:00
Jun Pataleta
98ac14eecb
Merge branch 'MDL-79531-master-1' of https://github.com/mihailges/moodle 2023-10-05 07:37:02 +08:00
Sara Arjona
d113c7f00e
MDL-79591 quiz: Fix the string for the completion condition 2023-10-04 16:40:40 +02:00
Mihail Geshoski
bef518efb8 MDL-79531 mod_quiz: Create only one random question in new category 2023-10-04 12:31:12 +02:00
Mihail Geshoski
451614016e MDL-79531 mod_quiz: Fix exception when adding random questions
Moves the data-filtercondition property to an element that always
exists regardless of whether the selected category from the filter
has questions or not. This will effectively solve the exception
that is being thrown due to the non-existing element and also
enable creation of random questions in a category that does not
have any questions yet. Also, the data-filtercondition attribute
is no longer used when creating a random question in a new category
as this value is not relevant in this case. Instead, a default
filter condition is generated in the webservice for the random
question based on the newly created category.
2023-10-04 12:31:12 +02:00
Sara Arjona
9877a06246
Merge branch 'MDL-79551-master-rc' of https://github.com/junpataleta/moodle 2023-10-04 12:28:14 +02:00
Jun Pataleta
94bc2cd38b
MDL-79551 versions: bump all versions and requires near release 2023-10-04 13:57:17 +08:00
Paul Holden
aa8ab48521 MDL-78971 quiz_grading: escape user identity fields on display. 2023-10-04 01:24:19 +00:00
Jun Pataleta
b19a93b989
Merge branch 'MDL-79507_master' of https://github.com/marxjohnson/moodle 2023-10-04 09:15:45 +08:00
Andrew Nicols
213fd0cdb3
MDL-78580 mod_quiz: Do not concatenate lang strings 2023-10-03 12:02:29 +08:00
Andrew Nicols
be8093e2c7
Merge branch 'MDL-78580_master' of https://github.com/marxjohnson/moodle 2023-10-03 11:05:42 +08:00
Jun Pataleta
6ee9522dfa
Merge branch 'MDL-79254_master' of https://github.com/marxjohnson/moodle 2023-10-03 09:42:25 +08:00
Jun Pataleta
cfc14c45bb
Merge branch 'MDL-79535' of https://github.com/paulholden/moodle 2023-10-03 09:21:12 +08:00
Mark Johnson
f462a48202 MDL-79507 quiz: Hide version info when rendering blocked questions 2023-09-29 09:31:36 +01:00
Ilya Tregubov
bd380a11ec
Merge branch 'MDL-79280' of https://github.com/paulholden/moodle 2023-09-29 09:53:35 +08:00
Paul Holden
a8c8967055
MDL-79535 mod_quiz: use dummy URL in random questions external call.
It's not required by the external method, however its absence causes
debugging warnings about missing page URL in the error logs.
2023-09-28 19:08:47 +01:00
Mark Johnson
e5a7a18ae2 MDL-79254 quiz_statistics: Convert recalculate task to ad-hoc
Previously, quiz statistics processing happened on a scheduled task.
This task looked for all quizzes with completed attempts, then
determined if those quizzes had a statistics calculation that's newer
than the most recent attempt, then ran the statistics calculation if
needed. It was hard coded to stop processing after 1 hour.

The queries involved in determining which quizzes needed processing
weren't terribly efficient, and combined with the 1 hour limit this made
the statistics unusable on large sites, where they are the most useful.

This converts the scheduled task to an ad-hoc task, and uses an event
observer for mod_quiz\event\attempt_submitted to queue a task when
it is needed. This removes the need for a query to work out what needs
processing, and allows the task processing to be scaled up as needed.
2023-09-27 15:43:15 +01:00
Paul Holden
efe3e377b6
MDL-79280 mod_quiz: Behat scenario for adding multiple user overrides. 2023-09-22 10:31:59 +01:00
Tim Hunt
83e840b8e7
MDL-79280 mod_quiz: consistently store ->cm as a cm_info 2023-09-22 10:31:59 +01:00
Andrew Nicols
e36d84ee31
Merge branch 'MDL-74054-master-fixes' of https://github.com/marxjohnson/moodle 2023-09-22 10:53:55 +08:00
Mark Johnson
63894ec2fe
MDL-74054 qbank_columnsortorder: Progressively enhance question bank actions
This modifies the question_data fragment used by the filter code to make its
parameters closer to the URL parameters of the question/edit.php page. This
Allows us to progressively enhance the add, remove and reset actions on the
question bank page, using this same fragment to reload the question table after
each change. This re-uses the same actions.js module used for enhancing these
actions on the qbank_columnsortorder admin screen.
2023-09-22 10:53:52 +08:00
Mark Johnson
82599bef84
MDL-74054 mod_quiz: Prevent question bank customisations in custom view 2023-09-22 10:53:52 +08:00