ensure that the order they are displayed in is always the same as the
order they have been defined in. See bug 553.
This involved API changes to the function get_all_instances_in_course()
still producing too much data and overflowing PHP memory on busier
sites (eg moodle.org).
Now, there are more database queries, which is unfortunate, but the
data is much more specific, and no sorting needs to be done, so
this is a performance boost.
I don't know how these will cancel out ... my guess is that very
small sites may be very slightly slower on the course page, but
that large sites will be much faster.
Let's see.
Moved COURSE_TEACHER_COLOR out to style sheets where it belongs (.teacheronly)
Added some efficiency when printing recent activity
- don't print more than one weeks worth of updates
- don't keep re-parsing logs once they've been used
- rename the main_frame variable to framename, because it
- might have caused some confusion
- none of the global variables have underscores
- put the config in the config table, with a default of _top
I've added the variable CFG->main_frame to config-dist.php, and replaced _top
targets with the variable in all the php files. HTML files, like those in the
documentation, have not been modified, as they are not (yet) parsed.
The variable should probably get moved into the config table, and get some
documentation.
I've also included, but commented out, a slight change in weblib.php, which
would guarantee that messages would be seen before redirecting the user (unless
delay intentionally set to 0 when redirect is used).
Firstly, I'm replacing all use of old-style global variables like
$HTTY_REFERER with their new-style equivalent $_SERVER["HTTP_REFERER"]
Also using $_POST instead $HTTP_POST_VARS etc
Secondly, if gdversion == 0 (ie GD is not installed) then:
- users are not even allowed to upload new images
- graphs now just print a message instead of failing.
this allows Moodle to still be used even if GD is not present
Should be fixed now. As a bonus, I've removed all the uses of
HTTP_POST_VARS from all scripts.
All forms should use the new data_submitted() function to collect
form data (it does the match_referer thing internally now).
Much nicer.
