41 Commits

Author SHA1 Message Date
mark-nielsen
fb992d716a Started to reorganize view.php 2006-09-10 02:38:09 +00:00
mark-nielsen
15f3d44ae7 Moved teacherview (lesson editing) out of view.php into edit.php
No code improvements in edit.php as of now.  Just works ;)
2006-09-10 02:09:14 +00:00
mark-nielsen
d1b025d013 Moved high scores logic out of view.php into highscores.php
Changed: now need to enter password on password protected lessons before being able to view high scores
Added logs to high scores and reworked logic
2006-09-10 01:20:00 +00:00
mark-nielsen
2163c22634 Forgot the lesson_ prefix 2006-09-09 22:23:50 +00:00
mark-nielsen
2cb24b647c Improved clock output and works when javascript is disabled 2006-09-09 22:20:51 +00:00
mark-nielsen
259990d2c6 Lesson buttons should now work with javascript disabled
Also improved the layout of action/continue.html
2006-09-09 21:39:11 +00:00
mark-nielsen
f15eb92c2c Removed essay grading code from view.php into essay.php. 2006-09-09 01:58:48 +00:00
mark-nielsen
6e1ff5c8fb MDL-6477: Added roles support.
Also added lesson_set_message() and lesson_print_message() to locallib.php
Also fixed problem in continue.html with not printing nextpageid
2006-09-08 23:17:18 +00:00
mark-nielsen
9fcf51d9bf Added function for printing a standard header for lesson
Added function for fetching course module, course and lesson based on course module id or lesson id
2006-09-06 04:02:02 +00:00
mark-nielsen
c87a341cb9 Merged bug fix for bug MDL-6323 2006-08-25 22:53:17 +00:00
skodak
46341ab710 Bug #5732 - Lesson Scores "out of XX" marks report incorrect mark; merged from MOODLE_16_STABLE 2006-07-10 21:52:12 +00:00
mark-nielsen
88427c077b [Merged][BugFix] Bug #5405 - made a new function that grades a lesson for a specific user's attempt. This is then used for grading lessons at the end of a lesson, for ongoing score feature and for updating the grade for essay question grading.
This new grading algorithm now enforces the lesson setting Max attempts when custom scoring is turned Off

Changed the reporting of minquestions setting to match the help file.  Now it is question based instead of attempt based.

Changed the reporting of ongoing score to use the new grade function.
2006-05-19 01:05:13 +00:00
mark-nielsen
a1d0b3eb81 [BugFix] Bug 5505 - function lesson_print_tree now checks for teacher editing priv before printing editing icons. Had to change arguments for this function as well which is the edit in view.php.
lesson.php how checks for teacher editing priv for all actions except for continue.  This is just in case the user hacks the URL.
2006-05-15 19:14:22 +00:00
mark-nielsen
90455bb3ab [Fixed] Import. Updated code to work with /question instead of /mod/quiz. Lead to a few interal bug fixes. Also moved two hard coded strings to the lang file. 2006-03-26 00:10:39 +00:00
mark-nielsen
97d2756c65 [New Feature] Tabbed navigation added to lesson (similar to quiz)
[Added] Graceful fails added to view.php, essay grading, and reports
[Changed] got rid of a lot of references to $_POST/GET/REQUEST
[Fixed] In reports, it required teacheredit, should only be teacher
[Changed] High scores - teachers can actually see them!  Also, improved output by using print_table and print_heading
[Changed] Grade essays now uses fullname() to print user names
2006-03-25 21:38:57 +00:00
mark-nielsen
0646963948 [Changed] function execute_teacherwarning to function lesson_display_teacher_warning because it was violating the function naming policy 2006-03-17 03:37:31 +00:00
mark-nielsen
4b55d2aff2 [Added] added phpdoc comments to locallib.php 2006-03-17 03:31:19 +00:00
michaelpenne
acab90991a BUG FIX: progress bar now does not break when student reviews the lesson.
BUG FIX: matching question type upgrade script now supports quotes.

CHANGED: Improved labels for form elements to improve accessibility.

NEW: added a skip navigation link for left menu.
2005-11-16 22:35:46 +00:00
michaelpenne
62eda6ea18 NEW: Progress bar option. Now a progress bar can be optionally displayed at the bottom of the lesson page.
NEW: Display Left Menu IF.  The left menu will only display if the student has a grade better than the one set in the lesson settings.  This is nice to allow only students who are reviewing the lesson to have access to the left menu.

BUG FIX: In Windows IE, the content was being aligned center.  Now, the content is explicitly aligned to left as default.
BUG FIX: High Scores variable was not spelled correctly at the End of Lesson.

ADDED: Div tags around branch tables.  This will allow users to choose to display them or not or move them around

CHANGED: converted more of the links to the stylized button.  Also, removed a lot of forms and javascript and replaced it with links with the variables in the href.
CHANGED: the slide show styles have been moved to the style sheet.
CHANGED: removed the CDC comments

Other minor changes have been made to the code as well.
2005-10-24 23:06:43 +00:00
michaelpenne
d6941aff55 Recoded most of the left menu:
Got rid of a table
Restructured and added more div tags in the left menu (much more logical)
Reworked the styles for the left menu in the styles sheet (everything should be customizable via style sheet)
More compatible with MacIE5
Added styles to the individual links in the menu (allows styling the for currently selected page and for all the rest)
Cleaned up the left menu link generation in locallib.php
2005-10-05 22:45:38 +00:00
michaelpenne
afbc9cbdc3 I think I have a solution for the problems with matching question type and upgrading moodle from 1.4.x to 1.5+.
View bug 3468 and this forum post for more information: http://moodle.org/mod/forum/discuss.php?d=27354
2005-07-14 20:00:45 +00:00
michaelpenne
dd192b2692 Numerical import was still looking at min/max arrays. I changed it so numerical will now subtract the tolerance from the answer to get the min and add the tolerance to the answer to get the max 2005-06-29 23:02:12 +00:00
michaelpenne
71ba4dce3c Discovered a bug with lesson grades. While calculating the grade, intval was used to truncate the decimals from the grade. intavl is now replaced with round. round will now round the grade to 5 decimal places. The database only holds int(3). So, this has been changed to float to hold decimal numbers. We have found this to be much more accurate when converting the stored percentage in the database back to a point value (before this fix, users were getting numbers like 46.5 points instead of their original 47 points due to an inaccurate percent value). Files changed for this fix include:
locallib.php
report.php
version.php
view.php
db/mysql.php
db/mysql.sql
db/postgres7.php
db/postgres7.sql
2005-06-09 21:24:17 +00:00
stronk7
271fea974f Tabs are out.
(all the module was using them, please change your editor settings to 4 spaces)
2005-05-16 22:41:19 +00:00
michaelpenne
9638a1f496 tried to make editing a lesson look nicer. Added generalbox class to tables and used tabs for selecting question types 2005-05-03 23:30:40 +00:00
stronk7
68dfc4deb6 Now lesson_pages->title supports filterall 2005-04-26 22:30:40 +00:00
michaelpenne
93943f6570 on line 1030, there was a division by zero when a student has not viewed any pages. Now it checks to makes sure $nviewed != 0. This is for the ongoing score feature. 2005-03-29 22:04:06 +00:00
michaelpenne
1c97019eaf removed lesson_clean_data_submitted() function. Removed all instances of its use before I did this 2005-03-10 20:51:26 +00:00
moodler
832b9f8204 Removed filter and put badwords list in string files 2005-03-05 03:14:45 +00:00
stronk7
ac8e16be13 Bye. Now all those tabs are out 2005-03-05 00:09:39 +00:00
michaelpenne
f7ffb898fa array/object initialization 2005-02-09 22:36:24 +00:00
michaelpenne
0733cc0062 made a change to lesson_clean_data_submitted and added some xhtml compliance fixes 2005-01-27 21:35:37 +00:00
michaelpenne
07fe38c02b added function lesson_clean_data_submitted(), this cleans the object made from data_submitted() function (forgot comments before) 2005-01-26 00:30:46 +00:00
michaelpenne
57bfe93dca added function lesson_clean_data_submitted(), this cleans the object made from data_submitted() function 2005-01-26 00:25:20 +00:00
michaelpenne
324da715f2 updated lesson_calculate_ongoing_score to match the grading algorithm used in view.php. Also suppressed a warning in lesson_print_tree_link_menu function. 2004-11-17 01:05:39 +00:00
moodler
2a488ba553 Some XHTML compatibility changes 2004-11-04 09:24:51 +00:00
michaelpenne
b986908256 changed lesson_calculate_ongoing_score function and added some comments 2004-11-01 20:18:26 +00:00
michaelpenne
c732188674 changed $pages[$count][0] to $pageid on line #617 2004-09-28 19:15:20 +00:00
michaelpenne
033c143250 put in Sebastien Michels change on line #911 2004-09-23 20:30:00 +00:00
michaelpenne
909e6c79d8 Fixed a bug regarding cluster jumps. Before, if end of cluster's jump was next page, it would throw an error. 2004-09-22 19:14:51 +00:00
michaelpenne
5e7856af58 Added a lot of new features to lesson mod. Check them out :)
MarkNielsen
2004-09-15 20:32:24 +00:00