204 Commits

Author SHA1 Message Date
Frederic Massart
91e5464282 MDL-53700 competency: Making CiBoT happier 2016-04-18 11:06:00 +08:00
Frederic Massart
07fc0ec380 MDL-53700 competency: Implementing a URL resolver 2016-04-18 11:06:00 +08:00
Damyon Wiese
8995c2702f MDL-52534 course: Course module form can be extended by plugins via callbacks.
3 new plugin callbacks are available to extend any course module form.

xx_coursemodule_standard_elements()
xx_coursemodule_validation()
xx_coursemodule_edit_post_actions()

This allows you to add elements to the form, extend the validation
and process the extra information once the module has been created/updated.
2016-04-18 10:58:52 +08:00
Mark Nelson
9621d5a7ae MDL-52252 core_course: removed unused variables
The call to 'context_coursecat::instance($COURSE->category);'
was causing Moodle to throw an exception due to non-existent
category.
2016-03-10 13:17:11 +01:00
Marina Glancy
1ea2f7d650 MDL-52252 tags: course module tags small correction 2016-03-09 15:33:25 +08:00
Nadav Kavalerchik
dffcf46f43 MDL-52252 Tags: Add tags to modules (Resources and Activities) 2016-03-09 14:19:47 +08:00
Mark Nelson
664d8be7ea MDL-48634 core: prevent change of grade values when necessary
Three additional checks have been added.

Once grades have been recorded for the activity/grade item -

1) Do not allow the grade type to be changed.
2) Do not allow the scale to be changed.
3) If we are using ratings do not allow the 'Maximum points'
value to be changed.

Also reordered form elements, removed form elements that
were not necessary, added and changed existing language
strings to improve the overall UI.
2016-02-09 17:46:42 +08:00
Damyon Wiese
d629c601c5 MDL-48634 grades: Add an option to rescale when changing the maxgrade 2016-02-05 18:20:17 +08:00
Marina Glancy
1a0df5535e MDL-52081 forms: Use __construct() for constructors 2015-12-10 13:38:01 +08:00
Mark Nelson
7080b38f2e MDL-50535 core_course: disabled 'gradepass' field when no ratings set 2015-07-24 13:31:18 -07:00
Marina Glancy
fc55273e0f MDL-50612 grades: remove gradepass if there is no grading 2015-07-14 13:16:34 +08:00
Pierre GUINOISEAU
7dc5dac678 MDL-50612 grades: do not remove grade box if gradepass field exists 2015-07-14 13:16:31 +08:00
Mark Nelson
9758da6ed5 MDL-50394 core_course: fixed form validation of 'gradepass' 2015-06-02 23:31:46 -07:00
Damyon Wiese
75ece778c5 Merge branch 'MDL-49101' of https://github.com/andrewhancox/moodle
Conflicts:
	lib/db/upgrade.php
	version.php
2015-04-07 17:27:17 +08:00
Andrew Hancox
6398ff5387 MDL-49101 core: Add a global admin setting config->requiremodintro
Removed requiremodintro setting from all core activity plugins and replace
with a single global setting.
Deprecated moodleform_mod::add_intro_editor and replaced with
moodleform_mod::standard_intro_elements
2015-04-07 10:11:53 +01:00
Marina Glancy
a824e60ab6 MDL-13831 course: validate gradepass only if needed 2015-03-25 10:59:33 +08:00
Marina Glancy
c977b35059 MDL-13831 grades: allow to set gradepass in mod_form 2015-03-23 11:11:37 +08:00
Gregory Faller
8164fad49d MDL-13831 course: add gradepass field to mod_form 2015-03-23 10:56:56 +08:00
sam marshall
a4c318325c MDL-47628 Availability: Restrict by selected grouping button 2014-11-28 15:55:41 +00:00
Sam Hemelryk
d28e0a2f76 MDL-47684 mod: better validation of rating options 2014-10-20 08:44:35 +13:00
Dan Poltawski
f6aaa184ab Revert "MDL-47684 mod: better validation of rating options"
This reverts commit 8028df293a4f024a954dc12ed4e6cb5161c951b0.
2014-10-17 14:27:49 +01:00
Sam Hemelryk
8028df293a MDL-47684 mod: better validation of rating options 2014-10-16 14:50:56 +13:00
sam marshall
4717a5fca6 MDL-44725 Availability: Replace groupmembersonly - forms (4)
Remove groupmembersonly option from module editing forms.
2014-09-02 13:03:13 +01:00
Dan Poltawski
4644e7d067 Merge branch 'MDL-45376-master' of https://github.com/sammarshallou/moodle 2014-05-06 11:16:32 +08:00
sam marshall
1710973161 MDL-45376 Completion: Form locking is still not working right
On submit of the form, it called 'freeze' on the completion-related
fields (even though they shouldn't have been frozen because you
already clicked the unlock button).
2014-05-01 18:08:46 +01:00
sam marshall
97c3c2c2cc MDL-27459 Completion: When ratings off, disallow grade completion
For activities that use ratings, there is no grade unless ratings
are enabled. The completion system still lets you select 'complete
when user gets a grade', which leads to later errors.

This change simply disables the 'completion on grade' field if
ratings are enabled for the activity, but not turned on in the form.
2014-04-29 10:28:34 +01:00
Damyon Wiese
515fe565f6 Merge branch 'MDL-44070-master' of https://github.com/sammarshallou/moodle
Conflicts:
	theme/bootstrapbase/less/moodle/forms.less
	theme/bootstrapbase/style/moodle.css
	version.php
2014-04-08 13:30:41 +08:00
James McQuillan
597662335d MDL-22999 core_grades: Added ability to configure maximum grade value both globally and for each graded-activity. 2014-04-07 16:02:37 -04:00
sam marshall
400c0fd229 MDL-44070 Conditional availability enhancements (7): forms
Changes to the module and section editing forms to use the new
fields and JavaScript.
2014-04-07 20:11:52 +01:00
Marina Glancy
3ba635344f MDL-43800 course: groupings are sorted alphabetically 2014-01-22 12:16:26 +08:00
Frederic Massart
d9203fb775 MDL-41611 format_singleactivity: Only hide unnecessary elements 2013-10-04 18:21:13 +08:00
Eric Merrill
4ed604996f MDL-41845 Activity Completion: Make default selection an option.
Makes an option to either default to the activity default, or default
to COMPLETION_TRACKING_NONE. This leaves open the possibility of
allowing activities to pick an actual default, instead of just on/off.
2013-09-25 11:41:07 +10:00
Petr Škoda
f9beaf4472 MDL-28094 fix subdirs support in module intro editor 2013-09-07 11:30:19 +02:00
Damyon Wiese
0c0dfa8fbd MDL-40668 tinymce: Remove collapsable editor options
We have an alternative (pdw toolbars)
Also, allow tinymce to be collapsed down to a single row.
2013-08-13 10:54:36 +08:00
Eric Merrill
7829d5d7c3 MDL-40412 course Expanding the height of module description fields.
Expanding the default height of mod descriptions to 10, which gives
you 3 real lines once TinyMCE Loads.
2013-07-01 10:24:38 -04:00
Damyon Wiese
54106942b3 MDL-37459 admin: Fix for error on updating a locked checkbox
Changed the way apply_admin_locked_flags gets the current value for the field.

The old way was plain wrong (looking at getValue from the quickform element).
2013-06-13 11:18:18 +10:00
Damyon Wiese
c30371168f MDL-37459 admin: Code improvements for admin defaults.
Split apply_admin_defaults_after_data so the defaults are set before
set_data is called.

Change function from private to protected.

Change check for if module for is an add or an update.
2013-06-12 14:10:55 +08:00
Damyon Wiese
fa358a83ad MDL-37459 admin: Change the behaviour of locked admin settings.
Now the defaults for settings will never force changes to the module update
form, and settings will only be locked if their value matches the admin default.
2013-06-12 12:30:08 +08:00
Damyon Wiese
19127f6f09 MDL-37459: Fix unprintable chars in wierd commit
Somehow some unprintable chars made it into the last commit.

Removing them all...
2013-06-11 13:25:28 +08:00
Damyon Wiese
3c88a67821 MDL-37459 admin: Admin settings flags
Make "Advanced" and "Lockable" flags for any admin setting.
2013-06-11 12:54:57 +08:00
Frederic Massart
381ab8e1a3 MDL-39599 course: Fix setType warning in conditional access 2013-05-10 12:17:01 +08:00
sam marshall
a9f5fc158c MDL-38315 Completion: Bugs with 'locked' status in activity form 2013-05-01 11:57:29 +01:00
Frederic Massart
1dcbdba62f MDL-38614 form: Reduce size of description field 2013-04-22 14:18:04 +08:00
Damyon Wiese
8af0dffb50 Merge branch 'MDL-34311-master' of git://github.com/danpoltawski/moodle
Conflicts:
	course/moodleform_mod.php
	lib/upgrade.txt
2013-03-26 13:46:29 +08:00
Dan Poltawski
9f9dde40ee MDL-34311 course: add missing type on cm idnumber
We must use PARAM_RAW for idnumbers because external systems could use
any characters and this is a linking field for external systems.
2013-03-25 09:30:52 +08:00
Frederic Massart
207c737dc0 MDL-38569 form: No advanced settings in Common module settings 2013-03-25 08:29:05 +08:00
sam marshall
3a09f4dc64 MDL-38035 Activity settings: Support multilang names for custom user fields 2013-03-12 15:05:24 +00:00
sam marshall
333e499c4b MDL-34612 Grade condition range validation allows impossible conditions 2012-11-07 10:54:23 +00:00
Ankit Agarwal
9a5e297b4c MDL-34470 course: Replace all instances of get_context_instance() with context_xxx::instance() in course/ 2012-07-24 16:19:01 +08:00
Sam Hemelryk
33e657c7e7 MDL-29538 core_condition: Pre-integration merge cleanup
* Fixed up database installation and upgrade code
* Reverted some whitespace optimisations to minimise conflicts
* Optimised commits made by Mark to reduce complexity and add tracker issue numbers
2012-06-26 15:18:53 +08:00