30570 Commits

Author SHA1 Message Date
Andrew Nicols
58814af9f1 Merge branch 'MDL-77018_401' of https://github.com/timhunt/moodle into MOODLE_401_STABLE 2023-02-09 10:51:48 +08:00
Andrew Nicols
d3040a763a Merge branch 'MDL-77057-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-09 10:21:06 +08:00
Paul Holden
130f5c1dd6 Merge branch 'MDL-76542-401' of https://github.com/lameze/moodle into MOODLE_401_STABLE 2023-02-08 14:22:11 +00:00
Simey Lameze
d17117ab02 MDL-76542 behat: add step to go to user edit page directly 2023-02-08 12:24:27 +08:00
Jun Pataleta
dbe40db138 Merge branch 'MDL-76569-401' of https://github.com/andrewnicols/moodle into MOODLE_401_STABLE 2023-02-07 22:49:08 +08:00
Jun Pataleta
a574be993c Merge branch 'MDL-76089-401' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-02-07 15:34:51 +08:00
Marina Glancy
d9d9d42c81 MDL-76089 lib: upgrade horde library 2023-02-07 15:29:32 +08:00
Andrew Nicols
0b586e839d Merge branch 'MDL-77023-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-07 12:48:09 +08:00
Andrew Nicols
61f1700fbf Merge branch 'mdl-76729_401' of https://github.com/james-cnz/moodle into MOODLE_401_STABLE 2023-02-07 12:37:16 +08:00
Andrew Nicols
0ce350e78a Merge branch 'MDL-75946-401' of https://github.com/davewoloszyn/moodle into MOODLE_401_STABLE 2023-02-07 10:44:40 +08:00
Paul Holden
d69579a060 Merge branch 'MDL-76370-publicpaths-proxying-MOODLE_401_STABLE' of https://github.com/jaydn/moodle into MOODLE_401_STABLE 2023-02-06 11:02:45 +00:00
Paul Holden
ae355c5749 Merge branch 'MDL-76447-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-02-03 14:31:30 +00:00
David Woloszyn
562d62474e MDL-75946 lib_horde: Fixed deprecated FILTER_SANITIZE_STRING 2023-02-03 12:58:32 +11:00
Andrew Nicols
aa1b0c5ebd Merge branch 'MDL-75085-401-4' of https://github.com/junpataleta/moodle into MOODLE_401_STABLE 2023-02-02 12:02:47 +08:00
Andrew Nicols
f0d9073159 Merge branch 'MDL-76675_401' of https://github.com/stronk7/moodle into MOODLE_401_STABLE 2023-02-02 11:03:38 +08:00
Jun Pataleta
920ac6dbe5 Merge branch 'MDL-77092-m401' of https://github.com/sammarshallou/moodle into MOODLE_401_STABLE 2023-02-02 09:57:06 +08:00
Jun Pataleta
e87a6484bf MDL-75085 external: Pass proper $required param value in tests 2023-02-02 09:07:17 +08:00
Andrew Nicols
6f073ebe6d Merge branch 'MDL-77001-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-02 08:27:21 +08:00
Andrew Nicols
885d191df2 Merge branch 'MDL-77003-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-02-02 08:20:51 +08:00
Meirza
e7f9631b7e MDL-76447 editor_tiny: revert the z-index.
Nesting the dropdown menu inside the parent DOM makes the menu can display correctly
without changing the z-index.
2023-02-01 17:39:34 +07:00
Meirza
f37f6e3439 MDL-76447 editor_tiny: Nest the dropdown menu in the parent DOM.
The TinyMCE menu has a significant issue with the Overflow style,
and the Boost theme heavily uses Overflow for drawer navigation.
Nest the dropdown menu container into the parent editor container makes it work correctly.

Co-authored-by: davewoloszyn <david.woloszyn@moodle.com>
Co-authored-by: xr0master <xr0master@gmail.com>
2023-02-01 17:39:34 +07:00
Andrew Nicols
421ae9cb83 Merge branch 'MDL-75945-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-01-31 22:12:28 +08:00
sam marshall
f5dc8c4f9f MDL-77092 Behat: Expand all fieldsets fails with single fieldset
The Behat step to expand all fieldsets did not work if the page
contains only one fieldset.
2023-01-31 13:58:08 +00:00
Andrew Nicols
7dfb4c229c Merge branch 'MDL-77081-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-31 21:45:05 +08:00
Paul Holden
6acc34a097 MDL-77081 forms: PHP8.1 compatibility for group/textarea elements.
See related changes in b0a83aa7, we can no longer pass null values
to some string related methods.
2023-01-31 10:51:20 +00:00
Tim Hunt
db861ee6d3 MDL-77018 qbank_statistics: only load stats for contexts that exist
Also, pre-load the contexts for efficiency.
2023-01-27 20:51:51 +00:00
Paul Holden
d78d372a1e MDL-77057 group: format group names in module override pages. 2023-01-27 11:50:55 +00:00
Eloy Lafuente (stronk7)
8b31b8e8d0 MDL-76675 date: Only test all TZ names with PHPUNIT_LONGTEST enabled
It happens often that some timezone is renamed, split, added to the
IANAs list of timezones (that, for PHP is kept updated by the
php-timezonedb PECL extension).

When the information coming from the extension changes, all the
PHPUnit jobs in the world start failing (that's when CIs update
their PHP images, when devs update their packages, ...).

So, what we are doing here is to move that test that check for
every single string existing to be run only when PHPUNIT_LONGTEST
is enabled. That way only places running all tests will run that
one. And every other run just will skip it.

This corresponds to point 1 & 2 of the issue, lower impact in general
and, still be able to enable the tests to run.
2023-01-27 08:48:22 +01:00
Andrew Nicols
62118364f2 Merge branch 'MDL-76562-401' of https://github.com/meirzamoodle/moodle into MOODLE_401_STABLE 2023-01-27 14:24:26 +08:00
Jun Pataleta
a360fd0601 Merge branch 'MDL-76977-401' of https://github.com/paulholden/moodle into MOODLE_401_STABLE 2023-01-25 16:10:18 +08:00
Paul Holden
0a86c6a123 MDL-77003 javascript: improve string helper JSON detection.
Changes in fbc2732d made the JS template string helper method
too strict in regards to what it considers a valid JSON object.

Co-authored-by: Mike Churchward <mike@brickfieldlabs.ie>
2023-01-24 22:16:21 +00:00
Paul Holden
4b43da100c MDL-77023 javascript: always normalise component of lang strings.
Co-authored-by: David Matamoros <davidmc@moodle.com>
2023-01-24 16:44:06 +00:00
Andrew Nicols
710d0ef8f2 MDL-75945 core: Convert a floating value to an integer.
In PHP 8.1, any implicit conversion of float to int, which leads to a loss in precision, is now deprecated.
To avoid the error warning, the code must explicitly convert a floating value to an integer.
2023-01-24 16:53:34 +07:00
Paul Holden
e0358d2eca MDL-77001 tiny_autosave: use valid lang string during privacy export. 2023-01-23 22:06:33 +00:00
Eloy Lafuente (stronk7)
e6dfa9ff3c MDL-76362 output: Preserve original behaviour for PHP 8.1
Whenever the page_requirements_manager::js_fix_url()
is called with null url, it must throw an exception and emit 0 warnings.

It's covered by an explicit test:

test_js_fix_url_coding_exception with data set "Provide a null argument"
2023-01-23 09:17:48 +08:00
Andrew Nicols
8f4bd4ce11 MDL-76362 core: Coding style fixes 2023-01-23 09:16:08 +08:00
Andrew Nicols
a4ea607c24 MDL-76362 core: Short circuit s() on empty values 2023-01-23 09:16:08 +08:00
Andrew Nicols
dbfb5eaa45 MDL-76362 core: Short-circuit strip_querystring on empty values 2023-01-23 09:16:08 +08:00
Andrew Nicols
788d86d7a3 MDL-76362 core_file: Check prefix exists before checking length 2023-01-23 09:16:07 +08:00
Andrew Nicols
a1f4f7bac5 MDL-76362 core: plugin names must be strings to be valid 2023-01-23 09:16:07 +08:00
Andrew Nicols
d08319ddf7 MDL-76362 core: Update core_component plugin name tests 2023-01-23 09:16:07 +08:00
Andrew Nicols
de4de9cec5 MDL-76362 core: Test coursealias before using 2023-01-23 09:16:07 +08:00
Andrew Nicols
5fbbb51882 MDL-76362 core: Use empty default string when getting prefs
The json_decode function does not accept a null, which is the
traditional default for get_user_preferences. By passing a default of
am empty string we avoid issues in PHP 8.1.
2023-01-23 09:16:06 +08:00
Marina Glancy
2dd7290ccb MDL-76362 various: Avoid passing nulls to functions that don't allow nulls
PHP 8.1 is more strict on the parameter type. Functions such as trim(), strlen(), str_replace(), etc
show notice when null is passed as an argument
2023-01-23 09:16:06 +08:00
Marina Glancy
d83368a475 MDL-76362 mustache: Override parent method to avoid PHP notices
Parent method checks baseDir that is null in this case. This shows notices under PHP 8.1
2023-01-23 09:16:06 +08:00
Paul Holden
a68f5c6d37 MDL-76977 phpunit: ensure unique data provider keys in mustache test. 2023-01-20 17:21:27 +00:00
Meirza
fb935957b8 MDL-76562 editor_tiny: Added functions to remove button/menu/submenu.
Added a few functions to remove the toolbar button, menubar and sub-menu items.
One of the implementations is to remove the justify alignment in the toolbar and
the sub-menu items to aid the accessibility aspect of the TinyMCE editor.
2023-01-20 10:02:06 +07:00
Jun Pataleta
396fff3d0b Merge branch 'MDL-76537_401' of https://github.com/stronk7/moodle into MOODLE_401_STABLE 2023-01-19 11:23:51 +08:00
Paul Holden
70a5e38b2c MDL-70070 phpunit: correct data provider method names.
They should not be prefixed `test_` because that's how actual
test methods containing assertions are identified by PHPUnit.
2023-01-16 08:28:31 +00:00
Jaydn Cunningham
a2e37371a6 MDL-76370 curl: suppress CONNECT header when using HTTP proxy 2023-01-16 14:04:26 +10:30