mirror of
https://github.com/moodle/moodle.git
synced 2025-01-17 21:49:15 +01:00
93f4f3494a
Static variables do not behave the way you might expect when accessing them through the classes inheritance. When accessing a method via self:: or static:: operators, even though the method is inherited, its variable scope is not. So the method unique_sql_parameter() was using the scope of the child class and each child class had its own sequence of usp1, usp2, usp3, ... placeholders. This led to "Incorrect number of query parameters" error when multiuple condition classes were contributing to a single SQL query. All credit should go to Adam Olley who debugged and described the essence of the problem in the tracker.