mirror of
https://github.com/moodle/moodle.git
synced 2025-01-31 12:45:04 +01:00
20180b3167
There were two main reasons why there were PHP errors. 1) We were not passing variables as references. 2) When we were restricting the number of items shown in the report we were not collecting all of the dependencies which were required when a user did *not* have the capability 'moodle/grade:viewhidden'. This would cause an undefined offset error due to the index missing in the dependency array. This also meant that a user without the capability 'moodle/grade:viewhidden' could view the course total without hidden items being taken into account if they were not being displayed. To resolve this we now pass all the grades and grade items when the user does not have the capability - which also solves the PHP errors listed above.