mirror of
https://github.com/moodle/moodle.git
synced 2025-03-28 11:32:42 +01:00
4b03530ca8
There was a bug with the code to strip comments. https://github.com/matthiasmullie/minify/issues/317 Applying the fix as a Moodle-specific change for now, because the effect is significant.
24 lines
1.2 KiB
Plaintext
24 lines
1.2 KiB
Plaintext
Description of MatthiasMullie\Minify import into Moodle
|
|
|
|
1) Download https://github.com/matthiasmullie/minify/archive/1.3.51.zip and unzip
|
|
|
|
mv minify-1.3.51/src /path/to/moodle/lib/minify/matthiasmullie-minify/
|
|
mv minify-1.3.51/data /path/to/moodle/lib/minify/matthiasmullie-minify/
|
|
|
|
2) Download https://github.com/matthiasmullie/path-converter/archive/1.1.0.zip and unzip
|
|
|
|
mv path-converter-1.1.0/src/ /path/to/moodle/lib/minify/matthiasmullie-pathconverter/
|
|
|
|
Local changes applied:
|
|
|
|
MDL-67115: php 74 compliance - implode() params order. Note this has been fixed upstream
|
|
by https://github.com/matthiasmullie/minify/pull/300 so, whenever this library is updated
|
|
check if the fix is included and remove this note.
|
|
|
|
MDL-68191: https://github.com/matthiasmullie/minify/issues/317 is a bug that stops
|
|
large sections of the CSS from being minimised, and also is a huge performance drain.
|
|
We have applied the fix sent upstream because the performance win is so big.
|
|
(E.g. one case I measured, with the bug was 40 seconds to minify CSS, with the fix was
|
|
a few seconds. This is one of the reasons Behat runs in the browser are so slow.)
|
|
Whenever this library is updated check if the fix is included and remove this note.
|