mirror of
https://github.com/moodle/moodle.git
synced 2025-01-17 21:49:15 +01:00
3020d180d8
As part of implementing this, there is a new more efficient method get_version_information_for_questions_in_attempt to see if any questions in a quiz need to be updated. The regrade code was updated to take advantage of this. Co-authored-by: Khoa Nguyen Dang <khoanguyend7@nashtechglobal.com>
256 lines
12 KiB
PHP
256 lines
12 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
namespace mod_quiz;
|
|
|
|
use core_question\local\bank\condition;
|
|
use mod_quiz\external\submit_question_version;
|
|
use mod_quiz\question\bank\qbank_helper;
|
|
|
|
defined('MOODLE_INTERNAL') || die();
|
|
|
|
require_once(__DIR__ . '/quiz_question_helper_test_trait.php');
|
|
|
|
/**
|
|
* Question versions test for quiz.
|
|
*
|
|
* @package mod_quiz
|
|
* @category test
|
|
* @copyright 2021 Catalyst IT Australia Pty Ltd
|
|
* @author Safat Shahin <safatshahin@catalyst-au.net>
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
* @covers \mod_quiz\question\bank\qbank_helper
|
|
*/
|
|
class quiz_question_version_test extends \advanced_testcase {
|
|
use \quiz_question_helper_test_trait;
|
|
|
|
/** @var \stdClass user record. */
|
|
protected $student;
|
|
|
|
/**
|
|
* Called before every test.
|
|
*/
|
|
public function setUp(): void {
|
|
global $USER;
|
|
parent::setUp();
|
|
$this->setAdminUser();
|
|
$this->course = $this->getDataGenerator()->create_course();
|
|
$this->student = $this->getDataGenerator()->create_user();
|
|
$this->user = $USER;
|
|
}
|
|
|
|
/**
|
|
* Test the quiz question data for changed version in the slots.
|
|
*/
|
|
public function test_quiz_questions_for_changed_versions() {
|
|
$this->resetAfterTest();
|
|
$quiz = $this->create_test_quiz($this->course);
|
|
// Test for questions from a different context.
|
|
$context = \context_module::instance(get_coursemodule_from_instance("quiz", $quiz->id, $this->course->id)->id);
|
|
$questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
|
|
// Create a couple of questions.
|
|
$cat = $questiongenerator->create_question_category(['contextid' => $context->id]);
|
|
$numq = $questiongenerator->create_question('essay', null,
|
|
['category' => $cat->id, 'name' => 'This is the first version']);
|
|
// Create two version.
|
|
$questiongenerator->update_question($numq, null, ['name' => 'This is the second version']);
|
|
$questiongenerator->update_question($numq, null, ['name' => 'This is the third version']);
|
|
quiz_add_quiz_question($numq->id, $quiz);
|
|
// Create the quiz object.
|
|
$quizobj = \mod_quiz\quiz_settings::create($quiz->id);
|
|
$structure = \mod_quiz\structure::create_for_quiz($quizobj);
|
|
$slots = $structure->get_slots();
|
|
$slot = reset($slots);
|
|
// Test that the version added is 'always latest'.
|
|
$this->assertEquals(3, $slot->version);
|
|
$quizobj->preload_questions();
|
|
$quizobj->load_questions();
|
|
$questions = $quizobj->get_questions();
|
|
$question = reset($questions);
|
|
$this->assertEquals(3, $question->version);
|
|
$this->assertEquals('This is the third version', $question->name);
|
|
// Create another version.
|
|
$questiongenerator->update_question($numq, null, ['name' => 'This is the latest version']);
|
|
// Check that 'Always latest is working'.
|
|
$quizobj->preload_questions();
|
|
$quizobj->load_questions();
|
|
$questions = $quizobj->get_questions();
|
|
$question = reset($questions);
|
|
$this->assertEquals(4, $question->version);
|
|
$this->assertEquals('This is the latest version', $question->name);
|
|
$structure = \mod_quiz\structure::create_for_quiz($quizobj);
|
|
$slots = $structure->get_slots();
|
|
$slot = reset($slots);
|
|
$this->assertEquals(4, $slot->version);
|
|
// Now change the version using the external service.
|
|
$versions = qbank_helper::get_version_options($slot->questionid);
|
|
// We don't want the current version.
|
|
$selectversions = [];
|
|
foreach ($versions as $version) {
|
|
if ($version->version === $slot->version) {
|
|
continue;
|
|
}
|
|
$selectversions [$version->version] = $version;
|
|
}
|
|
// Change to version 1.
|
|
submit_question_version::execute($slot->id, (int)$selectversions[1]->version);
|
|
$quizobj->preload_questions();
|
|
$quizobj->load_questions();
|
|
$questions = $quizobj->get_questions();
|
|
$question = reset($questions);
|
|
$this->assertEquals(1, $question->version);
|
|
$this->assertEquals('This is the first version', $question->name);
|
|
$structure = \mod_quiz\structure::create_for_quiz($quizobj);
|
|
$slots = $structure->get_slots();
|
|
$slot = reset($slots);
|
|
$this->assertEquals(1, $slot->version);
|
|
// Change to version 2.
|
|
submit_question_version::execute($slot->id, $selectversions[2]->version);
|
|
$quizobj->preload_questions();
|
|
$quizobj->load_questions();
|
|
$questions = $quizobj->get_questions();
|
|
$question = reset($questions);
|
|
$this->assertEquals(2, $question->version);
|
|
$this->assertEquals('This is the second version', $question->name);
|
|
$structure = \mod_quiz\structure::create_for_quiz($quizobj);
|
|
$slots = $structure->get_slots();
|
|
$slot = reset($slots);
|
|
$this->assertEquals(2, $slot->version);
|
|
}
|
|
|
|
/**
|
|
* Test if changing the version of the slot changes the attempts.
|
|
*/
|
|
public function test_quiz_question_attempts_with_changed_version() {
|
|
$this->resetAfterTest();
|
|
$quiz = $this->create_test_quiz($this->course);
|
|
// Test for questions from a different context.
|
|
$context = \context_module::instance(get_coursemodule_from_instance("quiz", $quiz->id, $this->course->id)->id);
|
|
$questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
|
|
// Create a couple of questions.
|
|
$cat = $questiongenerator->create_question_category(['contextid' => $context->id]);
|
|
$numq = $questiongenerator->create_question('numerical', null,
|
|
['category' => $cat->id, 'name' => 'This is the first version']);
|
|
// Create two version.
|
|
$questiongenerator->update_question($numq, null, ['name' => 'This is the second version']);
|
|
$questiongenerator->update_question($numq, null, ['name' => 'This is the third version']);
|
|
quiz_add_quiz_question($numq->id, $quiz);
|
|
[, , $attemptobj] = $this->attempt_quiz($quiz, $this->student);
|
|
$this->assertEquals('This is the third version', $attemptobj->get_question_attempt(1)->get_question()->name);
|
|
// Create the quiz object.
|
|
$quizobj = \mod_quiz\quiz_settings::create($quiz->id);
|
|
$structure = \mod_quiz\structure::create_for_quiz($quizobj);
|
|
$slots = $structure->get_slots();
|
|
$slot = reset($slots);
|
|
// Now change the version using the external service.
|
|
$versions = qbank_helper::get_version_options($slot->questionid);
|
|
// We dont want the current version.
|
|
$selectversions = [];
|
|
foreach ($versions as $version) {
|
|
if ($version->version === $slot->version) {
|
|
continue;
|
|
}
|
|
$selectversions [$version->version] = $version;
|
|
}
|
|
// Change to version 1.
|
|
$this->expectException('moodle_exception');
|
|
submit_question_version::execute($slot->id, (int)$selectversions[1]->version);
|
|
[, , $attemptobj] = $this->attempt_quiz($quiz, $this->student, 2);
|
|
$this->assertEquals('This is the first version', $attemptobj->get_question_attempt(1)->get_question()->name);
|
|
// Change to version 2.
|
|
submit_question_version::execute($slot->id, (int)$selectversions[2]->version);
|
|
[, , $attemptobj] = $this->attempt_quiz($quiz, $this->student, 3);
|
|
$this->assertEquals('This is the second version', $attemptobj->get_question_attempt(1)->get_question()->name);
|
|
// Create another version.
|
|
$questiongenerator->update_question($numq, null, ['name' => 'This is the latest version']);
|
|
// Change to always latest.
|
|
submit_question_version::execute($slot->id, 0);
|
|
[, , $attemptobj] = $this->attempt_quiz($quiz, $this->student, 4);
|
|
$this->assertEquals('This is the latest version', $attemptobj->get_question_attempt(1)->get_question()->name);
|
|
}
|
|
|
|
public function test_get_version_information_for_questions_in_attempt(): void {
|
|
$this->resetAfterTest();
|
|
/** @var \mod_quiz_generator $quizgenerator */
|
|
$quizgenerator = $this->getDataGenerator()->get_plugin_generator('mod_quiz');
|
|
/** @var \core_question_generator $questiongenerator */
|
|
$questiongenerator = $this->getDataGenerator()->get_plugin_generator('core_question');
|
|
|
|
// Make two categories, each with a question.
|
|
$coursecontext = \context_course::instance($this->course->id);
|
|
$cat = $questiongenerator->create_question_category(
|
|
['name' => 'Non-random questions', 'context' => $coursecontext->id]);
|
|
$randomcat = $questiongenerator->create_question_category(
|
|
['name' => 'Random questions', 'context' => $coursecontext->id]);
|
|
$q1 = $questiongenerator->create_question('truefalse', null, ['category' => $cat->id]);
|
|
$q2 = $questiongenerator->create_question('truefalse', null, ['category' => $randomcat->id]);
|
|
|
|
// Make the quiz, adding q1, and a random question from randomcat.
|
|
$quiz = $quizgenerator->create_instance([
|
|
'course' => $this->course->id,
|
|
'grade' => 100.0,
|
|
'sumgrades' => 2,
|
|
'canredoquestions' => 1,
|
|
'preferredbehaviour' => 'immediatefeedback',
|
|
]);
|
|
$quizobj = quiz_settings::create($quiz->id);
|
|
quiz_add_quiz_question($q1->id, $quiz);
|
|
$structure = $quizobj->get_structure();
|
|
$structure->add_random_questions(0, 1, [
|
|
'filter' => [
|
|
'category' => [
|
|
'jointype' => condition::JOINTYPE_DEFAULT,
|
|
'values' => [$randomcat->id],
|
|
'filteroptions' => ['includesubcategories' => false],
|
|
],
|
|
],
|
|
]);
|
|
|
|
// Student starts attempt.
|
|
$quizobj = quiz_settings::create($quiz->id);
|
|
$attempt = quiz_prepare_and_start_new_attempt($quizobj, 1, null);
|
|
$attemptobj = quiz_attempt::create($attempt->id);
|
|
|
|
// Answer both questions.
|
|
$postdata = $questiongenerator->get_simulated_post_data_for_questions_in_usage(
|
|
$attemptobj->get_question_usage(),
|
|
[1 => 'True', 2 => 'False'],
|
|
true,
|
|
);
|
|
$attemptobj->process_submitted_actions(time(), false, $postdata);
|
|
|
|
// Redo both questions - need to re-create attemptobj each time.
|
|
$attemptobj = quiz_attempt::create($attempt->id);
|
|
$attemptobj->process_redo_question(1, time());
|
|
$attemptobj = quiz_attempt::create($attempt->id);
|
|
$attemptobj->process_redo_question(2, time());
|
|
|
|
// Edit both questions to make a second version.
|
|
$questiongenerator->update_question($q1);
|
|
$questiongenerator->update_question($q2);
|
|
|
|
// Finally! call the method we want to test.
|
|
$versioninfo = qbank_helper::get_version_information_for_questions_in_attempt(
|
|
$attemptobj->get_attempt(), $attemptobj->get_context());
|
|
|
|
// Verify - all questions should now want to be V2 for various reasons.
|
|
$this->assertEquals(2, $versioninfo[1]->newversion);
|
|
$this->assertEquals(2, $versioninfo[2]->newversion);
|
|
$this->assertEquals(2, $versioninfo[3]->newversion);
|
|
$this->assertEquals(2, $versioninfo[4]->newversion);
|
|
}
|
|
}
|