mirror of
https://github.com/moodle/moodle.git
synced 2025-02-19 07:41:02 +01:00
820b41e34f
Previously, we had overridden the _generateId method in almost all subclasses; and then we mostly, but not always; ignored the value that was generated there, and instead generated new (nicer) values in MoodleQuickForm_Renderer::renderElement. Of course, that is not really a logical place to (re)generate ids. I have fixed the code so that the _generateId method now uses the 'nice id' algorithm from renderElement. This should make the whole code flow more logical. This make all our overriding of _generateId unnecessary. We do need a special _generateId for radio buttons, because you often have different radio buttons with the same name but different values. This change should only change the ids on radio, checkbox and advcheckbox elements. Previously, those were essentially random, so I don't think anyone could have been relying on the particular values. This commit also has new unit tests, first to test the basic _generateId algorithm, and then to create and render an example form (including some tricky things like repeat_elements) and chech the acutal ids in the generated HTML.
72 lines
2.0 KiB
PHP
72 lines
2.0 KiB
PHP
<?php
|
|
require_once('HTML/QuickForm/radio.php');
|
|
|
|
/**
|
|
* HTML class for a radio type element
|
|
*
|
|
* @author Jamie Pratt
|
|
* @access public
|
|
*/
|
|
class MoodleQuickForm_radio extends HTML_QuickForm_radio{
|
|
/**
|
|
* html for help button, if empty then no help
|
|
*
|
|
* @var string
|
|
*/
|
|
var $_helpbutton='';
|
|
function MoodleQuickForm_radio($elementName=null, $elementLabel=null, $text=null, $value=null, $attributes=null) {
|
|
parent::HTML_QuickForm_radio($elementName, $elementLabel, $text, $value, $attributes);
|
|
}
|
|
/**
|
|
* set html for help button
|
|
*
|
|
* @access public
|
|
* @param array $help array of arguments to make a help button
|
|
* @param string $function function name to call to get html
|
|
*/
|
|
function setHelpButton($helpbuttonargs, $function='helpbutton'){
|
|
debugging('component setHelpButton() is not used any more, please use $mform->setHelpButton() instead');
|
|
}
|
|
/**
|
|
* get html for help button
|
|
*
|
|
* @access public
|
|
* @return string html for help button
|
|
*/
|
|
function getHelpButton(){
|
|
return $this->_helpbutton;
|
|
}
|
|
|
|
/**
|
|
* Slightly different container template when frozen.
|
|
*
|
|
* @return string
|
|
*/
|
|
function getElementTemplateType(){
|
|
if ($this->_flagFrozen){
|
|
return 'static';
|
|
} else {
|
|
return 'default';
|
|
}
|
|
}
|
|
/**
|
|
* Returns the disabled field. Accessibility: the return "( )" from parent
|
|
* class is not acceptable for screenreader users, and we DO want a label.
|
|
* @return string
|
|
*/
|
|
function getFrozenHtml()
|
|
{
|
|
$output = '<input type="radio" disabled="disabled" id="'.$this->getAttribute('id').'" ';
|
|
if ($this->getChecked()) {
|
|
$output .= 'checked="checked" />'.$this->_getPersistantData();
|
|
} else {
|
|
$output .= '/>';
|
|
}
|
|
return $output;
|
|
}
|
|
function toHtml()
|
|
{
|
|
return '<span>' . parent::toHtml() . '</span>';
|
|
}
|
|
}
|