mirror of
https://github.com/moodle/moodle.git
synced 2025-04-05 08:23:01 +02:00
MDL-45580 introduced the readonlypages filearea, and when loading page images for an attempt, the code would check if the pages existed , creating them if not. The code inside this block also contained a guard clause for the case where no readonly pages existed - which is a situation that should not happen. Whenever readonly pages are requested, they should exist. MDL-66626 introduced a situation where page counts not matching would also retrigger page generation. However this led to a situation where the guard clause could be entered when requesting readonly pages. This patch refactors the guard clause, and improves the logic to regenerate pages.
…
…
…
…
…
…
…
…
…
…
…
…
.-..-. _____ | || | /____/-.---_ .---. .---. .-.| || | .---. | | _ _ |/ _ \/ _ \/ _ || |/ __ \ * | | | | | || |_| || |_| || |_| || || |___/ |_| |_| |_|\_____/\_____/\_____||_|\_____) Moodle - the world's open source learning platform Moodle <https://moodle.org> is a learning platform designed to provide educators, administrators and learners with a single robust, secure and integrated system to create personalised learning environments. You can download Moodle <https://download.moodle.org> and run it on your own web server, ask one of our Moodle Partners <https://moodle.com/partners/> to assist you, or have a MoodleCloud site <https://moodle.com/cloud/> set up for you. Moodle is widely used around the world by universities, schools, companies and all manner of organisations and individuals. Moodle is provided freely as open source software, under the GNU General Public License <https://docs.moodle.org/dev/License>. Moodle is written in PHP and JavaScript and uses an SQL database for storing the data. See <https://docs.moodle.org> for details of Moodle's many features.
Description
Languages
PHP
78.1%
JavaScript
14.6%
Gherkin
3.5%
CSS
1.7%
Mustache
1.6%
Other
0.4%