mirror of
https://github.com/moodle/moodle.git
synced 2025-02-13 20:36:42 +01:00
48f69e418c
The recent change completely removed support for general URIs and enforced strict URL validation which was breaking backwards compatibility and was not user friendly at all. This patch finally adds full URI support with basic validation and fixes some older xhtml strict issues. Please note we do not try to explain the difference between URL and URI to our users. Also keep in mind that mod/url has XSS risk and does not do any security validation of the data.
88 lines
3.1 KiB
PHP
88 lines
3.1 KiB
PHP
<?php
|
|
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* URL module main user interface
|
|
*
|
|
* @package mod
|
|
* @subpackage url
|
|
* @copyright 2009 Petr Skoda {@link http://skodak.org}
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
require('../../config.php');
|
|
require_once("$CFG->dirroot/mod/url/locallib.php");
|
|
require_once($CFG->libdir . '/completionlib.php');
|
|
|
|
$id = optional_param('id', 0, PARAM_INT); // Course module ID
|
|
$u = optional_param('u', 0, PARAM_INT); // URL instance id
|
|
$redirect = optional_param('redirect', 0, PARAM_BOOL);
|
|
|
|
if ($u) { // Two ways to specify the module
|
|
$url = $DB->get_record('url', array('id'=>$u), '*', MUST_EXIST);
|
|
$cm = get_coursemodule_from_instance('url', $url->id, $url->course, false, MUST_EXIST);
|
|
|
|
} else {
|
|
$cm = get_coursemodule_from_id('url', $id, 0, false, MUST_EXIST);
|
|
$url = $DB->get_record('url', array('id'=>$cm->instance), '*', MUST_EXIST);
|
|
}
|
|
|
|
$course = $DB->get_record('course', array('id'=>$cm->course), '*', MUST_EXIST);
|
|
|
|
require_course_login($course, true, $cm);
|
|
$context = get_context_instance(CONTEXT_MODULE, $cm->id);
|
|
require_capability('mod/url:view', $context);
|
|
|
|
add_to_log($course->id, 'url', 'view', 'view.php?id='.$cm->id, $url->id, $cm->id);
|
|
|
|
// Update 'viewed' state if required by completion system
|
|
$completion = new completion_info($course);
|
|
$completion->set_module_viewed($cm);
|
|
|
|
$PAGE->set_url('/mod/url/view.php', array('id' => $cm->id));
|
|
|
|
// Make sure URL exists before generating output - some older sites may contain empty urls
|
|
// Do not use PARAM_URL here, it is too strict and does not support general URIs!
|
|
$exturl = trim($url->externalurl);
|
|
if (empty($exturl) or $exturl === 'http://') {
|
|
url_print_header($url, $cm, $course);
|
|
url_print_heading($url, $cm, $course);
|
|
url_print_intro($url, $cm, $course);
|
|
notice(get_string('invalidstoredurl', 'url'), new moodle_url('/course/view.php', array('id'=>$cm->course)));
|
|
die;
|
|
}
|
|
unset($exturl);
|
|
|
|
if ($redirect) {
|
|
// coming from course page or url index page,
|
|
// the redirection is needed for completion tracking and logging
|
|
$fullurl = url_get_full_url($url, $cm, $course);
|
|
redirect(str_replace('&', '&', $fullurl));
|
|
}
|
|
|
|
switch (url_get_final_display_type($url)) {
|
|
case RESOURCELIB_DISPLAY_EMBED:
|
|
url_display_embed($url, $cm, $course);
|
|
break;
|
|
case RESOURCELIB_DISPLAY_FRAME:
|
|
url_display_frame($url, $cm, $course);
|
|
break;
|
|
default:
|
|
url_print_workaround($url, $cm, $course);
|
|
break;
|
|
}
|