mirror of
https://github.com/moodle/moodle.git
synced 2025-01-18 05:58:34 +01:00
f2a6b9cac9
When marking workflow is on and the grade is not released we never send notifications anyway. Instead of preventing the grading form from submitting (validation error) we silently ignore it.
106 lines
3.7 KiB
PHP
106 lines
3.7 KiB
PHP
<?php
|
|
// This file is part of Moodle - http://moodle.org/
|
|
//
|
|
// Moodle is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// Moodle is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
/**
|
|
* This file contains the forms to create and edit an instance of this module
|
|
*
|
|
* @package mod_assign
|
|
* @copyright 2012 NetSpot {@link http://www.netspot.com.au}
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
|
|
defined('MOODLE_INTERNAL') || die('Direct access to this script is forbidden.');
|
|
|
|
|
|
require_once($CFG->libdir.'/formslib.php');
|
|
require_once($CFG->dirroot . '/mod/assign/locallib.php');
|
|
require_once('HTML/QuickForm/input.php');
|
|
|
|
/**
|
|
* Assignment grade form
|
|
*
|
|
* @package mod_assign
|
|
* @copyright 2012 NetSpot {@link http://www.netspot.com.au}
|
|
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
|
|
*/
|
|
class mod_assign_grade_form extends moodleform {
|
|
/** @var assignment $assignment */
|
|
private $assignment;
|
|
|
|
/**
|
|
* Define the form - called by parent constructor.
|
|
*/
|
|
public function definition() {
|
|
$mform = $this->_form;
|
|
|
|
list($assignment, $data, $params) = $this->_customdata;
|
|
// Visible elements.
|
|
$this->assignment = $assignment;
|
|
$assignment->add_grade_form_elements($mform, $data, $params);
|
|
|
|
if ($data) {
|
|
$this->set_data($data);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* This is required so when using "Save and next", each form is not defaulted to the previous form.
|
|
* Giving each form a unique identitifer is enough to prevent this
|
|
* (include the rownum in the form name).
|
|
*
|
|
* @return string - The unique identifier for this form.
|
|
*/
|
|
protected function get_form_identifier() {
|
|
$params = $this->_customdata[2];
|
|
return get_class($this) . '_' . $params['userid'];
|
|
}
|
|
|
|
/**
|
|
* Perform minimal validation on the grade form
|
|
* @param array $data
|
|
* @param array $files
|
|
*/
|
|
public function validation($data, $files) {
|
|
global $DB;
|
|
$errors = parent::validation($data, $files);
|
|
$instance = $this->assignment->get_instance();
|
|
|
|
// Advanced grading.
|
|
if (!array_key_exists('grade', $data)) {
|
|
return $errors;
|
|
}
|
|
|
|
if ($instance->grade > 0) {
|
|
if (unformat_float($data['grade'], true) === false && (!empty($data['grade']))) {
|
|
$errors['grade'] = get_string('invalidfloatforgrade', 'assign', $data['grade']);
|
|
} else if (unformat_float($data['grade']) > $instance->grade) {
|
|
$errors['grade'] = get_string('gradeabovemaximum', 'assign', $instance->grade);
|
|
} else if (unformat_float($data['grade']) < 0) {
|
|
$errors['grade'] = get_string('gradebelowzero', 'assign');
|
|
}
|
|
} else {
|
|
// This is a scale.
|
|
if ($scale = $DB->get_record('scale', array('id'=>-($instance->grade)))) {
|
|
$scaleoptions = make_menu_from_list($scale->scale);
|
|
if ((int)$data['grade'] !== -1 && !array_key_exists((int)$data['grade'], $scaleoptions)) {
|
|
$errors['grade'] = get_string('invalidgradeforscale', 'assign');
|
|
}
|
|
}
|
|
}
|
|
return $errors;
|
|
}
|
|
}
|