mirror of
https://github.com/moodle/moodle.git
synced 2025-01-19 06:18:28 +01:00
4cf11157c2
Problem: In Moodle 4.2, an unintended change in behaviour occurred when locking and unlocking grade items. Previously, in Moodle 4.1, locking a grade item and then subsequently unlocking the grade item left specific grades for students still locked if they were being locked individually. However, in Moodle 4.2, the unintended change caused the individual grades to be unlocked along with the grade item. Solution: To address this issue, I modified the set_locked calls in action.php to pass the cascade parameter as false. Now, when locking or unlocking a grade item, only the grade item itself is affected, leaving individual grades unchanged. I have also modified the locking behaviour in the grade_category class. So, similarly, when locking or unlocking a grade category, the change applies only to the grade items and grade categories within the category, without expanding to individual grades. Explanation: By making this change, we ensure that the locking mechanism behaves as expected, providing a consistent and desirable user experience. Locking and unlocking a grade item or category will no longer inadvertently affect individual grades, preserving their locked status and avoiding loss of data when unlocking a grade item associated with the total mark of a category.