mirror of
https://github.com/moodle/moodle.git
synced 2025-01-19 14:27:22 +01:00
f3ecea3af4
* Fix coalesce on postgres. * The edit icon's alt shows the HTML entities causing * enrol/tests/behat/add_to_group.feature Contains a '@doit' tag which I assume is there from testing. * group/classes/output/user_groups_editable.php ** Missing MOODLE_INTERNAL check. ** Unused variables context_system and moodle_exception. ** The PHPDocs for the constructors are wrong. ** export_for_template() returns an array, not stdClass (according to parent docs). ** Change moodle_exception to coding_exception at the beginning. * group/lib.php ** Missing docs for core_group_inplace_editable(). * user/classes/participants_table.php ** The docs for the class variables $groups, $course and $context need a '\' beforehand as they are in a namespace. ** I would prefer $this->context = $context; and $this->groups = ... to be done at the end of the constructor with the other class variable assignments. ** You could get rid of the class variable courseid if we are setting course and use $this->course->id instead. ** The function col_groups has @param \stdclass $row but it should be $data * lib/amd/src/form-autocomplete.js and lib/amd/src/inplace_editable.js ** Some issues here CiBot has pointed out. * lib/classes/output/inplace_editable.php ** @see should be on a new line.